From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 23 Feb 2018 12:33:00 +0000 Subject: [PATCH] usb: host: ohci-pxa27x: Fix and & vs | typo Message-Id: <20180223123300.GA1062@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alan Stern Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org The code is supposed to clear the RH_A_NPS and RH_A_PSM bits, but it's a no-op because of the & vs | typo. This bug predates git and it was only discovered using static analysis so it must not affect too many people in real life. Signed-off-by: Dan Carpenter --- Not tested. diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c index 3e2474959735..7679fb583e41 100644 --- a/drivers/usb/host/ohci-pxa27x.c +++ b/drivers/usb/host/ohci-pxa27x.c @@ -148,7 +148,7 @@ static int pxa27x_ohci_select_pmm(struct pxa27x_ohci *pxa_ohci, int mode) uhcrhda |= RH_A_NPS; break; case PMM_GLOBAL_MODE: - uhcrhda &= ~(RH_A_NPS & RH_A_PSM); + uhcrhda &= ~(RH_A_NPS | RH_A_PSM); break; case PMM_PERPORT_MODE: uhcrhda &= ~(RH_A_NPS); From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: host: ohci-pxa27x: Fix and & vs | typo From: Dan Carpenter Message-Id: <20180223123300.GA1062@mwanda> Date: Fri, 23 Feb 2018 15:33:00 +0300 To: Alan Stern Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org List-ID: VGhlIGNvZGUgaXMgc3VwcG9zZWQgdG8gY2xlYXIgdGhlIFJIX0FfTlBTIGFuZCBSSF9BX1BTTSBi aXRzLCBidXQgaXQncwphIG5vLW9wIGJlY2F1c2Ugb2YgdGhlICYgdnMgfCB0eXBvLiAgVGhpcyBi dWcgcHJlZGF0ZXMgZ2l0IGFuZCBpdCB3YXMKb25seSBkaXNjb3ZlcmVkIHVzaW5nIHN0YXRpYyBh bmFseXNpcyBzbyBpdCBtdXN0IG5vdCBhZmZlY3QgdG9vIG1hbnkKcGVvcGxlIGluIHJlYWwgbGlm ZS4KClNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNv bT4KLS0tCk5vdCB0ZXN0ZWQuCgotLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2Vu ZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9keSBvZiBhIG1lc3Nh Z2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBo dHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwKCmRpZmYgLS1naXQgYS9k cml2ZXJzL3VzYi9ob3N0L29oY2ktcHhhMjd4LmMgYi9kcml2ZXJzL3VzYi9ob3N0L29oY2ktcHhh Mjd4LmMKaW5kZXggM2UyNDc0OTU5NzM1Li43Njc5ZmI1ODNlNDEgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvdXNiL2hvc3Qvb2hjaS1weGEyN3guYworKysgYi9kcml2ZXJzL3VzYi9ob3N0L29oY2ktcHhh Mjd4LmMKQEAgLTE0OCw3ICsxNDgsNyBAQCBzdGF0aWMgaW50IHB4YTI3eF9vaGNpX3NlbGVjdF9w bW0oc3RydWN0IHB4YTI3eF9vaGNpICpweGFfb2hjaSwgaW50IG1vZGUpCiAJCXVoY3JoZGEgfD0g UkhfQV9OUFM7CiAJCWJyZWFrOwogCWNhc2UgUE1NX0dMT0JBTF9NT0RFOgotCQl1aGNyaGRhICY9 IH4oUkhfQV9OUFMgJiBSSF9BX1BTTSk7CisJCXVoY3JoZGEgJj0gfihSSF9BX05QUyB8IFJIX0Ff UFNNKTsKIAkJYnJlYWs7CiAJY2FzZSBQTU1fUEVSUE9SVF9NT0RFOgogCQl1aGNyaGRhICY9IH4o UkhfQV9OUFMpOwo=