From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v5 7/9] drm: Expose modes with aspect ratio, only if requested Date: Fri, 23 Feb 2018 16:36:47 +0200 Message-ID: <20180223143647.GM5453@intel.com> References: <1518697262-3001-1-git-send-email-ankit.k.nautiyal@intel.com> <1518697262-3001-8-git-send-email-ankit.k.nautiyal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BCD26F17F for ; Fri, 23 Feb 2018 14:36:52 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1518697262-3001-8-git-send-email-ankit.k.nautiyal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Nautiyal, Ankit K" Cc: Jose Abreu , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBGZWIgMTUsIDIwMTggYXQgMDU6NTE6MDBQTSArMDUzMCwgTmF1dGl5YWwsIEFua2l0 IEsgd3JvdGU6Cj4gRnJvbTogQW5raXQgTmF1dGl5YWwgPGFua2l0LmsubmF1dGl5YWxAaW50ZWwu Y29tPgo+IAo+IFdlIHBhcnNlIHRoZSBFRElEIGFuZCBhZGQgYWxsIHRoZSBtb2RlcyBpbiB0aGUg Y29ubmVjdG9yJ3MgbW9kZWxpc3QuCj4gVGhpcyBhZGRzIENFQSBtb2RlcyB3aXRoIGFzcGVjdCBy YXRpbyBpbmZvcm1hdGlvbiB0b28sIHJlZ2FkbGVzcyBvZgo+IHdoZXRoZXIgdXNlciBzcGFjZSBy ZXF1ZXN0ZWQgdGhpcyBpbmZvcm1hdGlvbiBvciBub3QuCj4gCj4gVGhpcyBwYXRjaCBwcnVuZXMg dGhlIG1vZGVzIHdpdGggYXNwZWN0LXJhdGlvIGluZm9ybWF0aW9uLCBmcm9tIGEKPiBjb25uZWN0 b3IncyBtb2RlbGlzdCwgaWYgdGhlIHVzZXItc3BhY2UgaGFzIG5vdCBzZXQgdGhlIGFzcGVjdCBy YXRpbwo+IERSTSBjbGllbnQgY2FwLgo+IAo+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogU2hhc2hhbmsgU2hhcm1hIDxzaGFzaGFuay5zaGFy bWFAaW50ZWwuY29tPgo+IENjOiBKb3NlIEFicmV1IDxqb3NlLmFicmV1QHN5bm9wc3lzLmNvbT4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBBbmtpdCBOYXV0aXlhbCA8YW5raXQuay5uYXV0aXlhbEBpbnRl bC5jb20+Cj4gCj4gVjM6IEFzIHN1Z2dlc3RlZCBieSBWaWxsZSwgbW9kaWZpZWQgdGhlIG1lY2hh bmlzbSBvZiBwcnVuaW5nIG9mIG1vZGVzCj4gICAgIHdpdGggYXNwZWN0LXJhdGlvLCBpZiB0aGUg YXNwZWN0LXJhdGlvIGlzIG5vdCBzdXBwb3J0ZWQuIEluc3RlYWQKPiAgICAgb2Ygc3RyYWlnaHQg YXdheSBwcnVuaW5nIHN1Y2ggYSBtb2RlLCB0aGUgbW9kZSBpcyByZXRhaW5lZCB3aXRoCj4gICAg IGFzcGVjdCByYXRpbyBiaXRzIHNldCB0byB6ZXJvLCBwcm92aWRlZCBpdCBpcyB1bmlxdWUuCj4g VjQ6IHJlYmFzZQo+IFY1OiBBZGRyZXNzZWQgcmV2aWV3IGNvbW1lbnRzIGZyb20gVmlsbGU6Cj4g ICAgIC11c2VkIGEgcG9pbnRlciB0byBzdG9yZSBsYXN0IHZhbGlkIG1vZGUuCj4gICAgIC1hdm9p ZGVkLCBtb2RpZnlpbmcgb2YgcGljdHVyZV9hc3BlY3RfcmF0aW8gaW4ga2VybmVsIG1vZGUsCj4g ICAgICBpbnN0ZWFkIG9ubHkgZmxhZ3MgYml0cyBvZiB1c2VyIG1vZGUgYXJlIHJlc2V0IChpZiBh c3BlY3QtcmF0aW8KPiAgICAgIGlzIG5vdCBzdXBwb3J0ZWQpLgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vZHJtX2Nvbm5lY3Rvci5jIHwgNDUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDUgZGVsZXRp b25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMg Yi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gaW5kZXggMTZiOWMzOC4uNDk3Nzhl OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYwo+IEBAIC0xNTA3LDggKzE1MDcsMTAgQEAg c3RhdGljIHN0cnVjdCBkcm1fZW5jb2RlciAqZHJtX2Nvbm5lY3Rvcl9nZXRfZW5jb2RlcihzdHJ1 Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmUKPiAgCXJldHVybiBjb25uZWN0b3ItPmVuY29kZXI7Cj4g IH0KPiAgCj4gLXN0YXRpYyBib29sIGRybV9tb2RlX2V4cG9zZV90b191c2Vyc3BhY2UoY29uc3Qg c3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUsCj4gLQkJCQkJIGNvbnN0IHN0cnVjdCBkcm1f ZmlsZSAqZmlsZV9wcml2KQo+ICtzdGF0aWMgYm9vbAo+ICtkcm1fbW9kZV9leHBvc2VfdG9fdXNl cnNwYWNlKGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpsYXN0X21vZGUsCj4gKwkJCSAg ICAgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUsCgpJIHdvdWxkIHB1dCB0aGUg J21vZGUnIGFyZ3VtZW50IGZpcnN0IHNpbmNlIHRoYXQncyB0aGUgIm1haW4iIG9iamVjdAp3ZSdy ZSBvcGVyYXRpbmcgb24uCgo+ICsJCQkgICAgIGNvbnN0IHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9w cml2KQo+ICB7Cj4gIAkvKgo+ICAJICogSWYgdXNlci1zcGFjZSBoYXNuJ3QgY29uZmlndXJlZCB0 aGUgZHJpdmVyIHRvIGV4cG9zZSB0aGUgc3RlcmVvIDNECj4gQEAgLTE1MTYsNiArMTUxOCwyMyBA QCBzdGF0aWMgYm9vbCBkcm1fbW9kZV9leHBvc2VfdG9fdXNlcnNwYWNlKGNvbnN0IHN0cnVjdCBk cm1fZGlzcGxheV9tb2RlICptb2RlLAo+ICAJICovCj4gIAlpZiAoIWZpbGVfcHJpdi0+c3RlcmVv X2FsbG93ZWQgJiYgZHJtX21vZGVfaXNfc3RlcmVvKG1vZGUpKQo+ICAJCXJldHVybiBmYWxzZTsK PiArCS8qCj4gKwkgKiBJZiB1c2VyLXNwYWNlIGhhc24ndCBjb25maWd1cmVkIHRoZSBkcml2ZXIg dG8gZXhwb3NlIHRoZSBtb2Rlcwo+ICsJICogd2l0aCBhc3BlY3QtcmF0aW8sIGRvbid0IGV4cG9z ZSB0aGVtLiBCdXQgaW4gY2FzZSBvZiBhIHVuaXF1ZQo+ICsJICogbW9kZSwgbGV0IHRoZSBtb2Rl IGJlIHBhc3NlZCwgc28gdGhhdCBpdCBjYW4gYmUgZW51bWVyYXRlZCB3aXRoCj4gKwkgKiBhc3Bl Y3QgcmF0aW8gYml0cyBlcmFzZWQuCgpNaWdodCB3YW50IHRvIG5vdGUgdGhhdCB3ZSBleHBlY3Qg dGhlIGxpc3QgdG8gYmUgc29ydGVkIHN1Y2ggdGhhdCBtb2Rlcwp0aGF0IGhhdmUgZGlmZmVyZW50 IGFzcGVjdCByYXRpbyBidXQgYXJlIG90aGVyd2lzZSBpZGVudGljYWwgYXJlIGJhY2sgdG8KYmFj ay4KCj4gKwkgKi8KPiArCWlmICghZmlsZV9wcml2LT5hc3BlY3RfcmF0aW9fYWxsb3dlZCAmJgo+ ICsJICAgIG1vZGUtPnBpY3R1cmVfYXNwZWN0X3JhdGlvICE9IEhETUlfUElDVFVSRV9BU1BFQ1Rf Tk9ORSkgewo+ICsJCWlmIChsYXN0X21vZGUgJiYgIWRybV9tb2RlX21hdGNoKG1vZGUsIGxhc3Rf bW9kZSwKPiArCQkJCQkJIERSTV9NT0RFX01BVENIX1RJTUlOR1MgfAo+ICsJCQkJCQkgRFJNX01P REVfTUFUQ0hfQ0xPQ0sgfAo+ICsJCQkJCQkgRFJNX01PREVfTUFUQ0hfRkxBR1MgfAo+ICsJCQkJ CQkgRFJNX01PREVfTUFUQ0hfM0RfRkxBR1MpKQo+ICsJCQlyZXR1cm4gdHJ1ZTsKPiArCQllbHNl Cj4gKwkJCXJldHVybiBmYWxzZTsKCkhvdyBkb2VzIHRoYXQgZXZlbiB3b3JrPyBJdCdsbCByZXR1 cm4gZmFsc2UgYXMgbG9uZyBhcwpsYXN0X21vZGU9PU5VTEwsIGFuZCBsYXN0X21vZGUgbmV2ZXIg YmVjb21lcyBub24tTlVMTCB1bmxlc3MKd2UgcmV0dXJuIHRydWUuCgpUbyBtZSBpdCBsb29rcyBs aWtlIHRoZSBjb3JyZWN0IGxvZ2ljIHdvdWxkIGJlOgppZiAobGFzdF9tb2RlICYmIGRybV9tb2Rl X21hdGNoKC4uLikpCglyZXR1cm4gZmFsc2U7Cgo+ICsJfQo+ICAKPiAgCXJldHVybiB0cnVlOwo+ ICB9Cj4gQEAgLTE1MjcsNiArMTU0Niw3IEBAIGludCBkcm1fbW9kZV9nZXRjb25uZWN0b3Ioc3Ry dWN0IGRybV9kZXZpY2UgKmRldiwgdm9pZCAqZGF0YSwKPiAgCXN0cnVjdCBkcm1fY29ubmVjdG9y ICpjb25uZWN0b3I7Cj4gIAlzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXI7Cj4gIAlzdHJ1Y3Qg ZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZTsKPiArCXN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICpsYXN0 X3ZhbGlkX21vZGU7Cj4gIAlpbnQgbW9kZV9jb3VudCA9IDA7Cj4gIAlpbnQgZW5jb2RlcnNfY291 bnQgPSAwOwo+ICAJaW50IHJldCA9IDA7Cj4gQEAgLTE1ODIsOSArMTYwMiwxMyBAQCBpbnQgZHJt X21vZGVfZ2V0Y29ubmVjdG9yKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4g IAlvdXRfcmVzcC0+Y29ubmVjdGlvbiA9IGNvbm5lY3Rvci0+c3RhdHVzOwo+ICAKPiAgCS8qIGRl bGF5ZWQgc28gd2UgZ2V0IG1vZGVzIHJlZ2FyZGxlc3Mgb2YgcHJlLWZpbGxfbW9kZXMgc3RhdGUg Ki8KPiArCWxhc3RfdmFsaWRfbW9kZSA9IE5VTEw7Cj4gIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KG1v ZGUsICZjb25uZWN0b3ItPm1vZGVzLCBoZWFkKQo+IC0JCWlmIChkcm1fbW9kZV9leHBvc2VfdG9f dXNlcnNwYWNlKG1vZGUsIGZpbGVfcHJpdikpCj4gKwkJaWYgKGRybV9tb2RlX2V4cG9zZV90b191 c2Vyc3BhY2UobGFzdF92YWxpZF9tb2RlLCBtb2RlLAo+ICsJCQkJCQkgZmlsZV9wcml2KSkgewo+ ICAJCQltb2RlX2NvdW50Kys7Cj4gKwkJCWxhc3RfdmFsaWRfbW9kZSA9IG1vZGU7Cj4gKwkJfQo+ ICAKPiAgCS8qCj4gIAkgKiBUaGlzIGlvY3RsIGlzIGNhbGxlZCB0d2ljZSwgb25jZSB0byBkZXRl cm1pbmUgaG93IG11Y2ggc3BhY2UgaXMKPiBAQCAtMTU5MywxMSArMTYxNywyMSBAQCBpbnQgZHJt X21vZGVfZ2V0Y29ubmVjdG9yKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4g IAlpZiAoKG91dF9yZXNwLT5jb3VudF9tb2RlcyA+PSBtb2RlX2NvdW50KSAmJiBtb2RlX2NvdW50 KSB7Cj4gIAkJY29waWVkID0gMDsKPiAgCQltb2RlX3B0ciA9IChzdHJ1Y3QgZHJtX21vZGVfbW9k ZWluZm8gX191c2VyICopKHVuc2lnbmVkIGxvbmcpb3V0X3Jlc3AtPm1vZGVzX3B0cjsKPiArCQls YXN0X3ZhbGlkX21vZGUgPSBOVUxMOwo+ICAJCWxpc3RfZm9yX2VhY2hfZW50cnkobW9kZSwgJmNv bm5lY3Rvci0+bW9kZXMsIGhlYWQpIHsKPiAtCQkJaWYgKCFkcm1fbW9kZV9leHBvc2VfdG9fdXNl cnNwYWNlKG1vZGUsIGZpbGVfcHJpdikpCj4gKwkJCWlmICghZHJtX21vZGVfZXhwb3NlX3RvX3Vz ZXJzcGFjZShsYXN0X3ZhbGlkX21vZGUsCj4gKwkJCQkJCQkgIG1vZGUsCj4gKwkJCQkJCQkgIGZp bGVfcHJpdikpCj4gIAkJCQljb250aW51ZTsKPiAtCj4gIAkJCWRybV9tb2RlX2NvbnZlcnRfdG9f dW1vZGUoJnVfbW9kZSwgbW9kZSk7Cj4gKwo+ICsJCQkvKgo+ICsJCQkgKiBSZXNldCB0aGUgYXNw ZWN0LXJhdGlvIGZsYWcgYml0cyBmcm9tIHRoZSB1c2VyIG1vZGUsCj4gKwkJCSAqIGlmIHRoZSB1 c2VyIG1vZGUgZG9lcyBoYXZlIGFzcGVjdCByYXRpbyBjYXBhYmlsaXR5Lgo+ICsJCQkgKi8KPiAr CQkJaWYgKCFmaWxlX3ByaXYtPmFzcGVjdF9yYXRpb19hbGxvd2VkKQo+ICsJCQkJdV9tb2RlLmZs YWdzICY9ICh+RFJNX01PREVfRkxBR19QSUNfQVJfTUFTSyk7CgpVc2VsZXNzIHBhcmVucy4gQ291 bGQgdXNlIHRoZSBzYW1lIGhlbHBlciBJIHN1Z2dlc3RlZCB3ZSBhZGQgZm9yCmdldGNydGMoKSBh bmQgZ2V0YmxvYigpLgoKPiArCj4gIAkJCWlmIChjb3B5X3RvX3VzZXIobW9kZV9wdHIgKyBjb3Bp ZWQsCj4gIAkJCQkJICZ1X21vZGUsIHNpemVvZih1X21vZGUpKSkgewo+ICAJCQkJcmV0ID0gLUVG QVVMVDsKPiBAQCAtMTYwNSw2ICsxNjM5LDcgQEAgaW50IGRybV9tb2RlX2dldGNvbm5lY3Rvcihz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAKPiAgCQkJCWdvdG8gb3V0Owo+ ICAJCQl9Cj4gKwkJCWxhc3RfdmFsaWRfbW9kZSA9IG1vZGU7Cj4gIAkJCWNvcGllZCsrOwo+ICAJ CX0KPiAgCX0KPiAtLSAKPiAyLjcuNAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==