From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3841677-1519419212-2-9018952587418143654 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='UTF-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1519419212; b=FfxaOxBgpVVa3jmuY442viE7pYUiHK07mqEyaFjZKqvJkgm 1V6kBsJNyMFedjXdA9JM/iajeZBCDEiTNzEZAA7XggVRVRDyswh8MjUb/PkBg2r5 5nJCa24+l+WPQ2UJE2jrQuxXEm2NNfaQf+cKU7fXOTDO70WTtVeOpjXODgpqAdFb oIQ6RvHzDGDh0tay8wqPJ2d/a8Nkf1S0iaz1I5yPueDAQycph/wsKAh7dsYfgUnf kTs6oeN2VwmCMO4111cP2GtzzspFaNvWNCNbrjF57mGoNM4oreQzMN5lS4xXk6H+ Mlh+bMCFpvK2NQHFg9glcMfXw/EuJV13VDXImtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-type:sender :list-id; s=arctest; t=1519419212; bh=J3N//njukERFpkVKHI8XZdrq6O ArENoXjltEhRNcZ7Q=; b=BbxSazmPAtGL4/Am7s0uMMf85Zt9ENkXyXb3+thagw 9SkExWUq2ARDZ9mY5anCx745isVamOCy3TnJSQjQgVzJdESNQ+nfByO4cKCNApnq CktI9DAw6XtAFtjbSKwHTTgPjGck68AAZ/A0/UIP182p7zltf+ztyu5LfcjbwzW3 HPF3mAY6f1q7HY3Y/1knj6mdRz6bcsTyD6Qf2tIHUMM4hbT7pwJlDT9Vj3cuJD7a lmxffkw2Ev2FqEKMtxVTWHrhRJUczmsXQqPy9gx2Ptzg5Ruef7lEgoIMc6t6uYzG 7Tn+gWEwXiZmcMzQ3a0QYDS9DfbhSFzFYXKgzg1aQ8Ew== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbeBWSac (ORCPT ); Fri, 23 Feb 2018 13:30:32 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34550 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752264AbeBWSab (ORCPT ); Fri, 23 Feb 2018 13:30:31 -0500 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot , Paul Moore , Stephen Smalley , James Morris Subject: [PATCH 3.18 20/58] selinux: skip bounded transition processing if the policy isnt loaded Date: Fri, 23 Feb 2018 19:26:19 +0100 Message-Id: <20180223170210.033074604@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180223170206.724655284@linuxfoundation.org> References: <20180223170206.724655284@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Paul Moore commit 4b14752ec4e0d87126e636384cf37c8dd9df157c upstream. We can't do anything reasonable in security_bounded_transition() if we don't have a policy loaded, and in fact we could run into problems with some of the code inside expecting a policy. Fix these problems like we do many others in security/selinux/ss/services.c by checking to see if the policy is loaded (ss_initialized) and returning quickly if it isn't. Reported-by: syzbot Signed-off-by: Paul Moore Acked-by: Stephen Smalley Reviewed-by: James Morris Signed-off-by: Greg Kroah-Hartman --- security/selinux/ss/services.c | 3 +++ 1 file changed, 3 insertions(+) --- a/security/selinux/ss/services.c +++ b/security/selinux/ss/services.c @@ -823,6 +823,9 @@ int security_bounded_transition(u32 old_ int index; int rc; + if (!ss_initialized) + return 0; + read_lock(&policy_rwlock); rc = -EINVAL;