From: Andi Kleen <ak@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Jin Yao <yao.jin@linux.intel.com>,
jolsa@kernel.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf annotate: Support to display the LBR data in tui mode
Date: Fri, 23 Feb 2018 09:02:10 -0800 [thread overview]
Message-ID: <20180223170210.GC7045@tassilo.jf.intel.com> (raw)
In-Reply-To: <20180223152906.GA8805@kernel.org>
On Fri, Feb 23, 2018 at 12:29:06PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Feb 23, 2018 at 09:25:00AM +0100, Peter Zijlstra escreveu:
> > On Fri, Feb 23, 2018 at 10:35:58PM +0800, Jin Yao wrote:
> > > Unlike the perf report interactive annotate mode, the perf annotate
> > > doesn't display the LBR data.
>
> > > perf record -b ...
> > > perf annotate function
>
> > > It should show IPC/cycle, but it doesn't.
>
> > There is far more than IPC/cycle for the LBR data, so this Changelog is
> > misleading.
>
> > Also, I think that this patch goes the wrong way, we should reduce the
> > divergence of the various modes, not make it worse.
>
> Right, Peter, what would you think if I made --stdio use the same
> routines used to format the TUI, i.e. stdio would be equal to the TUI
> modulo de navigation/jump arrows, etc.
With the unification Jin Yao's patch would be the right thing anyways
-- it would magically work for stdio mode too. So it seems to me
merging the patch would be the right thing to do.
-Andi
next prev parent reply other threads:[~2018-02-23 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-23 14:35 [PATCH] perf annotate: Support to display the LBR data in tui mode Jin Yao
2018-02-23 8:25 ` Peter Zijlstra
2018-02-23 9:08 ` Jin, Yao
2018-02-23 15:29 ` Arnaldo Carvalho de Melo
2018-02-23 16:59 ` Peter Zijlstra
2018-02-23 17:02 ` Andi Kleen [this message]
2018-02-27 9:38 ` [PATCH v2] perf annotate: Support to display the IPC/Cycle " Jin Yao
2018-03-08 5:22 ` Jin, Yao
2018-03-08 13:12 ` Arnaldo Carvalho de Melo
2018-03-09 8:57 ` [tip:perf/core] perf annotate: Support to display the IPC/Cycle in TUI mode tip-bot for Jin Yao
2018-02-24 1:40 ` [PATCH] perf annotate: Support to display the LBR data in tui mode Jin, Yao
2018-02-26 13:57 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180223170210.GC7045@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.