From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7C16421F6A6D7 for ; Fri, 23 Feb 2018 12:37:16 -0800 (PST) Date: Fri, 23 Feb 2018 13:43:17 -0700 From: Ross Zwisler Subject: Re: [ndctl PATCH] ndctl, firmware-update: kill usage of flock() in verify_fw_file() Message-ID: <20180223204317.GA7750@linux.intel.com> References: <151936916717.18166.15323371299792291219.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <151936916717.18166.15323371299792291219.stgit@dwillia2-desk3.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: linux-nvdimm@lists.01.org List-ID: On Thu, Feb 22, 2018 at 10:59:27PM -0800, Dan Williams wrote: > It serves no purpose, we never explicitly unlock it, and it causes > needless failures if the firmware file happens to be on a filesystem > that does not support file locks. > > Cc: Dave Jiang > Signed-off-by: Dan Williams Yay, I was hitting this as well in my setup which uses NFS, but wasn't sure if the flock was necessary. Reviewed-by: Ross Zwisler _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm