All of lore.kernel.org
 help / color / mirror / Atom feed
From: me@tobin.cc (Tobin C. Harding)
To: kernelnewbies@lists.kernelnewbies.org
Subject: I'd like to contribute but I don't know how...
Date: Sat, 24 Feb 2018 10:11:43 +1100	[thread overview]
Message-ID: <20180223231143.GA6364@eros> (raw)
In-Reply-To: <BN3PR0101MB1012F4898A3E41B443CCF0E9CDCD0@BN3PR0101MB1012.prod.exchangelabs.com>

On Thu, Feb 22, 2018 at 09:25:39PM +0000, Alex Arvelaez wrote:
> On Thu, Feb 22, 2018 at 04:12:14AM +0000, Alex Arvelaez wrote:
> > On Wed, Feb 21, 2018 at 10:20:07PM -0500, valdis.kletnieks at vt.edu wrote:
> > > On Thu, 22 Feb 2018 02:33:08 +0000, Alex Arvelaez said:
> > > > Hello,
> > > >
> > > > I'd like to contribute to the linux kernel eventually but I'm not sure
> > > 
> > > https://lists.kernelnewbies.org/pipermail/kernelnewbies/2017-April/017765.html
> > > 
> > > > how, I grabbed a copy of the source code and I found a FIXME that looks
> > > > like I could fix:
> > > >
> > > > /* File: /usr/src/linux/tools/perf/util/string.c
> > > >  * FIXME: replace this with an expression using log10() when we
> > > >  * find a suitable implementation, maybe the one in the dvb drivers...
> > > >  */
> > > 
> > > Step 0:  Verify that the comment still matches the code, *and* that the change
> > > is still desired.  Hint:  Why do they want log10()? What does the current code
> > > do? What, if anything, will break if you change it?
> > 
> 
> I went ahead and used log10() from -lm, everything seems to work
> properly from what I can see. I made a patch with my changes should
> I send that to the linux-kernel mailing list for feedback?

Documentation/process/ is your friend.


	Tobin

      reply	other threads:[~2018-02-23 23:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22  2:33 I'd like to contribute but I don't know how Alex Arvelaez
2018-02-22  3:20 ` valdis.kletnieks at vt.edu
2018-02-22  3:46   ` Jeffrey Walton
2018-02-22  4:12   ` Alex Arvelaez
2018-02-22 21:25     ` Alex Arvelaez
2018-02-23 23:11       ` Tobin C. Harding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180223231143.GA6364@eros \
    --to=me@tobin.cc \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.