From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] fix double ;;s in code Date: Sat, 24 Feb 2018 16:56:27 +0800 Message-ID: <20180224085626.GN3217@dragon> References: <20180217211955.GE9640@amd> <20180222090932.GJ3217@dragon> <20180224085227.GA12996@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20180224085227.GA12996@amd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Pavel Machek Cc: daniel.lezcano@linaro.org, narmstrong@baylibre.com, airlied@linux.ie, Alexey.Brodkin@synopsys.com, will.deacon@arm.com, fbarrat@linux.vnet.ibm.com, kernel list , paulus@ozlabs.org, yamada.masahiro@socionext.com, mhocko@suse.com, viresh.kumar@linaro.org, hpa@zytor.com, JinHuiEric.Huang@amd.com, iommu@lists.linux-foundation.org, elfring@users.sourceforge.net, scott.bauer@intel.com, linux-arm-kernel@lists.infradead.org, mpe@ellerman.id.au, x86@kernel.org, Wenjing.Liu@amd.com, linux@armlinux.org.uk, amd-gfx@lists.freedesktop.org, Ding.Wang@amd.com, aik@ozlabs.ru, wens@csie.org, mingo@redhat.com, vbabka@suse.cz, catalin.marinas@arm.com, airlied@redhat.com, ruscur@russell.cc, shli@kernel.org, dan.carpenter@oracle.com, andresx7@gmail.com, linux-arm-msm@vger.kernel.org, linux-efi@vger.kernel.org, alistair@popple.id.au, linuxppc-dev@lists.ozlabs.org List-Id: amd-gfx.lists.freedesktop.org T24gU2F0LCBGZWIgMjQsIDIwMTggYXQgMDk6NTI6MjdBTSArMDEwMCwgUGF2ZWwgTWFjaGVrIHdy b3RlOgo+IEhpIQo+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2MvaW14L2dwYy5jIGIv ZHJpdmVycy9zb2MvaW14L2dwYy5jCj4gPiA+IGluZGV4IDUzZjcyNzUuLmNmYjQyZjUgMTAwNjQ0 Cj4gPiA+IC0tLSBhL2RyaXZlcnMvc29jL2lteC9ncGMuYwo+ID4gPiArKysgYi9kcml2ZXJzL3Nv Yy9pbXgvZ3BjLmMKPiA+ID4gQEAgLTM0OCw3ICszNDgsNyBAQCBzdGF0aWMgaW50IGlteF9ncGNf b2xkX2R0X2luaXQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgcmVnbWFwICpyZWdtYXAsCj4g PiA+ICAJCWlmIChpID09IDEpIHsKPiA+ID4gIAkJCWRvbWFpbi0+c3VwcGx5ID0gZGV2bV9yZWd1 bGF0b3JfZ2V0KGRldiwgInB1Iik7Cj4gPiA+ICAJCQlpZiAoSVNfRVJSKGRvbWFpbi0+c3VwcGx5 KSkKPiA+ID4gLQkJCQlyZXR1cm4gUFRSX0VSUihkb21haW4tPnN1cHBseSk7Owo+ID4gPiArCQkJ CXJldHVybiBQVFJfRVJSKGRvbWFpbi0+c3VwcGx5KTsKPiA+ID4gIAo+ID4gPiAgCQkJcmV0ID0g aW14X3BnY19nZXRfY2xvY2tzKGRldiwgZG9tYWluKTsKPiA+ID4gIAkJCWlmIChyZXQpCj4gPiA+ IAo+ID4gCj4gPiBDb25zaWRlcmluZyB0aGUgY29udHJvdmVyc3kgaG93IHRoZSBjaGFuZ2VzIHNo b3VsZCBiZSBtZXJnZWQsIEknbSBnb2luZwo+ID4gdG8gc2VuZCBhIHNlcGFyYXRlIHBhdGNoIGp1 c3QgZm9yIElNWCBHUEMgZHJpdmVyIHdpdGggYSByZXBvcnRlZC1ieS15b3UKPiA+IHRhZy4gIFRo YW5rcyBmb3IgY2F0Y2hpbmcgdGhpcy4KPiAKPiBUaGF0IHdvcmtzIGZvciBtZS4KPiAKPiBBbHRl cm5hdGl2ZWx5Li4uIEFuZHJldyBNb3J0b24gbWVyZ2VkIHRoZSBwYXRjaCB0byBoaXMgLW1tIHRy ZWUKPiAodGhhbmtzISksIHNvIHlvdSBkb24ndCBuZWVkIHRvIHRha2UgYW55IGFjdGlvbiwgYW5k IGl0IHdpbGwgYmUKPiBldmVudHVhbGx5IGZpeGVkLgoKT2theSwgSSdtIGRyb3BwaW5nIG15IHBh dGNoIGZyb20gSU1YIHRyZWUuCgpTaGF3bgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 24 Feb 2018 16:56:27 +0800 From: Shawn Guo To: Pavel Machek Cc: elfring@users.sourceforge.net, kernel list , vgupta@synopsys.com, linux@armlinux.org.uk, oleg@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, paulus@ozlabs.org, benh@kernel.crashing.org, mpe@ellerman.id.au, ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, scott.bauer@intel.com, jonathan.derrick@intel.com, axboe@kernel.dk, daniel.lezcano@linaro.org, maxime.ripard@free-electrons.com, wens@csie.org, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, airlied@linux.ie, robdclark@gmail.com, joro@8bytes.org, shli@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, akpm@linux-foundation.org, Alexey.Brodkin@synopsys.com, mhocko@suse.com, vbabka@suse.cz, Vladislav.Zakharov@synopsys.com, noamca@mellanox.com, yamada.masahiro@socionext.com, sboyd@codeaurora.org, viresh.kumar@linaro.org, linus.walleij@linaro.org, heiko@sntech.de, aik@ozlabs.ru, ruscur@russell.cc, david@gibson.dropbear.id.au, fbarrat@linux.vnet.ibm.com, alistair@popple.id.au, robh@kernel.org, joe@perches.com, harry.wentland@amd.com, tony.cheng@amd.com, Wenjing.Liu@amd.com, airlied@redhat.com, Ding.Wang@amd.com, sylvia.tsai@amd.com, hersenxs.wu@amd.com, Rex.Zhu@amd.com, JinHuiEric.Huang@amd.com, dan.carpenter@oracle.com, architt@codeaurora.org, daniel.vetter@ffwll.ch, narmstrong@baylibre.com, ville.syrjala@linux.intel.com, jcrouse@codeaurora.org, aishpant@gmail.com, noralf@tronnes.org, andresx7@gmail.com, Monk.Liu@amd.com, nicolai.haehnle@amd.com, Andrey.Grodzovsky@amd.com, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-efi@vger.kernel.org, linux-block@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-raid@vger.kernel.org Subject: Re: [PATCH] fix double ;;s in code Message-ID: <20180224085626.GN3217@dragon> References: <20180217211955.GE9640@amd> <20180222090932.GJ3217@dragon> <20180224085227.GA12996@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20180224085227.GA12996@amd> List-ID: On Sat, Feb 24, 2018 at 09:52:27AM +0100, Pavel Machek wrote: > Hi! > > > > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > > > index 53f7275..cfb42f5 100644 > > > --- a/drivers/soc/imx/gpc.c > > > +++ b/drivers/soc/imx/gpc.c > > > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, > > > if (i == 1) { > > > domain->supply = devm_regulator_get(dev, "pu"); > > > if (IS_ERR(domain->supply)) > > > - return PTR_ERR(domain->supply);; > > > + return PTR_ERR(domain->supply); > > > > > > ret = imx_pgc_get_clocks(dev, domain); > > > if (ret) > > > > > > > Considering the controversy how the changes should be merged, I'm going > > to send a separate patch just for IMX GPC driver with a reported-by-you > > tag. Thanks for catching this. > > That works for me. > > Alternatively... Andrew Morton merged the patch to his -mm tree > (thanks!), so you don't need to take any action, and it will be > eventually fixed. Okay, I'm dropping my patch from IMX tree. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Sat, 24 Feb 2018 16:56:27 +0800 Subject: [PATCH] fix double ;;s in code In-Reply-To: <20180224085227.GA12996@amd> References: <20180217211955.GE9640@amd> <20180222090932.GJ3217@dragon> <20180224085227.GA12996@amd> List-ID: Message-ID: <20180224085626.GN3217@dragon> To: linux-snps-arc@lists.infradead.org On Sat, Feb 24, 2018@09:52:27AM +0100, Pavel Machek wrote: > Hi! > > > > diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c > > > index 53f7275..cfb42f5 100644 > > > --- a/drivers/soc/imx/gpc.c > > > +++ b/drivers/soc/imx/gpc.c > > > @@ -348,7 +348,7 @@ static int imx_gpc_old_dt_init(struct device *dev, struct regmap *regmap, > > > if (i == 1) { > > > domain->supply = devm_regulator_get(dev, "pu"); > > > if (IS_ERR(domain->supply)) > > > - return PTR_ERR(domain->supply);; > > > + return PTR_ERR(domain->supply); > > > > > > ret = imx_pgc_get_clocks(dev, domain); > > > if (ret) > > > > > > > Considering the controversy how the changes should be merged, I'm going > > to send a separate patch just for IMX GPC driver with a reported-by-you > > tag. Thanks for catching this. > > That works for me. > > Alternatively... Andrew Morton merged the patch to his -mm tree > (thanks!), so you don't need to take any action, and it will be > eventually fixed. Okay, I'm dropping my patch from IMX tree. Shawn