All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH v1] iio: accel: bmc150: Remove redundant __func__ in dev_dbg()
Date: Sat, 24 Feb 2018 13:30:09 +0000	[thread overview]
Message-ID: <20180224133009.2f0c61df@archlinux> (raw)
In-Reply-To: <20180222185858.28714-1-andriy.shevchenko@linux.intel.com>

On Thu, 22 Feb 2018 20:58:58 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> Dynamic debug has a run time knob to enable function name printing.
> Remove this from dev_dbg() calls.
> 
> Furthermore, functional tracing when enabled can show what function is
> called, therefore remove empty dev_dbg() calls.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/iio/accel/bmc150-accel-core.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/iio/accel/bmc150-accel-core.c b/drivers/iio/accel/bmc150-accel-core.c
> index 870f92ef61c2..208f2d9f0e8a 100644
> --- a/drivers/iio/accel/bmc150-accel-core.c
> +++ b/drivers/iio/accel/bmc150-accel-core.c
> @@ -336,8 +336,7 @@ static int bmc150_accel_update_slope(struct bmc150_accel_data *data)
>  		return ret;
>  	}
>  
> -	dev_dbg(dev, "%s: %x %x\n", __func__, data->slope_thres,
> -		data->slope_dur);
> +	dev_dbg(dev, "%x %x\n", data->slope_thres, data->slope_dur);
>  
>  	return ret;
>  }
> @@ -1716,7 +1715,6 @@ static int bmc150_accel_runtime_suspend(struct device *dev)
>  	struct bmc150_accel_data *data = iio_priv(indio_dev);
>  	int ret;
>  
> -	dev_dbg(dev,  __func__);
>  	ret = bmc150_accel_set_mode(data, BMC150_ACCEL_SLEEP_MODE_SUSPEND, 0);
>  	if (ret < 0)
>  		return -EAGAIN;
> @@ -1731,8 +1729,6 @@ static int bmc150_accel_runtime_resume(struct device *dev)
>  	int ret;
>  	int sleep_val;
>  
> -	dev_dbg(dev,  __func__);
> -
>  	ret = bmc150_accel_set_mode(data, BMC150_ACCEL_SLEEP_MODE_NORMAL, 0);
>  	if (ret < 0)
>  		return ret;


      reply	other threads:[~2018-02-24 13:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-22 18:58 [PATCH v1] iio: accel: bmc150: Remove redundant __func__ in dev_dbg() Andy Shevchenko
2018-02-24 13:30 ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180224133009.2f0c61df@archlinux \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.