From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from vps0.lunn.ch ([185.16.172.187]:36423 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751689AbeBYQi5 (ORCPT ); Sun, 25 Feb 2018 11:38:57 -0500 Date: Sun, 25 Feb 2018 17:38:55 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Russell King , "netdev@vger.kernel.org" Subject: Re: Potential issue with f5e64032a799 "net: phy: fix resume handling" Message-ID: <20180225163855.GC17626@lunn.ch> References: <4886212b-0274-ffa0-f98e-da2e43a3b042@gmail.com> <20180203201748.GN16818@lunn.ch> <80586c54-2a59-04ef-a623-78d340ba6206@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80586c54-2a59-04ef-a623-78d340ba6206@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Feb 25, 2018 at 02:00:43PM +0100, Heiner Kallweit wrote: > Am 03.02.2018 um 21:17 schrieb Andrew Lunn: > > On Sat, Feb 03, 2018 at 05:41:54PM +0100, Heiner Kallweit wrote: > >> This commit forces callers of phy_resume() and phy_suspend() to hold > >> mutex phydev->lock. This was done for calls to phy_resume() and > >> phy_suspend() in phylib, however there are more callers in network > >> drivers. I'd assume that these other calls issue a warning now > >> because of the lock not being held. > >> So is there something I miss or would this have to be fixed? > > > > Hi Heiner > > > > This is a good point. > > > > Yes, it looks like some fixes are needed. But what exactly? > > > The issue with phy_suspend/phy_resume and the changed locking > behavior is still open AFAICS. There was a proposed fix > https://www.mail-archive.com/netdev@vger.kernel.org/msg215455.html > and then the discussion stopped. > I think we need the fix before 4.16 leaves the rc phase. Hi Heiner I have a patch i will post later today. Andrew