All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO
Date: Sun, 25 Feb 2018 20:08:30 +0100	[thread overview]
Message-ID: <20180225190830.GA19487@lunn.ch> (raw)
In-Reply-To: <20180225125132.25275-1-linus.walleij@linaro.org>

On Sun, Feb 25, 2018 at 01:51:27PM +0100, Linus Walleij wrote:
> This kills off the platform data support from the bitbanged
> GPIO-based MDIO driver and moves it over to using GPIO
> descriptors exclusively.

Hi Linus

I like where this ends up. I wounder about the path it takes to get
there. There seems to be quite a lot of code which gets moved around
and then in the end deleted. Maybe changing the order of the patches
would help. Converting to devm_gpiod_get_index() first would remove
all the active_low flags. Then remove all the unused reset callback,
irq, etc?

     Thanks
	Andrew

  parent reply	other threads:[~2018-02-25 19:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-25 12:51 [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 1/5] net: mdio-gpio: Localize platform data Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 2/5] net: mdio-gpio: Allocate state in probe() Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 3/5] net: mdio-gpio: Remove non-DT probe path Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 4/5] net: mdio-gpio: Merge platform data into state Linus Walleij
2018-02-25 12:51 ` [PATCH net-next 5/5] net: mdio-gpio: Move to gpiod API Linus Walleij
2018-02-25 19:08 ` Andrew Lunn [this message]
2018-02-27  8:53   ` [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO Linus Walleij
2018-02-27 14:00 ` Florian Fainelli
2018-02-27 23:10   ` Andrew Lunn
2018-02-27 23:46     ` Florian Fainelli
2018-03-02  9:44   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180225190830.GA19487@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.