All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Santha Meena Ramamoorthy <santhameena13@gmail.com>,
	oleg.drokin@intel.com, andreas.dilger@intel.com,
	jsimmons@infradead.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] staging: lustre: remove else after return statement
Date: Mon, 26 Feb 2018 15:43:05 +0100	[thread overview]
Message-ID: <20180226144305.GA23979@kroah.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1802250929320.2531@hadrien>

On Sun, Feb 25, 2018 at 09:30:40AM +0100, Julia Lawall wrote:
> 
> 
> On Sat, 24 Feb 2018, Santha Meena Ramamoorthy wrote:
> 
> > Remove else after a return statement as it is not useful. Issue found
> > using checkpatch.
> 
> I have the impression that the else branch is there to be parallel to the
> then branch, and then the return is pushed into the branch because an else
> branch with just a comment would look silly.

Exactly, I'd recommend to just leave this code as-is for now.

thanks,

greg k-h


      reply	other threads:[~2018-02-26 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24 23:07 [PATCH] staging: lustre: remove else after return statement Santha Meena Ramamoorthy
2018-02-25  8:30 ` [Outreachy kernel] " Julia Lawall
2018-02-26 14:43   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180226144305.GA23979@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=jsimmons@infradead.org \
    --cc=julia.lawall@lip6.fr \
    --cc=oleg.drokin@intel.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=santhameena13@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.