From: Andrew Lunn <andrew@lunn.ch>
To: Bryan.Whitehead@microchip.com
Cc: f.fainelli@gmail.com, davem@davemloft.net,
UNGLinuxDriver@microchip.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver
Date: Mon, 26 Feb 2018 18:25:22 +0100 [thread overview]
Message-ID: <20180226172522.GH3775@lunn.ch> (raw)
In-Reply-To: <90A7E81AE28BAE4CBDDB3B35F187D2644071E1A9@CHN-SV-EXMX02.mchp-main.com>
> But the other case is when things fail anywhere during probe, or
> open. In these cases things are partially initialized and I assumed
> I needed to clean up whatever was initialized successfully before
> returning an error. I used flags so I could share a common clean up
> function for all possible error cases as well as the fully
> successful case. Without flags I would need to customize a clean-up
> sequence for each possible error point.
Hi Bryan
It is good to look at other drivers and see how they work. Ideally,
your driver wants to look similar to all other drivers, so making the
maintenance easier.
You will find that most drivers have a set of goto statements for
error handling, which jump to the end of the function, and do cleanup.
No flags are maintained.
Andrew
next prev parent reply other threads:[~2018-02-26 17:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 19:06 [PATCH v2 net-next 0/2] lan743x: Add new lan743x driver Bryan Whitehead
2018-02-21 19:06 ` [PATCH v2 net-next 1/2] lan743x: Add main source files for " Bryan Whitehead
2018-02-22 2:55 ` Andrew Lunn
2018-02-22 21:31 ` Bryan.Whitehead
2018-02-22 21:43 ` Florian Fainelli
2018-02-22 21:45 ` Andrew Lunn
2018-02-22 21:47 ` Andrew Lunn
2018-02-22 22:10 ` Bryan.Whitehead
2018-02-22 18:02 ` [RFC PATCH] lan743x: lan743x_csr_read() can be static kbuild test robot
2018-02-22 18:02 ` [PATCH v2 net-next 1/2] lan743x: Add main source files for new lan743x driver kbuild test robot
2018-02-22 22:08 ` Florian Fainelli
2018-02-23 22:44 ` Bryan.Whitehead
2018-02-24 2:06 ` Andrew Lunn
2018-02-26 5:41 ` Bryan.Whitehead
2018-02-26 17:25 ` Andrew Lunn [this message]
2018-02-26 17:35 ` Bryan.Whitehead
2018-02-21 19:06 ` [PATCH v2 net-next 2/2] lan743x: Update MAINTAINERS to include " Bryan Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226172522.GH3775@lunn.ch \
--to=andrew@lunn.ch \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.