From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Liu Subject: Re: [PATCH] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers Date: Mon, 26 Feb 2018 11:38:33 -0600 Message-ID: <20180226173833.GC20609@uda0271908> References: <20180226105609.22514-1-merlijn@wizzup.org> <20180226155716.GB20609@uda0271908> <73a1de6d-6bf4-275f-aee3-85699cd6ca76@wizzup.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <73a1de6d-6bf4-275f-aee3-85699cd6ca76@wizzup.org> Sender: linux-kernel-owner@vger.kernel.org To: Merlijn Wajer Cc: linux-omap@vger.kernel.org, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Mon, Feb 26, 2018 at 06:19:30PM +0100, Merlijn Wajer wrote: > Hi, > > On 26/02/18 16:57, Bin Liu wrote: > > Hi, > > > > On Mon, Feb 26, 2018 at 11:56:08AM +0100, Merlijn Wajer wrote: > >> Without pm_runtime_{get,put}_sync calls in place, reading > >> vbus status via /sys causes the following error: > >> > >> Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 > >> pgd = b333e822 > >> [fa0ab060] *pgd=48011452(bad) > >> > >> [] (musb_default_readb) from [] (musb_vbus_show+0x58/0xe4) > >> [] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44) > >> [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x80/0xdc) > >> [] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448) > >> [] (seq_read) from [] (__vfs_read+0x1c/0x118) > >> [] (__vfs_read) from [] (vfs_read+0x90/0x144) > >> [] (vfs_read) from [] (SyS_read+0x3c/0x74) > >> [] (SyS_read) from [] (ret_fast_syscall+0x0/0x54) > >> > >> Solution was suggested by Tony Lindgren . > >> > >> Signed-off-by: Merlijn Wajer > >> --- > >> drivers/usb/musb/musb_core.c | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > >> index eef4ad578b31..ceaa40ef0e73 100644 > >> --- a/drivers/usb/musb/musb_core.c > >> +++ b/drivers/usb/musb/musb_core.c > >> @@ -1760,6 +1760,8 @@ vbus_show(struct device *dev, struct device_attribute *attr, char *buf) > >> val = musb->a_wait_bcon; > >> vbus = musb_platform_get_vbus_status(musb); > >> if (vbus < 0) { > >> + pm_runtime_get_sync(dev); > >> + > >> /* Use default MUSB method by means of DEVCTL register */ > >> devctl = musb_readb(musb->mregs, MUSB_DEVCTL); > >> if ((devctl & MUSB_DEVCTL_VBUS) > >> @@ -1767,6 +1769,8 @@ vbus_show(struct device *dev, struct device_attribute *attr, char *buf) > >> vbus = 1; > >> else > >> vbus = 0; > >> + > >> + pm_runtime_put_sync(dev); > >> } > >> spin_unlock_irqrestore(&musb->lock, flags); > > > > Thanks for the patch, but I got spinlock deadlock when testing it. I > > think the function pair should be at the outside scope of the > > spin_lock/unlock, doesn't it? > > I see - sorry. Weird, it worked for me on my Nokia N900. What did you > test this on? > > I will try to submit an improved version tonight (you seem to have a > good idea on what is wrong, so I will follow that), but it would help me > if I can reproduce the issue. I tested on both Beaglebone Black and AM335x GP EVM, on the USB1 host port. I didn't test the USB0 port (yet). Thanks, -Bin. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers From: Bin Liu Message-Id: <20180226173833.GC20609@uda0271908> Date: Mon, 26 Feb 2018 11:38:33 -0600 To: Merlijn Wajer Cc: linux-omap@vger.kernel.org, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gTW9uLCBGZWIgMjYsIDIwMTggYXQgMDY6MTk6MzBQTSArMDEwMCwgTWVybGlqbiBXYWplciB3 cm90ZToKPiBIaSwKPiAKPiBPbiAyNi8wMi8xOCAxNjo1NywgQmluIExpdSB3cm90ZToKPiA+IEhp LAo+ID4gCj4gPiBPbiBNb24sIEZlYiAyNiwgMjAxOCBhdCAxMTo1NjowOEFNICswMTAwLCBNZXJs aWpuIFdhamVyIHdyb3RlOgo+ID4+IFdpdGhvdXQgcG1fcnVudGltZV97Z2V0LHB1dH1fc3luYyBj YWxscyBpbiBwbGFjZSwgcmVhZGluZwo+ID4+IHZidXMgc3RhdHVzIHZpYSAvc3lzIGNhdXNlcyB0 aGUgZm9sbG93aW5nIGVycm9yOgo+ID4+Cj4gPj4gVW5oYW5kbGVkIGZhdWx0OiBleHRlcm5hbCBh Ym9ydCBvbiBub24tbGluZWZldGNoICgweDEwMjgpIGF0IDB4ZmEwYWIwNjAKPiA+PiBwZ2QgPSBi MzMzZTgyMgo+ID4+IFtmYTBhYjA2MF0gKnBnZD00ODAxMTQ1MihiYWQpCj4gPj4KPiA+PiBbPGMw NTI2MWIwPl0gKG11c2JfZGVmYXVsdF9yZWFkYikgZnJvbSBbPGMwNTI1YmQwPl0gKG11c2JfdmJ1 c19zaG93KzB4NTgvMHhlNCkKPiA+PiBbPGMwNTI1YmQwPl0gKG11c2JfdmJ1c19zaG93KSBmcm9t IFs8YzA0YzAxNDg+XSAoZGV2X2F0dHJfc2hvdysweDIwLzB4NDQpCj4gPj4gWzxjMDRjMDE0OD5d IChkZXZfYXR0cl9zaG93KSBmcm9tIFs8YzAyNTlmNzQ+XSAoc3lzZnNfa2Zfc2VxX3Nob3crMHg4 MC8weGRjKQo+ID4+IFs8YzAyNTlmNzQ+XSAoc3lzZnNfa2Zfc2VxX3Nob3cpIGZyb20gWzxjMDIx MGJhYz5dIChzZXFfcmVhZCsweDI1MC8weDQ0OCkKPiA+PiBbPGMwMjEwYmFjPl0gKHNlcV9yZWFk KSBmcm9tIFs8YzAxZWRiNDA+XSAoX192ZnNfcmVhZCsweDFjLzB4MTE4KQo+ID4+IFs8YzAxZWRi NDA+XSAoX192ZnNfcmVhZCkgZnJvbSBbPGMwMWVkY2NjPl0gKHZmc19yZWFkKzB4OTAvMHgxNDQp Cj4gPj4gWzxjMDFlZGNjYz5dICh2ZnNfcmVhZCkgZnJvbSBbPGMwMWVlMWQwPl0gKFN5U19yZWFk KzB4M2MvMHg3NCkKPiA+PiBbPGMwMWVlMWQwPl0gKFN5U19yZWFkKSBmcm9tIFs8YzAxMDZmZTA+ XSAocmV0X2Zhc3Rfc3lzY2FsbCsweDAvMHg1NCkKPiA+Pgo+ID4+IFNvbHV0aW9uIHdhcyBzdWdn ZXN0ZWQgYnkgVG9ueSBMaW5kZ3JlbiA8dG9ueUBhdG9taWRlLmNvbT4uCj4gPj4KPiA+PiBTaWdu ZWQtb2ZmLWJ5OiBNZXJsaWpuIFdhamVyIDxtZXJsaWpuQHdpenp1cC5vcmc+Cj4gPj4gLS0tCj4g Pj4gIGRyaXZlcnMvdXNiL211c2IvbXVzYl9jb3JlLmMgfCA0ICsrKysKPiA+PiAgMSBmaWxlIGNo YW5nZWQsIDQgaW5zZXJ0aW9ucygrKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdXNi L211c2IvbXVzYl9jb3JlLmMgYi9kcml2ZXJzL3VzYi9tdXNiL211c2JfY29yZS5jCj4gPj4gaW5k ZXggZWVmNGFkNTc4YjMxLi5jZWFhNDBlZjBlNzMgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy91 c2IvbXVzYi9tdXNiX2NvcmUuYwo+ID4+ICsrKyBiL2RyaXZlcnMvdXNiL211c2IvbXVzYl9jb3Jl LmMKPiA+PiBAQCAtMTc2MCw2ICsxNzYwLDggQEAgdmJ1c19zaG93KHN0cnVjdCBkZXZpY2UgKmRl diwgc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmF0dHIsIGNoYXIgKmJ1ZikKPiA+PiAgCXZhbCA9 IG11c2ItPmFfd2FpdF9iY29uOwo+ID4+ICAJdmJ1cyA9IG11c2JfcGxhdGZvcm1fZ2V0X3ZidXNf c3RhdHVzKG11c2IpOwo+ID4+ICAJaWYgKHZidXMgPCAwKSB7Cj4gPj4gKwkJcG1fcnVudGltZV9n ZXRfc3luYyhkZXYpOwo+ID4+ICsKPiA+PiAgCQkvKiBVc2UgZGVmYXVsdCBNVVNCIG1ldGhvZCBi eSBtZWFucyBvZiBERVZDVEwgcmVnaXN0ZXIgKi8KPiA+PiAgCQlkZXZjdGwgPSBtdXNiX3JlYWRi KG11c2ItPm1yZWdzLCBNVVNCX0RFVkNUTCk7Cj4gPj4gIAkJaWYgKChkZXZjdGwgJiBNVVNCX0RF VkNUTF9WQlVTKQo+ID4+IEBAIC0xNzY3LDYgKzE3NjksOCBAQCB2YnVzX3Nob3coc3RydWN0IGRl dmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlX2F0dHJpYnV0ZSAqYXR0ciwgY2hhciAqYnVmKQo+ID4+ ICAJCQl2YnVzID0gMTsKPiA+PiAgCQllbHNlCj4gPj4gIAkJCXZidXMgPSAwOwo+ID4+ICsKPiA+ PiArCQlwbV9ydW50aW1lX3B1dF9zeW5jKGRldik7Cj4gPj4gIAl9Cj4gPj4gIAlzcGluX3VubG9j a19pcnFyZXN0b3JlKCZtdXNiLT5sb2NrLCBmbGFncyk7Cj4gPiAKPiA+IFRoYW5rcyBmb3IgdGhl IHBhdGNoLCBidXQgSSBnb3Qgc3BpbmxvY2sgZGVhZGxvY2sgd2hlbiB0ZXN0aW5nIGl0LiBJCj4g PiB0aGluayB0aGUgZnVuY3Rpb24gcGFpciBzaG91bGQgYmUgYXQgdGhlIG91dHNpZGUgc2NvcGUg b2YgdGhlCj4gPiBzcGluX2xvY2svdW5sb2NrLCBkb2Vzbid0IGl0Pwo+IAo+IEkgc2VlIC0gc29y cnkuIFdlaXJkLCBpdCB3b3JrZWQgZm9yIG1lIG9uIG15IE5va2lhIE45MDAuIFdoYXQgZGlkIHlv dQo+IHRlc3QgdGhpcyBvbj8KPiAKPiBJIHdpbGwgdHJ5IHRvIHN1Ym1pdCBhbiBpbXByb3ZlZCB2 ZXJzaW9uIHRvbmlnaHQgKHlvdSBzZWVtIHRvIGhhdmUgYQo+IGdvb2QgaWRlYSBvbiB3aGF0IGlz IHdyb25nLCBzbyBJIHdpbGwgZm9sbG93IHRoYXQpLCBidXQgaXQgd291bGQgaGVscCBtZQo+IGlm IEkgY2FuIHJlcHJvZHVjZSB0aGUgaXNzdWUuCgpJIHRlc3RlZCBvbiBib3RoIEJlYWdsZWJvbmUg QmxhY2sgYW5kIEFNMzM1eCBHUCBFVk0sIG9uIHRoZSBVU0IxIGhvc3QKcG9ydC4gSSBkaWRuJ3Qg dGVzdCB0aGUgVVNCMCBwb3J0ICh5ZXQpLgoKVGhhbmtzLAotQmluLgotLS0KVG8gdW5zdWJzY3Jp YmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIg aW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9y ZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5m by5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3421458-1519666738-2-17048073669616417832 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1519666738; b=briNpB8wZAGrcsvY2OQywuZp4vFgIlijshSHyt/+kBGsa06 Upm8uiTWFze+uFI56+PW+ZXglThEjQTVvC8UtuXS5xBOLiebxFWgAMk1AL2KmGI8 57FdvhhjKzH28Sr2bulCeHsWI5+qv+UhOLrbgROZqVpoOdQDRxd/vXlRQ3KlbHV3 sotfywU/GOQSTyBt2smRkLbxjfp3VO4ZlKj+g471OSSa5s+M1OhZNWm2Inl2vafe pSqmgYoJv0NchJS+r7SNWFYV9S/hovrjYDQh8vxmrwPW0imO7+PmIkb9ZEtDcp0k KunLO1DUWe+j1yMHolBWC4GJqAMYPxkEf3cT/fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1519666738; bh=Eu8RNDNdbRYngrmSuDtz5u+Pss TdOgGxGVF0bQpjSu4=; b=qYQK5zB4NgGqFxF3NLc+IomeWMyJLGqWtWPGiid4DA dwSRT+STMpkwQdjcPdVFW0YSsLptWzl4/D3OB4yImvHdUnnRF3Dtb/sE+GKmoTSS 5gXV9cBHlTdayacVhbIPK9l0sHV9gn+BsgCnny9sjwkQLjbjPfaNXqaZch1tHEKZ OnWKxzDqmW19s4rfAruPc8x+IZf0t17Bg8/1P+QsB9H213qP/ldZVVTD468YrG1d P5UCHZssDU+vC828/HK8RoBGWAmpKDqPb1kuiAdjUDVNX4ylYHU74mH+q/rAHPjh aBQv3hCprJxEXBI/vTAa81QrTeP+bSrdHSi1sLs5GZFw== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=ti.com header.i=@ti.com header.b=l81+t+c4 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=ti-com-17Q1; dmarc=fail (p=quarantine,has-list-id=yes,d=quarantine) header.from=ti.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=ti.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 1024-bit rsa key sha256) header.d=ti.com header.i=@ti.com header.b=l81+t+c4 x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=ti-com-17Q1; dmarc=fail (p=quarantine,has-list-id=yes,d=quarantine) header.from=ti.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=ti.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbeBZRik (ORCPT ); Mon, 26 Feb 2018 12:38:40 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:27491 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751676AbeBZRih (ORCPT ); Mon, 26 Feb 2018 12:38:37 -0500 Date: Mon, 26 Feb 2018 11:38:33 -0600 From: Bin Liu To: Merlijn Wajer CC: , , Greg Kroah-Hartman , , Subject: Re: [PATCH] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers Message-ID: <20180226173833.GC20609@uda0271908> Mail-Followup-To: Bin Liu , Merlijn Wajer , linux-omap@vger.kernel.org, tony@atomide.com, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180226105609.22514-1-merlijn@wizzup.org> <20180226155716.GB20609@uda0271908> <73a1de6d-6bf4-275f-aee3-85699cd6ca76@wizzup.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <73a1de6d-6bf4-275f-aee3-85699cd6ca76@wizzup.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Feb 26, 2018 at 06:19:30PM +0100, Merlijn Wajer wrote: > Hi, > > On 26/02/18 16:57, Bin Liu wrote: > > Hi, > > > > On Mon, Feb 26, 2018 at 11:56:08AM +0100, Merlijn Wajer wrote: > >> Without pm_runtime_{get,put}_sync calls in place, reading > >> vbus status via /sys causes the following error: > >> > >> Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 > >> pgd = b333e822 > >> [fa0ab060] *pgd=48011452(bad) > >> > >> [] (musb_default_readb) from [] (musb_vbus_show+0x58/0xe4) > >> [] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44) > >> [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x80/0xdc) > >> [] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448) > >> [] (seq_read) from [] (__vfs_read+0x1c/0x118) > >> [] (__vfs_read) from [] (vfs_read+0x90/0x144) > >> [] (vfs_read) from [] (SyS_read+0x3c/0x74) > >> [] (SyS_read) from [] (ret_fast_syscall+0x0/0x54) > >> > >> Solution was suggested by Tony Lindgren . > >> > >> Signed-off-by: Merlijn Wajer > >> --- > >> drivers/usb/musb/musb_core.c | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > >> index eef4ad578b31..ceaa40ef0e73 100644 > >> --- a/drivers/usb/musb/musb_core.c > >> +++ b/drivers/usb/musb/musb_core.c > >> @@ -1760,6 +1760,8 @@ vbus_show(struct device *dev, struct device_attribute *attr, char *buf) > >> val = musb->a_wait_bcon; > >> vbus = musb_platform_get_vbus_status(musb); > >> if (vbus < 0) { > >> + pm_runtime_get_sync(dev); > >> + > >> /* Use default MUSB method by means of DEVCTL register */ > >> devctl = musb_readb(musb->mregs, MUSB_DEVCTL); > >> if ((devctl & MUSB_DEVCTL_VBUS) > >> @@ -1767,6 +1769,8 @@ vbus_show(struct device *dev, struct device_attribute *attr, char *buf) > >> vbus = 1; > >> else > >> vbus = 0; > >> + > >> + pm_runtime_put_sync(dev); > >> } > >> spin_unlock_irqrestore(&musb->lock, flags); > > > > Thanks for the patch, but I got spinlock deadlock when testing it. I > > think the function pair should be at the outside scope of the > > spin_lock/unlock, doesn't it? > > I see - sorry. Weird, it worked for me on my Nokia N900. What did you > test this on? > > I will try to submit an improved version tonight (you seem to have a > good idea on what is wrong, so I will follow that), but it would help me > if I can reproduce the issue. I tested on both Beaglebone Black and AM335x GP EVM, on the USB1 host port. I didn't test the USB0 port (yet). Thanks, -Bin.