From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v1,1/1] drivers/usb/storage: NULL pointer dereference [null-pointer-deref] (CWE 476) problem From: Greg Kroah-Hartman Message-Id: <20180226181200.GA29227@kroah.com> Date: Mon, 26 Feb 2018 19:12:00 +0100 To: Joe Moriarty Cc: linux-usb@vger.kernel.org List-ID: T24gTW9uLCBGZWIgMjYsIDIwMTggYXQgMTI6MTA6MDJQTSAtMDUwMCwgSm9lIE1vcmlhcnR5IHdy b3RlOgo+IFRoZSBQYXJmYWl0ICh2ZXJzaW9uIDIuMS4wKSBzdGF0aWMgY29kZSBhbmFseXNpcyB0 b29sIGZvdW5kIHRoZQo+IGZvbGxvd2luZyBOVUxMIHBvaW50ZXIgZGVyZWZlcmVuY2UgcHJvYmxl bS4KCldoYXQgaXMgdGhlICJDV0UgNDc2IiB0aGluZyBpbiB0aGUgc3ViamVjdCBsaW5lIGZvcj8K Cj4gCj4gZGV2X3RvX3Nob3N0KCkgaW4gaW5jbHVkZS9zY3NpL3Njc2lfaG9zdC5oIGhhcyB0aGUg YWJpbGl0eSB0byByZXR1cm4KPiBOVUxMIGlmIHRoZSBzY3NpIGhvc3QgZGV2aWNlIGRvZXMgbm90 IGhhdmUgdGhlIFNjc2lfaG9zdC0+cGFyZW50Cj4gZmllbGQgc2V0LiAgV2l0aCB0aGUgcG9zc2li aWx0eSBvZiBhIE5VTEwgcG9pbnRlciBiZWluZyBzZXQgZm9yCj4gdGhlIFNjc2lfSG9zdC0+cGFy ZW50IGZpZWxkLCBjYWxscyB0byBob3N0X3RvX3VzKCkgaGF2ZSB0byBtYWtlCj4gc3VyZSB0aGUg cmV0dXJuIHBvaW50ZXIgaXMgbm90IG51bGwuICBDaGFuZ2VzIHdlcmUgbWFkZSB0byBjaGVjawo+ IGZvciBhIHJldHVybiB2YWx1ZSBvZiBOVUxMIG9uIGNhbGxzIHRvIGhvc3RfdG9fdXMoKS4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBKb2UgTW9yaWFydHkgPGpvZS5tb3JpYXJ0eUBvcmFjbGUuY29tPgo+ IFJldmlld2VkLWJ5OiBTdGV2ZW4gU2lzdGFyZSA8c3RldmVuLnNpc3RhcmVAb3JhY2xlLmNvbT4K PiBBY2tlZC1ieTogSGFrb24gQnVnZ2UgPGhha29uLmJ1Z2dlQG9yYWNsZS5jb20+Cj4gLS0tCj4g IGRyaXZlcnMvdXNiL3N0b3JhZ2Uvc2NzaWdsdWUuYyB8IDUzICsrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKy0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygr KSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy91c2Ivc3RvcmFnZS9z Y3NpZ2x1ZS5jIGIvZHJpdmVycy91c2Ivc3RvcmFnZS9zY3NpZ2x1ZS5jCj4gaW5kZXggYzI2N2Yy ODEyYTA0Li45NGFmNjA5ZDQ5YmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2Ivc3RvcmFnZS9z Y3NpZ2x1ZS5jCj4gKysrIGIvZHJpdmVycy91c2Ivc3RvcmFnZS9zY3NpZ2x1ZS5jCj4gQEAgLTY2 LDYgKzY2LDkgQEAgc3RhdGljIGludCBzbGF2ZV9hbGxvYyAoc3RydWN0IHNjc2lfZGV2aWNlICpz ZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgdXNfZGF0YSAqdXMgPSBob3N0X3RvX3VzKHNkZXYtPmhvc3Qp Owo+ICAKPiArCWlmICghdXMpCj4gKwkJcHJfd2FybigiRXJyb3IgaW4gJXM6IHVzID0gTlVMTFxu IiwgX19mdW5jX18pOwoKSXQgaXMgYSBkcml2ZXIsIHlvdSBzaG91bGQgbmV2ZXIgdXNlIHByXyog Y2FsbHMsIGJ1dCByYXRoZXIgZGV2XyogY2FsbHMuCgpBbHNvLCB5b3UgZG9uJ3QgZXhpdCwgYXJl IHlvdSBzdXJlIHRoZSBjb2RlIGtlZXBzIHdvcmtpbmcgYWZ0ZXIgdGhpcwpoYXBwZW5zPwoKQW5k IHdoYXQgaXMgYSB1c2VyIHN1cHBvc2VkIHRvIGRvIHdpdGggdGhpcyB3YXJuaW5nIG1lc3NhZ2U/ Cgo+ICsKPiAgCS8qCj4gIAkgKiBTZXQgdGhlIElOUVVJUlkgdHJhbnNmZXIgbGVuZ3RoIHRvIDM2 LiAgV2UgZG9uJ3QgdXNlIGFueSBvZgo+ICAJICogdGhlIGV4dHJhIGRhdGEgYW5kIG1hbnkgZGV2 aWNlcyBjaG9rZSBpZiBhc2tlZCBmb3IgbW9yZSBvcgo+IEBAIC0xMDIsNiArMTA1LDExIEBAIHN0 YXRpYyBpbnQgc2xhdmVfY29uZmlndXJlKHN0cnVjdCBzY3NpX2RldmljZSAqc2RldikKPiAgewo+ ICAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9zdF90b191cyhzZGV2LT5ob3N0KTsKPiAgCj4gKwlp ZiAoIXVzKSB7Cj4gKwkJcHJfd2FybigiRXJyb3IgaW4gJXM6IHVzID0gTlVMTFxuIiwgX19mdW5j X18pOwo+ICsJCXJldHVybiAwOwoKV2h5IGFyZSB5b3UgcmV0dXJuaW5nIGEgc3VjY2Vzcz8KCj4g Kwl9Cj4gKwo+ICAJLyoKPiAgCSAqIE1hbnkgZGV2aWNlcyBoYXZlIHRyb3VibGUgdHJhbnNmZXJy aW5nIG1vcmUgdGhhbiAzMktCIGF0IGEgdGltZSwKPiAgCSAqIHdoaWxlIG90aGVycyBoYXZlIHRy b3VibGUgd2l0aCBtb3JlIHRoYW4gNjRLLiBBdCB0aGlzIHRpbWUgd2UKPiBAQCAtMzMxLDYgKzMz OSwxMSBAQCBzdGF0aWMgaW50IHRhcmdldF9hbGxvYyhzdHJ1Y3Qgc2NzaV90YXJnZXQgKnN0YXJn ZXQpCj4gIHsKPiAgCXN0cnVjdCB1c19kYXRhICp1cyA9IGhvc3RfdG9fdXMoZGV2X3RvX3Nob3N0 KHN0YXJnZXQtPmRldi5wYXJlbnQpKTsKCkNhbiBob3N0X3RvX3VzKCkgaGFuZGxlIE5VTEw/CgpO b3BlLCBqdXN0IGxvb2tlZCBhdCBpdCwgdGhpcyB3aWxsIG5ldmVyIGNhdXNlIHRoZSByZXR1cm4g dmFsdWUgdG8gYmUKTlVMTCwgeW91ciBjaGVja2VyIG5lZWRzIHNvbWUgbW9yZSB3b3JrIDooCgo+ ICAKPiArCWlmICghdXMpIHsKPiArCQlwcl93YXJuKCJFcnJvciBpbiAlczogdXMgPSBOVUxMXG4i LCBfX2Z1bmNfXyk7Cj4gKwkJcmV0dXJuIDA7Cj4gKwl9Cj4gKwo+ICAJLyoKPiAgCSAqIFNvbWUg VVNCIGRyaXZlcyBkb24ndCBzdXBwb3J0IFJFUE9SVCBMVU5TLCBldmVuIHRob3VnaCB0aGV5Cj4g IAkgKiByZXBvcnQgYSBTQ1NJIHJldmlzaW9uIGxldmVsIGFib3ZlIDIuICBUZWxsIHRoZSBTQ1NJ IGxheWVyCj4gQEAgLTM2MSw2ICszNzQsMTEgQEAgc3RhdGljIGludCBxdWV1ZWNvbW1hbmRfbGNr KHN0cnVjdCBzY3NpX2NtbmQgKnNyYiwKPiAgewo+ICAJc3RydWN0IHVzX2RhdGEgKnVzID0gaG9z dF90b191cyhzcmItPmRldmljZS0+aG9zdCk7Cj4gIAo+ICsJaWYgKCF1cykgewoKSG93IGlzIHRo YXQgcG9zc2libGU/ICBUaGlzIGRvZXNuJ3QgaGF2ZSBhbnl0aGluZyB0byBkbyB3aXRoIHlvdXIK c3ViamVjdCBsaW5lLCByaWdodD8KCj4gKwkJcHJfd2FybigiRXJyb3IgaW4gJXM6IHVzID0gTlVM TFxuIiwgX19mdW5jX18pOwo+ICsJCXJldHVybiAwOwoKc3VjY2Vzcz8KCkkgc3RvcHBlZCByZXZp ZXdpbmcgaGVyZSwgc29ycnkgOigKCmdyZWcgay1oCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9tIHRo aXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUgYm9k eSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9yZG9t byBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK