From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: alsa-devel@alsa-project.org, shengjiu.wang@nxp.com,
broonie@kernel.org, Fabio Estevam <fabio.estevam@nxp.com>,
leonard.crestez@nxp.com, daniel.baluta@nxp.com
Subject: Re: [PATCH] ASoC: imx-wm8962: Use a single private structure
Date: Mon, 26 Feb 2018 10:59:20 -0800 [thread overview]
Message-ID: <20180226185920.GA24671@Asurada-Nvidia> (raw)
In-Reply-To: <1519670997-15274-1-git-send-email-festevam@gmail.com>
On Mon, Feb 26, 2018 at 03:49:57PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit 8f7206d69ab8c ("ASoC: imx-wm8962: Remove global variables")
> ended up by assigning the same value for two different structs:
>
> struct imx_priv *priv = snd_soc_card_get_drvdata(card);
> struct imx_wm8962_data *data = snd_soc_card_get_drvdata(card);
>
> Fix it by consolidating all the private data into a single structure.
Instead of having this fix to this driver, I would consider about
removing it as I don't see any reason of having it any more since
fsl-asoc-card does the same job. Agree?
next prev parent reply other threads:[~2018-02-26 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 18:49 [PATCH] ASoC: imx-wm8962: Use a single private structure Fabio Estevam
2018-02-26 18:59 ` Nicolin Chen [this message]
2018-02-26 19:06 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226185920.GA24671@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=leonard.crestez@nxp.com \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.