From mboxrd@z Thu Jan 1 00:00:00 1970 From: idosch at idosch.org (Ido Schimmel) Date: Mon, 26 Feb 2018 22:02:17 +0200 Subject: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning In-Reply-To: References: <20180226085948.19368-1-idosch@mellanox.com> <20180226085948.19368-3-idosch@mellanox.com> Message-ID: <20180226200217.GB4195@splinter> On Mon, Feb 26, 2018 at 06:31:49PM +0200, Petr Machata wrote: > Ido Schimmel writes: > > > +learning_test() > > +{ > > + local mac=de:ad:be:ef:13:37 > > + local ageing_time > > + local br_port1=$2 # Connected to `host1_if`. > > + local host1_if=$3 > > + local host2_if=$4 > > + local bridge=$1 > > I don't think applying RXT in Bash is appropriate. The ordering of the > local variables should instead follow the order of function arguments, > because that information isn't communicated by the function prototype > itself, unlike C. Makes sense. Will fix. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: idosch@idosch.org (Ido Schimmel) Date: Mon, 26 Feb 2018 22:02:17 +0200 Subject: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning In-Reply-To: References: <20180226085948.19368-1-idosch@mellanox.com> <20180226085948.19368-3-idosch@mellanox.com> Message-ID: <20180226200217.GB4195@splinter> Content-Type: text/plain; charset="UTF-8" Message-ID: <20180226200217.FgPZs8UV1VpEj8-kgga9zd2w3ow14gjZT-TRpg9rqxQ@z> On Mon, Feb 26, 2018@06:31:49PM +0200, Petr Machata wrote: > Ido Schimmel writes: > > > +learning_test() > > +{ > > + local mac=de:ad:be:ef:13:37 > > + local ageing_time > > + local br_port1=$2 # Connected to `host1_if`. > > + local host1_if=$3 > > + local host2_if=$4 > > + local bridge=$1 > > I don't think applying RXT in Bash is appropriate. The ordering of the > local variables should instead follow the order of function arguments, > because that information isn't communicated by the function prototype > itself, unlike C. Makes sense. Will fix. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:39679 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbeBZUCd (ORCPT ); Mon, 26 Feb 2018 15:02:33 -0500 Date: Mon, 26 Feb 2018 22:02:17 +0200 From: Ido Schimmel To: Petr Machata Cc: Ido Schimmel , netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, davem@davemloft.net, shuah@kernel.org, jiri@mellanox.com, dsahern@gmail.com, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com, f.fainelli@gmail.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, mlxsw@mellanox.com Subject: Re: [PATCH net-next 02/14] selftests: forwarding: Add a test for FDB learning Message-ID: <20180226200217.GB4195@splinter> References: <20180226085948.19368-1-idosch@mellanox.com> <20180226085948.19368-3-idosch@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Mon, Feb 26, 2018 at 06:31:49PM +0200, Petr Machata wrote: > Ido Schimmel writes: > > > +learning_test() > > +{ > > + local mac=de:ad:be:ef:13:37 > > + local ageing_time > > + local br_port1=$2 # Connected to `host1_if`. > > + local host1_if=$3 > > + local host2_if=$4 > > + local bridge=$1 > > I don't think applying RXT in Bash is appropriate. The ordering of the > local variables should instead follow the order of function arguments, > because that information isn't communicated by the function prototype > itself, unlike C. Makes sense. Will fix. Thanks!