From: Wolfram Sang <wsa@the-dreams.de>
To: George Cherian <george.cherian@cavium.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer
Date: Mon, 26 Feb 2018 21:22:48 +0100 [thread overview]
Message-ID: <20180226202248.ej3bt5o7sam6qljv@ninjato> (raw)
In-Reply-To: <1516253964-4615-4-git-send-email-george.cherian@cavium.com>
[-- Attachment #1: Type: text/plain, Size: 578 bytes --]
On Thu, Jan 18, 2018 at 05:39:24AM +0000, George Cherian wrote:
> I2C bus enters the STOP condition after the DATA_DONE interrupt is raised.
> Essentially the driver should be checking the bus state before sending
> the next transaction.
Yes.
> In case the next transaction is initiated while the
> bus is busy, the prior transactions stop condition is not acheived.
I didn't fully get why you can't check the BUSY bit and wait a little
just before you push out the next message?
> Add the check to make sure the bus is not busy before next transaction.
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-26 20:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 5:39 [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK George Cherian
2018-01-18 5:39 ` [PATCH 2/4] i2c: xlp9xx: Handle transactions with I2C_M_RECV_LEN properly George Cherian
2018-02-26 20:20 ` Wolfram Sang
2018-01-18 5:39 ` [PATCH 3/4] i2c: xlp9xx: report SMBus block read functionality George Cherian
2018-02-26 20:21 ` Wolfram Sang
2018-01-18 5:39 ` [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer George Cherian
2018-02-26 20:22 ` Wolfram Sang [this message]
2018-02-27 5:00 ` George Cherian
2018-02-27 5:11 ` George Cherian
2018-02-27 9:05 ` Wolfram Sang
2018-02-27 9:32 ` George Cherian
2018-02-27 9:04 ` Wolfram Sang
2018-02-27 9:32 ` George Cherian
2018-01-30 14:28 ` [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK George Cherian
2018-02-22 18:02 ` dann frazier
2018-02-26 20:20 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180226202248.ej3bt5o7sam6qljv@ninjato \
--to=wsa@the-dreams.de \
--cc=george.cherian@cavium.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.