From: Christoph Hellwig <hch@lst.de>
To: Jan Kara <jack@suse.cz>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Hou Tao <houtao1@huawei.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 1/6] genhd: Fix leaked module reference for NVME devices
Date: Tue, 27 Feb 2018 01:09:48 +0100 [thread overview]
Message-ID: <20180227000948.GA5249@lst.de> (raw)
In-Reply-To: <20180226120142.25786-2-jack@suse.cz>
On Mon, Feb 26, 2018 at 01:01:37PM +0100, Jan Kara wrote:
> Commit 8ddcd653257c "block: introduce GENHD_FL_HIDDEN" added handling of
> hidden devices to get_gendisk() but forgot to drop module reference
> which is also acquired by get_disk(). Drop the reference as necessary.
>
> Arguably the function naming here is misleading as put_disk() is *not*
> the counterpart of get_disk() but let's fix that in the follow up
> commit since that will be more intrusive.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-02-27 0:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 12:01 [PATCH 0/6 v2] block: Fix races in bdev - gendisk handling Jan Kara
2018-02-26 12:01 ` [PATCH 1/6] genhd: Fix leaked module reference for NVME devices Jan Kara
2018-02-27 0:09 ` Christoph Hellwig [this message]
2018-02-26 12:01 ` [PATCH 2/6] genhd: Rename get_disk() to get_disk_and_module() Jan Kara
2018-02-26 12:01 ` [PATCH 3/6] genhd: Add helper put_disk_and_module() Jan Kara
2018-02-26 12:01 ` [PATCH 4/6] genhd: Fix use after free in __blkdev_get() Jan Kara
2018-02-26 12:01 ` [PATCH 5/6] genhd: Fix BUG in blkdev_open() Jan Kara
2018-02-26 12:01 ` [PATCH 6/6] blockdev: Avoid two active bdev inodes for one device Jan Kara
2018-02-26 16:04 ` [PATCH 0/6 v2] block: Fix races in bdev - gendisk handling Jens Axboe
2018-02-26 16:43 ` Jan Kara
2018-02-26 16:49 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2018-02-06 16:05 [PATCH 0/6] " Jan Kara
2018-02-06 16:05 ` [PATCH 1/6] genhd: Fix leaked module reference for NVME devices Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227000948.GA5249@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.