From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: alsa-devel@alsa-project.org, shengjiu.wang@nxp.com,
broonie@kernel.org, Fabio Estevam <fabio.estevam@nxp.com>,
leonard.crestez@nxp.com, daniel.baluta@nxp.com
Subject: Re: [PATCH v3] ASoC: imx-wm8962: Remove machine driver
Date: Mon, 26 Feb 2018 16:46:44 -0800 [thread overview]
Message-ID: <20180227004643.GA6370@Asurada-Nvidia> (raw)
In-Reply-To: <1519672923-26886-1-git-send-email-festevam@gmail.com>
On Mon, Feb 26, 2018 at 04:22:03PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> fsl-asoc-card machine driver also handles wm8962, so there is
> really no need for keeping the dedicated imx-wm8962 driver anymore.
>
> Remove the imx-wm8962 machine driver.
>
> Suggested-by: Nicolin Chen <nicoleotsuka@gmail.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Did you verify it on a certain hardware? If so, I may give my Ack
directly as it looks good to me. Otherwise, I would need to test.
> ---
> Changes since v2:
> - Also remove the dt-bindings
>
> .../devicetree/bindings/sound/imx-audio-wm8962.txt | 53 ----
And could you please also remove line 31 at
Documentation/devicetree/bindings/sound/fsl-asoc-card.txt ?
Since this imx-audio-wm8962.txt will be removed, that line could
be removed too. Thanks.
next prev parent reply other threads:[~2018-02-27 0:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 19:22 [PATCH v3] ASoC: imx-wm8962: Remove machine driver Fabio Estevam
2018-02-27 0:46 ` Nicolin Chen [this message]
2018-02-27 1:25 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227004643.GA6370@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=leonard.crestez@nxp.com \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.