Re: [PATCH] drm/nouveau: Replace the iturbt_709 prop with the standarad COLOR_ENCODNIG prop

From: "Ville Syrjälä" <ville.syrjala-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Ilia Mirkin <imirkin-FrUbXkNCsVf2fBVCVOL8/A@public.gmane.org>
Cc: nouveau
	<nouveau-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	Daniel Vetter <daniel-/w4YWyX8dFk@public.gmane.org>,
	dri-devel
	<dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>,
	Ben Skeggs <bskeggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] drm/nouveau: Replace the iturbt_709 prop with the standarad COLOR_ENCODNIG prop
Date: Tue, 27 Feb 2018 10:49:39 +0200	[thread overview]
Message-ID: <20180227084939.GY5453@intel.com> (raw)
In-Reply-To: <CAKb7Uvgv1G71QwiPpgLXmx9qbbxrZU1icjwpKO45=uA53z9xRA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Tue, Feb 27, 2018 at 12:54:47AM -0500, Ilia Mirkin wrote:
> On Tue, Feb 20, 2018 at 9:25 AM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:
> > On Tue, Feb 20, 2018 at 8:48 AM, Ville Syrjala
> > <ville.syrjala@linux.intel.com> wrote:
> >> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >>
> >> Replace the ad-hoc iturbt_709 property with the new standard
> >> COLOR_ENCODING property. Compiles, but not tested.
> >>
> >> Cc: Daniel Vetter <daniel@ffwll.ch>
> >> Cc: nouveau@lists.freedesktop.org
> >> Cc: Ben Skeggs <bskeggs@redhat.com>
> >> Cc: Ilia Mirkin <imirkin@alum.mit.edu>
> >> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > s/standarad/standard/ in subject
> >
> > I'd like the opportunity to test this out on real hardware, but I
> > don't have any pre-NV41 boards plugged in right now. I should be able
> > to attend to it within 7 days. If you don't hear back from me by then,
> > I'd appreciate a ping, as I do let things (hopefully occasionally)
> > slip through.
> 
> Tested this out on a NV34. Seems to work - at least the green SMPTE
> bar looks different in the two different modes (had to hack modetest
> to use the SMPTE pattern on planes).
> 
> I do wonder about the new color range property... that's more of a
> connector thing than a plane thing no? Presumably over S-Video it's a
> partial range, and over VGA it's full? I'd flip it to always full here
> tbh. (Or just not provide it at all.)

No, this property is just about the range of the input data. Full range
YCbCr isn't exaclty common so you'd rarely need this. JPEG uses full
range I believe.

> 
> Anyways, with the subject typo(s! noticed ENCODNIG -> ENCODING just
> now) fixed, this is
> 
> Reviewed-by: Ilia Mirkin <imirkin@alum.mit.edu>

Cool. Thanks.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau