From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,03/12] staging: typec: tcpci: support port config passed via dt From: Heikki Krogerus Message-Id: <20180227110302.GE25535@kuha.fi.intel.com> Date: Tue, 27 Feb 2018 13:03:02 +0200 To: Jun Li Cc: "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "linux@roeck-us.net" , "a.hajda@samsung.com" , "mark.rutland@arm.com" , "yueyao@google.com" , Peter Chen , "garsilva@embeddedor.com" , "o_leveque@orange.fr" , "shufan_lee@richtek.com" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , dl-linux-imx List-ID: SGksCgpPbiBNb24sIEZlYiAyNiwgMjAxOCBhdCAwMjozMDo1M1BNICswMDAwLCBKdW4gTGkgd3Jv dGU6Cj4gPiA+ICsJY2hpbGQgPSBvZl9nZXRfY2hpbGRfYnlfbmFtZSh0Y3BjaS0+ZGV2LT5vZl9u b2RlLCAiY29ubmVjdG9yIik7Cj4gPiA+ICsJaWYgKCFjaGlsZCkgewo+ID4gPiArCQlkZXZfZXJy KHRjcGNpLT5kZXYsICJmYWlsZWQgdG8gZ2V0IGNvbm5lY3RvciBub2RlLlxuIik7Cj4gPiA+ICsJ CXJldHVybiAtRUlOVkFMOwo+ID4gPiArCX0KPiA+IAo+ID4gV2h5IGRvIHlvdSBuZWVkIHNlcGFy YXRlIGNoaWxkIG5vZGUgZm9yIHRoZSBjb25uZWN0b3I/IFlvdSB3aWxsIGFsd2F5cwo+ID4gaGF2 ZSBvbmx5IG9uZSBjb25uZWN0b3IgcGVyIHRjcGMsIGkuZS4gdGhlIHRjcGNpIGFscmVhZHkgcmVw cmVzZW50cyB0aGUKPiA+IGNvbm5lY3RvciBhbmQgYWxsIGl0cyBjYXBhYmlsaXRpZXMuCj4gPiAK PiBUaGlzIGlzIG15IG9yaWdpbmFsIGlkZWEsIG15IHVuZGVyc3RhbmRpbmcgaXMgUm9iIGV4cGVj dHMgdGhvc2UgcHJvcGVydGllcyBzaG91bGQKPiBhcHBseSBmb3IgYSBjb21tb24gdXNiIGNvbm5l Y3RvciBub2RlWzFdLCB0aGF0IHdheSBJIG5lZWQgYWRkIGEgY2hpbGQgbm9kZSBmb3IgaXQsCj4g c29ycnkgSSBkaWRuJ3QgbWFrZSB0aGUgZHQtYmluZGluZyBwYXRjaGVzIGNvbWUgZmlyc3QgaW4g dGhpcyBzZXJpZXMsIHBsZWFzZSBzZWUKPiBwYXRjaCAxMCwxMS4KPiAKPiBbMV0gaHR0cHM6Ly9w YXRjaHdvcmsua2VybmVsLm9yZy9wYXRjaC8xMDIzMTQ0Ny8KCkJ1dCB3YXMgdGhlIGlkZWEgcmVh bGx5IHRvIHB1dCBwcm9wZXJ0aWVzIGxpa2UgdGhlIFRDUEMgY2FwYWJpbGl0aWVzCnVuZGVyIHRo ZSB1c2IgY29ubmVjdG9yIGNoaWxkIG5vZGU/IFRoYXQgd2lsbCBmb3JjZSB1cyB0byBleHRyYWN0 CnRoZSBzYW1lIHByb3BlcnRpZXMgaW4gdHdvIGRpZmZlcmVudCBtZXRob2RzIGluIGV2ZXJ5IFVT QiBUeXBlLUMKZHJpdmVyLiBPbmUgZXh0cmFjdGluZyB0aGVtIGZyb20gRFQsIGFuZCBhbm90aGVy IGZyb20gb3RoZXIgRlcKaW50ZXJmYWNlcyBhbmQgYnVpbGQtaW4gcHJvcGVydGllcy4KClRvIGF2 b2lkIHRoYXQsIGxldCdzIGp1c3QgZXhwZWN0IHRvIGdldCB0aGVzZSBwcm9wZXJ0aWVzIGluIHRo ZSBub2RlCmZvciB0Y3BjLCBub3QgdGhlIHVzYiBjb25uZWN0b3IgY2hpbGQuCgoKVGhhbmtzLAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 27 Feb 2018 13:03:02 +0200 From: Heikki Krogerus Subject: Re: [PATCH v2 03/12] staging: typec: tcpci: support port config passed via dt Message-ID: <20180227110302.GE25535@kuha.fi.intel.com> References: <1519645759-12701-1-git-send-email-jun.li@nxp.com> <1519645759-12701-4-git-send-email-jun.li@nxp.com> <20180226140604.GD25535@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: To: Jun Li Cc: "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "linux@roeck-us.net" , "a.hajda@samsung.com" , "mark.rutland@arm.com" , "yueyao@google.com" , Peter Chen , "garsilva@embeddedor.com" , "o_leveque@orange.fr" , "shufan_lee@richtek.com" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , dl-linux-imx List-ID: Hi, On Mon, Feb 26, 2018 at 02:30:53PM +0000, Jun Li wrote: > > > + child = of_get_child_by_name(tcpci->dev->of_node, "connector"); > > > + if (!child) { > > > + dev_err(tcpci->dev, "failed to get connector node.\n"); > > > + return -EINVAL; > > > + } > > > > Why do you need separate child node for the connector? You will always > > have only one connector per tcpc, i.e. the tcpci already represents the > > connector and all its capabilities. > > > This is my original idea, my understanding is Rob expects those properties should > apply for a common usb connector node[1], that way I need add a child node for it, > sorry I didn't make the dt-binding patches come first in this series, please see > patch 10,11. > > [1] https://patchwork.kernel.org/patch/10231447/ But was the idea really to put properties like the TCPC capabilities under the usb connector child node? That will force us to extract the same properties in two different methods in every USB Type-C driver. One extracting them from DT, and another from other FW interfaces and build-in properties. To avoid that, let's just expect to get these properties in the node for tcpc, not the usb connector child. Thanks, -- heikki