All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: linux-clk@vger.kernel.org, sboyd@kernel.org,
	mturquette@baylibre.com, linux-omap@vger.kernel.org,
	jsarha@ti.com
Subject: Re: [PATCH 0/3] clk: ti: add CLK_SET_RATE_PARENT support for clkctrl
Date: Tue, 27 Feb 2018 08:48:13 -0800	[thread overview]
Message-ID: <20180227164813.GB5448@atomide.com> (raw)
In-Reply-To: <20180227164142.GA5448@atomide.com>

* Tony Lindgren <tony@atomide.com> [180227 16:43]:
> * Tero Kristo <t-kristo@ti.com> [180227 06:35]:
> > On 27/02/18 00:05, Tony Lindgren wrote:
> > > Hmm so should we have all the timers use bit 0 in the dtsi?
> > > Or default to bit 24 for all of them?
> > 
> > Who is going to control the clkctrl clock for the timers if you just control
> > the opt clock? Also, ain't the bit 24 the clksel mux setting? Tweaking that
> > would seem wrong...
> 
> Yeah OK.

$ git grep TIMER arch/arm/boot/dts/* | grep CLKCTRL

And that shows timer1 using bit 24 for omap4, omap5 and dra7
dtsi files.

So shouldn't that then be just bit 0 instead of bit 24 for
those? And then we let omap_dm_timer_init_one() reparent it?

Regards,

Tony

  reply	other threads:[~2018-02-27 16:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 15:10 [PATCH 0/3] clk: ti: add CLK_SET_RATE_PARENT support for clkctrl Tero Kristo
2018-02-26 15:10 ` [PATCH 1/3] clk: ti: clkctrl: add support for CLK_SET_RATE_PARENT flag Tero Kristo
2018-02-26 15:10 ` [PATCH 2/3] clk: ti: am33xx: add set-rate-parent support for display clkctrl clock Tero Kristo
2018-02-26 15:10 ` [PATCH 3/3] clk: ti: am43xx: " Tero Kristo
2018-02-26 22:05 ` [PATCH 0/3] clk: ti: add CLK_SET_RATE_PARENT support for clkctrl Tony Lindgren
2018-02-27  6:34   ` Tero Kristo
2018-02-27 16:42     ` Tony Lindgren
2018-02-27 16:48       ` Tony Lindgren [this message]
2018-02-28  5:37         ` Tero Kristo
2018-02-28 21:58           ` Tony Lindgren
2018-03-01  7:04             ` Tero Kristo
2018-03-01 15:26               ` Tony Lindgren
2018-02-28 10:23 ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180227164813.GB5448@atomide.com \
    --to=tony@atomide.com \
    --cc=jsarha@ti.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.