From: "Michael S. Tsirkin" <mst@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: stefanha@redhat.com, mlureau@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC 2/5] vhost-user: Introduce new request to send virtio device status
Date: Tue, 27 Feb 2018 17:01:28 +0200 [thread overview]
Message-ID: <20180227165057-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180216172910.8549-3-maxime.coquelin@redhat.com>
On Fri, Feb 16, 2018 at 06:29:07PM +0100, Maxime Coquelin wrote:
> diff --git a/docs/interop/vhost-user.txt b/docs/interop/vhost-user.txt
> index 9fcf48d611..daa452bd36 100644
> --- a/docs/interop/vhost-user.txt
> +++ b/docs/interop/vhost-user.txt
> @@ -368,6 +368,7 @@ Protocol features
> #define VHOST_USER_PROTOCOL_F_MTU 4
> #define VHOST_USER_PROTOCOL_F_SLAVE_REQ 5
> #define VHOST_USER_PROTOCOL_F_CROSS_ENDIAN 6
> +#define VHOST_USER_PROTOCOL_F_VIRTIO_STATUS 7
>
> Master message types
> --------------------
> @@ -663,6 +664,19 @@ Master message types
> field, and slaves MUST NOT accept SET_CONFIG for read-only
> configuration space fields unless the live migration bit is set.
>
> +* VHOST_USER_SET_VIRTIO_STATUS
> +
> + Id: 26
> + Equivalent ioctl: N/A
> + Master payload: u64
> + Slave payload: N/A
> +
> + Sent by the vhost-user master to notify of virtio device status change.
> + The payload is a u64 representing the virtio device status as defined in
> + the virtio specification.
> + The request should be sent only when VHOST_USER_PROTOCOL_F_VIRTIO_STATUS
> + protocol feature has been negotiated.
> +
> Slave message types
> -------------------
>
So for now backend was only activated after DRIVER_OK. Does this message
mean that we must send updates such as _DRIVER as well?
Further, this is kind of one-way, but there are several cases where device
modifies the status. One is NEEDS_RESET. Another is clearing
of FEATURES_OK.
--
MST
next prev parent reply other threads:[~2018-02-27 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-16 17:29 [Qemu-devel] [RFC 0/5] vhost-user: Forward virtio device status updates Maxime Coquelin
2018-02-16 17:29 ` [Qemu-devel] [RFC 1/5] vhost: send virtio device status update to the backend Maxime Coquelin
2018-02-16 17:29 ` [Qemu-devel] [RFC 2/5] vhost-user: Introduce new request to send virtio device status Maxime Coquelin
2018-02-27 15:01 ` Michael S. Tsirkin [this message]
2018-02-27 16:30 ` Maxime Coquelin
2018-02-16 17:29 ` [Qemu-devel] [RFC 3/5] vhost_net: send virtio device status update to the backend Maxime Coquelin
2018-02-16 17:29 ` [Qemu-devel] [RFC 4/5] vhost-user-blk: send virtio status " Maxime Coquelin
2018-02-16 17:29 ` [Qemu-devel] [RFC 5/5] vhost-user-scsi: " Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227165057-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mlureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.