From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [RFC QEMU PATCH v4 00/10] Implement vNVDIMM for Xen HVM guest Date: Tue, 27 Feb 2018 17:22:23 +0000 Message-ID: <20180227172223.GD1799@perard.uk.xensource.com> References: <20171207101030.22364-1-haozhong.zhang@intel.com> <20171207101812.23602-1-haozhong.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eqixT-0000jM-C4 for xen-devel@lists.xenproject.org; Tue, 27 Feb 2018 17:22:31 +0000 Content-Disposition: inline In-Reply-To: <20171207101812.23602-1-haozhong.zhang@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Haozhong Zhang Cc: Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Igor Mammedov , Paolo Bonzini , Chao Peng , xen-devel@lists.xenproject.org, Dan Williams , Richard Henderson , Xiao Guangrong List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBEZWMgMDcsIDIwMTcgYXQgMDY6MTg6MDJQTSArMDgwMCwgSGFvemhvbmcgWmhhbmcg d3JvdGU6Cj4gVGhpcyBpcyB0aGUgUUVNVSBwYXJ0IHBhdGNoZXMgdGhhdCB3b3JrcyB3aXRoIHRo ZSBhc3NvY2lhdGVkIFhlbgo+IHBhdGNoZXMgdG8gZW5hYmxlIHZOVkRJTU0gc3VwcG9ydCBmb3Ig WGVuIEhWTSBkb21haW5zLiBYZW4gcmVsaWVzIG9uCj4gUUVNVSB0byBidWlsZCBndWVzdCBORklU IGFuZCBOVkRJTU0gbmFtZXNwYWNlIGRldmljZXMsIGFuZCBhbGxvY2F0ZQo+IGd1ZXN0IGFkZHJl c3Mgc3BhY2UgZm9yIHZOVkRJTU0gZGV2aWNlcy4KCkkndmUgZ290IG90aGVyIHF1ZXN0aW9uLCBh bmQgbWF5YmUgcG9zc2libGUgaW1wcm92ZW1lbnRzLgoKV2hlbiBRRU1VIGJ1aWxkIHRoZSBBQ1BJ IHRhYmxlcywgaXQgYWxzbyBpbml0aWFsaXplIHNvbWUgTWVtb3J5UmVnaW9uLAp3aGljaCB1c2Ug bW9yZSBndWVzdCBtZW1vcnkuIERvIHlvdSBrbm93IGlmIHRob3NlIHJlZ2lvbnMgYXJlIHVzZWQg d2l0aAp5b3VyIHBhdGNoIHNlcmllcyBvbiBYZW4/IE90aGVyd2lzZSwgd2UgY291bGQgdHJ5IHRv IGF2b2lkIHRoZWlyCmNyZWF0aW9uIHdpdGggdGhpczoKSW4geGVuZnZfbWFjaGluZV9vcHRpb25z KCkKbS0+cm9tX2ZpbGVfaGFzX21yID0gZmFsc2U7CihzZXR0aW5nIHRoaXMgaW4geGVuX2h2bV9p bml0KCkgd291bGQgcHJvYmFibHkgYmUgYmV0dGVyLCBidXQgSSBoYXZuJ3QKdHJ5KQoKSWYgdGhp cyBpcyBwb3NzaWJsZSwgbGlieGwgd291bGQgbm90IG5lZWQgdG8gYWxsb2NhdGUgbW9yZSBtZW1v cnkgZm9yCnRoZSBndWVzdCAoZG1fYWNwaV9zaXplKS4KCi0tIApBbnRob255IFBFUkFSRAoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1h aWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcKaHR0cHM6Ly9saXN0cy54 ZW5wcm9qZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL3hlbi1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqixS-0003iG-J1 for qemu-devel@nongnu.org; Tue, 27 Feb 2018 12:22:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqixN-00052D-Le for qemu-devel@nongnu.org; Tue, 27 Feb 2018 12:22:30 -0500 Received: from smtp.citrix.com ([66.165.176.89]:53239) by eggs.gnu.org with esmtps (TLS1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.71) (envelope-from ) id 1eqixN-00051g-FW for qemu-devel@nongnu.org; Tue, 27 Feb 2018 12:22:25 -0500 Date: Tue, 27 Feb 2018 17:22:23 +0000 From: Anthony PERARD Message-ID: <20180227172223.GD1799@perard.uk.xensource.com> References: <20171207101030.22364-1-haozhong.zhang@intel.com> <20171207101812.23602-1-haozhong.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20171207101812.23602-1-haozhong.zhang@intel.com> Subject: Re: [Qemu-devel] [RFC QEMU PATCH v4 00/10] Implement vNVDIMM for Xen HVM guest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Haozhong Zhang Cc: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Stefano Stabellini , Konrad Rzeszutek Wilk , Dan Williams , Chao Peng , Eduardo Habkost , Igor Mammedov , "Michael S. Tsirkin" , Xiao Guangrong , Paolo Bonzini , Richard Henderson On Thu, Dec 07, 2017 at 06:18:02PM +0800, Haozhong Zhang wrote: > This is the QEMU part patches that works with the associated Xen > patches to enable vNVDIMM support for Xen HVM domains. Xen relies on > QEMU to build guest NFIT and NVDIMM namespace devices, and allocate > guest address space for vNVDIMM devices. I've got other question, and maybe possible improvements. When QEMU build the ACPI tables, it also initialize some MemoryRegion, which use more guest memory. Do you know if those regions are used with your patch series on Xen? Otherwise, we could try to avoid their creation with this: In xenfv_machine_options() m->rom_file_has_mr = false; (setting this in xen_hvm_init() would probably be better, but I havn't try) If this is possible, libxl would not need to allocate more memory for the guest (dm_acpi_size). -- Anthony PERARD