From: Tejun Heo <tj@kernel.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH RFC] sbitmap: Use lock/unlock atomic bitops
Date: Tue, 27 Feb 2018 10:14:04 -0800 [thread overview]
Message-ID: <20180227181404.GA24003@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <20180226221444.GD9157@vader.DHCP.thefacebook.com>
Hello, Omar.
On Mon, Feb 26, 2018 at 02:14:44PM -0800, Omar Sandoval wrote:
> > wake_index = atomic_read(&sbq->wake_index);
> > for (i = 0; i < SBQ_WAIT_QUEUES; i++) {
> > struct sbq_wait_state *ws = &sbq->ws[wake_index];
>
> So I think we want a patch for the test_and_set_bit_lock() and
> clear_bit_unlock(), but the rest should stay as-is.
Yeah, that makes sense to me. Would you be interested in updating the
patch?
Thanks.
--
tejun
next prev parent reply other threads:[~2018-02-27 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-18 13:05 [PATCH RFC] sbitmap: Use lock/unlock atomic bitops Tejun Heo
2018-02-26 22:14 ` Omar Sandoval
2018-02-27 18:14 ` Tejun Heo [this message]
2018-02-27 20:29 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227181404.GA24003@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.