From: "John W. Linville" <linville@tuxdriver.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: linville@redhat.com, Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com
Subject: Re: [ethtool, 1/3] ethtool: correct display of VF when showing vf/queue filters
Date: Tue, 27 Feb 2018 14:31:22 -0500 [thread overview]
Message-ID: <20180227193122.GB25950@tuxdriver.com> (raw)
In-Reply-To: <20180226184956.15709-2-jeffrey.t.kirsher@intel.com>
On Mon, Feb 26, 2018 at 10:49:54AM -0800, Jeff Kirsher wrote:
> From: Jacob Keller <jacob.e.keller@intel.com>
>
> The original code that implemented this accidentally had an inverted
> check, so it would never show the VF number properly.
>
> Fix this code to correctly display the VF number when we have one.
>
> Fixes: 36ee712b0fbc ("ethtool: support queue and VF fields for rxclass filters", 2017-03-23)
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
LGTM -- queued for ethtool-4.16...
Thanks!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
next prev parent reply other threads:[~2018-02-27 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 18:49 [ethtool 0/3][pull request] Ethtool Updates 2018-02-26 Jeff Kirsher
2018-02-26 18:49 ` [ethtool 1/3] ethtool: correct display of VF when showing vf/queue filters Jeff Kirsher
2018-02-27 19:31 ` John W. Linville [this message]
2018-02-26 18:49 ` [ethtool 2/3] ethtool: show VF and queue in the help for -N Jeff Kirsher
2018-02-27 19:31 ` [ethtool,2/3] " John W. Linville
2018-02-26 18:49 ` [ethtool 3/3] ethtool: correct VF index values for the ring_cookie parameter Jeff Kirsher
2018-02-27 19:32 ` [ethtool, " John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227193122.GB25950@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=linville@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.