From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] omap: Fix AM335x build with enabled fastboot flash
Date: Tue, 27 Feb 2018 22:56:53 +0100 [thread overview]
Message-ID: <20180227225653.3e18dc7e@jawa> (raw)
In-Reply-To: <20180227214504.32572-2-semen.protsenko@linaro.org>
On Tue, 27 Feb 2018 23:45:03 +0200
Sam Protsenko <semen.protsenko@linaro.org> wrote:
> When enabling CONFIG_FASTBOOT_FLASH in am335x_boneblack_defconfig,
> next build errors and warnings occur:
>
> arch/arm/mach-omap2/utils.c: In function ‘omap_set_fastboot_cpu’:
> arch/arm/mach-omap2/utils.c:26:16: warning: implicit declaration
> of function ‘omap_revision’ [-Wimplicit-function-declaration]
> u32 cpu_rev = omap_revision();
> ^~~~~~~~~~~~~
> arch/arm/mach-omap2/utils.c:29:7: error: ‘DRA762_ES1_0’ undeclared
> (first use in this function)
>
> Include asm/omap_common.h explicitly to avoid those.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> arch/arm/mach-omap2/utils.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/utils.c b/arch/arm/mach-omap2/utils.c
> index d11670c0ee..7d1ca274bf 100644
> --- a/arch/arm/mach-omap2/utils.c
> +++ b/arch/arm/mach-omap2/utils.c
> @@ -7,6 +7,8 @@
> #include <common.h>
> #include <asm/setup.h>
> #include <asm/arch/sys_proto.h>
> +#include <asm/omap_common.h>
> +
> static void do_cancel_out(u32 *num, u32 *den, u32 factor)
> {
> while (1) {
Acked-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180227/408c5fda/attachment.sig>
next prev parent reply other threads:[~2018-02-27 21:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 21:45 [U-Boot] [PATCH 0/2] am335x_boneblack: Enable fastboot flash support Sam Protsenko
2018-02-27 21:45 ` [U-Boot] [PATCH 1/2] omap: Fix AM335x build with enabled fastboot flash Sam Protsenko
2018-02-27 21:56 ` Lukasz Majewski [this message]
2018-02-27 21:58 ` Tom Rini
2018-03-14 14:10 ` [U-Boot] [U-Boot, " Tom Rini
2018-02-27 21:45 ` [U-Boot] [PATCH 2/2] configs: am335x_boneblack: Enable fastboot flash capability Sam Protsenko
2018-02-27 21:57 ` Lukasz Majewski
2018-02-27 21:58 ` Tom Rini
2018-03-14 14:10 ` [U-Boot] [U-Boot, " Tom Rini
2018-02-27 21:56 ` [U-Boot] [PATCH 0/2] am335x_boneblack: Enable fastboot flash support Lukasz Majewski
2018-02-27 23:38 ` Sam Protsenko
2018-02-27 23:54 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180227225653.3e18dc7e@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.