From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rodrigo Vivi Subject: Re: [PATCH v2 2/2] drm/i915/psr: Don't avoid PSR when PSR2 conditions are not met. Date: Tue, 27 Feb 2018 15:55:24 -0800 Message-ID: <20180227235524.GM17137@intel.com> References: <20180227212913.14083-1-rodrigo.vivi@intel.com> <20180227212913.14083-2-rodrigo.vivi@intel.com> <1519773060.11187.88.camel@dk-H97M-D3H> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 441E16E854 for ; Tue, 27 Feb 2018 23:55:26 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1519773060.11187.88.camel@dk-H97M-D3H> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Pandiyan, Dhinakaran" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBGZWIgMjcsIDIwMTggYXQgMDI6NDc6MjZQTSAtMDgwMCwgUGFuZGl5YW4sIERoaW5h a2FyYW4gd3JvdGU6Cj4gCj4gT24gVHVlLCAyMDE4LTAyLTI3IGF0IDEzOjI5IC0wODAwLCBSb2Ry aWdvIFZpdmkgd3JvdGU6Cj4gPiBXZSBjYW4gc3RpbGwgdXNlIFBTUjEgd2hlbiBQU1IyIGNvbmRp dGlvbnMgYXJlIG5vdCBtZXQuCj4gPiAKPiA+IFNvLCBsZXQncyBzcGxpdCB0aGUgY2hlY2sgaW4g YSB3YXkgdGhhdCB3ZSBtYWtlIHN1cmUgaGFzX3Bzcgo+ID4gZ2V0cyBzZXQgaW5kZXBlbmRlbnRs eSBvZiBQU1IyIGNyaXRlcmlhLgo+ID4gCj4gPiB2MjogRHVoISBIYW5kbGUgcHJvcGVyIHJldHVy biB0byBhdm9pZCBicmVha2luZyBQU1IyLgo+ID4gdjM6IChESyk6Cj4gPiAJLSBiZXR0ZXIgbmFt ZSBmb3IgcHNyMiBjb25kaXRpb25zIGNoZWNrIGZ1bmN0aW9uCj4gPiAJLSBEb24ndCByZW1vdmUg RklYTUUgYmxvY2sgYW5kIHBzcjIuc3VwcG9ydCBjaGVjay4KPiA+IAktIEFkZCBhIGRlYnVnIG1l c3NhZ2UgdG8gc2hvdyB1cyB3aGF0IFBTUiBvciBQU1IyIGlzCj4gPiAJICBnZXR0aW5nIGVuYWJs ZWQgbm93IHdlIGhhdmUgd2F5cyB0byBlbmFibGVkIFBTUiBvbgo+ID4gCSAgUFNSMiBwYW5lbHMu Cj4gPiAJLSBzL1BTUjIgZGlzYWJsZWQvUFNSMiBub3QgZW5hYmxlZAo+ID4gCj4gPiBDYzogRGhp bmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gPiBTaWdu ZWQtb2ZmLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4gCj4gUmV2 aWV3ZWQtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwu Y29tPgoKbWVyZ2VkLCB0aGFua3MuCgo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcHNyLmMgfCA2NCArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0t LS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDM3IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9ucygt KQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gaW5kZXggMmY2ODViZWFjMjFi Li4wNTc3MDc5MGE0ZTkgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9wc3IuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+IEBA IC00NDYsNiArNDQ2LDQxIEBAIHN0YXRpYyB2b2lkIGhzd19wc3JfYWN0aXZhdGUoc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCkKPiA+ICAJCWhzd19hY3RpdmF0ZV9wc3IxKGludGVsX2RwKTsKPiA+ ICB9Cj4gPiAgCj4gPiArc3RhdGljIGJvb2wgaW50ZWxfcHNyMl9jb25maWdfdmFsaWQoc3RydWN0 IGludGVsX2RwICppbnRlbF9kcCwKPiA+ICsJCQkJICAgIHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlKQo+ID4gK3sKPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGln X3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gPiArCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtPmJhc2UuYmFzZS5kZXYpOwo+ID4g Kwljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqYWRqdXN0ZWRfbW9kZSA9Cj4gPiArCQkm Y3J0Y19zdGF0ZS0+YmFzZS5hZGp1c3RlZF9tb2RlOwo+ID4gKwo+ID4gKwkvKgo+ID4gKwkgKiBG SVhNRSBwc3IyX3N1cHBvcnQgaXMgbWVzc2VkIHVwLiBJdCdzIGJvdGggY29tcHV0ZWQKPiA+ICsJ ICogZHluYW1pY2FsbHkgZHVyaW5nIFBTUiBlbmFibGUsIGFuZCBleHRyYWN0ZWQgZnJvbSBzaW5r Cj4gPiArCSAqIGNhcHMgZHVyaW5nIGVEUCBkZXRlY3Rpb24uCj4gPiArCSAqLwo+ID4gKwlpZiAo IWRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0KQo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gKwo+ ID4gKwkvKiBQU1IyIGlzIHJlc3RyaWN0ZWQgdG8gd29yayB3aXRoIHBhbmVsIHJlc29sdXRpb25z IHVwIHRvIDM2NDB4MjMwNCAqLwo+ID4gKwlpZiAoYWRqdXN0ZWRfbW9kZS0+Y3J0Y19oZGlzcGxh eSA+IDM2NDAgfHwKPiA+ICsJICAgIGFkanVzdGVkX21vZGUtPmNydGNfdmRpc3BsYXkgPiAyMzA0 KSB7Cj4gPiArCQlEUk1fREVCVUdfS01TKCJQU1IyIG5vdCBlbmFibGVkLCBwYW5lbCByZXNvbHV0 aW9uIHRvbyBiaWdcbiIpOwo+ID4gKwkJcmV0dXJuIGZhbHNlOwo+ID4gKwl9Cj4gPiArCj4gPiAr CS8qCj4gPiArCSAqIEZJWE1FOmVuYWJsZSBwc3IyIG9ubHkgZm9yIHktY29yZGluYXRlIHBzcjIg cGFuZWxzCj4gPiArCSAqIEFmdGVyIGd0YyBpbXBsZW1lbnRhdGlvbiAsIHJlbW92ZSB0aGlzIHJl c3RyaWN0aW9uLgo+ID4gKwkgKi8KPiA+ICsJaWYgKCFkZXZfcHJpdi0+cHNyLnlfY29yZF9zdXBw b3J0KSB7Cj4gPiArCQlEUk1fREVCVUdfS01TKCJQU1IyIG5vdCBlbmFibGVkLCBwYW5lbCBkb2Vz IG5vdCBzdXBwb3J0IFkgY29vcmRpbmF0ZVxuIik7Cj4gPiArCQlyZXR1cm4gZmFsc2U7Cj4gPiAr CX0KPiA+ICsKPiA+ICsJcmV0dXJuIHRydWU7Cj4gPiArfQo+ID4gKwo+ID4gIHZvaWQgaW50ZWxf cHNyX2NvbXB1dGVfY29uZmlnKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsCj4gPiAgCQkJICAg ICAgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gPiAgewo+ID4gQEAgLTUx MywzNCArNTQ4LDkgQEAgdm9pZCBpbnRlbF9wc3JfY29tcHV0ZV9jb25maWcoc3RydWN0IGludGVs X2RwICppbnRlbF9kcCwKPiA+ICAJCXJldHVybjsKPiA+ICAJfQo+ID4gIAo+ID4gLQkvKgo+ID4g LQkgKiBGSVhNRSBwc3IyX3N1cHBvcnQgaXMgbWVzc2VkIHVwLiBJdCdzIGJvdGggY29tcHV0ZWQK PiA+IC0JICogZHluYW1pY2FsbHkgZHVyaW5nIFBTUiBlbmFibGUsIGFuZCBleHRyYWN0ZWQgZnJv bSBzaW5rCj4gPiAtCSAqIGNhcHMgZHVyaW5nIGVEUCBkZXRlY3Rpb24uCj4gPiAtCSAqLwo+ID4g LQlpZiAoIWRldl9wcml2LT5wc3IucHNyMl9zdXBwb3J0KSB7Cj4gPiAtCQljcnRjX3N0YXRlLT5o YXNfcHNyID0gdHJ1ZTsKPiA+IC0JCXJldHVybjsKPiA+IC0JfQo+ID4gLQo+ID4gLQkvKiBQU1Iy IGlzIHJlc3RyaWN0ZWQgdG8gd29yayB3aXRoIHBhbmVsIHJlc29sdXRpb25zIHVwIHRvIDM2NDB4 MjMwNCAqLwo+ID4gLQlpZiAoYWRqdXN0ZWRfbW9kZS0+Y3J0Y19oZGlzcGxheSA+IDM2NDAgfHwK PiA+IC0JICAgIGFkanVzdGVkX21vZGUtPmNydGNfdmRpc3BsYXkgPiAyMzA0KSB7Cj4gPiAtCQlE Uk1fREVCVUdfS01TKCJQU1IyIGRpc2FibGVkLCBwYW5lbCByZXNvbHV0aW9uIHRvbyBiaWdcbiIp Owo+ID4gLQkJcmV0dXJuOwo+ID4gLQl9Cj4gPiAtCj4gPiAtCS8qCj4gPiAtCSAqIEZJWE1FOmVu YWJsZSBwc3IyIG9ubHkgZm9yIHktY29yZGluYXRlIHBzcjIgcGFuZWxzCj4gPiAtCSAqIEFmdGVy IGd0YyBpbXBsZW1lbnRhdGlvbiAsIHJlbW92ZSB0aGlzIHJlc3RyaWN0aW9uLgo+ID4gLQkgKi8K PiA+IC0JaWYgKCFkZXZfcHJpdi0+cHNyLnlfY29yZF9zdXBwb3J0KSB7Cj4gPiAtCQlEUk1fREVC VUdfS01TKCJQU1IyIGRpc2FibGVkLCBwYW5lbCBkb2VzIG5vdCBzdXBwb3J0IFkgY29vcmRpbmF0 ZVxuIik7Cj4gPiAtCQlyZXR1cm47Cj4gPiAtCX0KPiA+IC0KPiA+ICAJY3J0Y19zdGF0ZS0+aGFz X3BzciA9IHRydWU7Cj4gPiAtCWNydGNfc3RhdGUtPmhhc19wc3IyID0gdHJ1ZTsKPiA+ICsJY3J0 Y19zdGF0ZS0+aGFzX3BzcjIgPSBpbnRlbF9wc3IyX2NvbmZpZ192YWxpZChpbnRlbF9kcCwgY3J0 Y19zdGF0ZSk7Cj4gPiArCURSTV9ERUJVR19LTVMoIkVuYWJsaW5nIFBTUiVzXG4iLCBjcnRjX3N0 YXRlLT5oYXNfcHNyMiA/ICIyIiA6ICIiKTsKPiA+ICB9Cj4gPiAgCj4gPiAgc3RhdGljIHZvaWQg aW50ZWxfcHNyX2FjdGl2YXRlKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=