From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2] drm/panel: simple: Add TVC S9700RTWV43TR-01B 800x480 panel support Date: Wed, 28 Feb 2018 19:44:55 +0100 Message-ID: <20180228184453.GA22932@mithrandir> References: <1519814443-29147-1-git-send-email-jsarha@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1365165780==" Return-path: Received: from mail-wr0-x241.google.com (mail-wr0-x241.google.com [IPv6:2a00:1450:400c:c0c::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9CCC76E12B for ; Wed, 28 Feb 2018 18:44:53 +0000 (UTC) Received: by mail-wr0-x241.google.com with SMTP id l43so3525644wrc.2 for ; Wed, 28 Feb 2018 10:44:53 -0800 (PST) In-Reply-To: <1519814443-29147-1-git-send-email-jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha Cc: airlied@linux.ie, tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1365165780== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LQksG6bCIzRHxTLp" Content-Disposition: inline --LQksG6bCIzRHxTLp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 28, 2018 at 12:40:43PM +0200, Jyri Sarha wrote: > Add support for TVC S9700RTWV43TR-01B 800x480 panel found on TI's > AM335X-EVM. >=20 > Signed-off-by: Jyri Sarha > Reviewed-by: Tomi Valkeinen > --- > The only change is added "Reviewed-by: Tomi Valkeinen ". > Who is going to pick this up? >=20 > The first version of the patch can be found here: > https://lists.freedesktop.org/archives/dri-devel/2018-February/166902.html >=20 > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) >=20 > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel= /panel-simple.c > index 5591984..3b0ba9f 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1962,6 +1962,29 @@ static const struct panel_desc tpk_f10a_0102 =3D { > }, > }; > =20 > +static const struct drm_display_mode tvc_s9700rtwv43tr_01b_mode =3D { > + .clock =3D 3000, This seems to be missing a 0. Does the panel even work with 3 MHz? I'd be somewhat surprised if it did. Thierry --LQksG6bCIzRHxTLp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlqW+JoACgkQ3SOs138+ s6Hk8xAAu6dErCpJrlkgjfdoa7LJmq/sPqo9X0vW8HclXoQWk5CtYxmUTBwXnWo7 oYO0K38qymdvtDIbg6gxB1f+No9uqfohfwjEy3QP8sqY4BLqUTkjyCXLB3D7xkNb d6RJthXDWY8eWRC5KDw0ijF5frkvH1Lezy9CMR7zKUBXzw/dg2MjhKmNAeEQXE1d BfplOMN7aHLvCzDaRAktXeS9HU9Fi2m+VLqy0i4wskkUQJS09pUzojG+EpTffitM dyDsbu+lJYyPOxPtrnC/YITITdar0GN9ZSRILfYyyM6i/A/StXCWW8+52k5nXiDl 6ZzBWzB3auY/5D9MRpMhXfkTb+Eh9488ofqlzISuwUlam/5rrsQJIJGrbs0eV0un JfUqB8HzQGxXIDk9pF2KFzvxcpcdJFlemnLBDoAAPbyi3QFpyaMrUXam8KM12o8X AbJWkRyITSChfIH/c1nBvaw0/agvBbQpHkjQtenzSRjRMM40eNvSmm8DKhzvJyyO PrbVhrjXgsW4tKg5OebfCpY3Lmz8hzCrrtjbzDvR+BRNo1NKdf5alwP35RMcfwjh 7KBdL/jVhebFBOQrfhpnqgNZNEz3IahwU0burwBTTk+WmTQ+44zAp1ReSPGaJ6Uc C1TOS8jtrlxElGT2FB/HzDN91RVDokdUuvqDHgbe8Brki2z1+QM= =5mF5 -----END PGP SIGNATURE----- --LQksG6bCIzRHxTLp-- --===============1365165780== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1365165780==--