From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH v2 1/2] drm/panel: Remove drm_panel_detach() calls from all panel drives Date: Wed, 28 Feb 2018 19:53:00 +0100 Message-ID: <20180228185259.GB22932@mithrandir> References: <94922d2b5feed117354b5c0a42b4b56f643f73d9.1519815150.git.jsarha@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1461682406==" Return-path: Received: from mail-wr0-x242.google.com (mail-wr0-x242.google.com [IPv6:2a00:1450:400c:c0c::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A5926EB2B for ; Wed, 28 Feb 2018 19:00:59 +0000 (UTC) Received: by mail-wr0-x242.google.com with SMTP id f14so3548631wre.8 for ; Wed, 28 Feb 2018 11:00:59 -0800 (PST) In-Reply-To: <94922d2b5feed117354b5c0a42b4b56f643f73d9.1519815150.git.jsarha@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha Cc: airlied@linux.ie, tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1461682406== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BwCQnh7xodEAoBMC" Content-Disposition: inline --BwCQnh7xodEAoBMC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 28, 2018 at 01:09:29PM +0200, Jyri Sarha wrote: > Setting the connector and drm to NULL when the drm panel device is > going away hardly serves any purpose. Usually the the whole memory > stucture is freed right after the remove call. >=20 > Signed-off-by: Jyri Sarha > --- > drivers/gpu/drm/panel/panel-innolux-p079zca.c | 1 - > drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 1 - > drivers/gpu/drm/panel/panel-lvds.c | 1 - > drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 1 - > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 1 - > drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 1 - > drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 1 - > drivers/gpu/drm/panel/panel-simple.c | 1 - > drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 1 - > 9 files changed, 9 deletions(-) I don't understand the purpose of this patch. I'll grant you that the current implementation of drm_panel_detach() is not very useful, but then you add code to drm_panel_detach() in the next patch and mention in the commit message that panel drivers should be calling the drm_panel_detach() function to remove the link. This is confusing. Can you clarify? Thierry --BwCQnh7xodEAoBMC Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAlqW+osACgkQ3SOs138+ s6EdkhAAlSK7Ux1/I65+LDhdZCadxsyOfXHiViU+sXdOXMpDqHxfRSa+dzGDDauG /+2DysLN3AJ9MBtSVUWMmh7eZNQtgrNmRxpqNcQ8d+6Pr5gSzJUqOzqhHkA7JpH2 BlznnVxWIbuWLZL1sX8RDav2wXtSFE3DhtPt1+OcU2yB05U8dRe5a1dqg0BKnk/L 2RDj0YALg3q/92Zt6q6SbUrZFR99lMHc1IixdjJGprPrm+2lF9RiL5yievKDoBec FiOAauO0NSr9qi1swIIIGle3IR1f+svE/2uzvEi8YVg50sIl4GATDOBMeXhHIN+7 MmxOPv3aijzNd+hKBx9PZeJ7QAIEiYlwFDgsgtVu2JsZQ0avg+XW06jpDMv3h5pk naEFv0k6ENTSMVsg4ESA2jLXiYuMimYMWI9oWeyaP2n2moYJMnKwaXTjkkLtNSr5 FJa611BlAku5S+niF30v/20IDXTbyAwvC//yi0G/kkl4eQfFRAKBNjSYR5iCwWYr 5H91+s1NlhrekG1JrgJV3Kg082kUpvYaLYNS1vF/RmaGehDFOerYDvP5lxlP0FNz 4jIIwi0lEGlJRxb5Jd+9V3hwpzzLa6jWiuTDyHYn051nlzyK04GOJNPjVyGByTmO idKKS1V/oZlQ+CWkJca8Y18XE1au/4yWaBDxwoth5KQXPqE9JmI= =xuFe -----END PGP SIGNATURE----- --BwCQnh7xodEAoBMC-- --===============1461682406== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1461682406==--