From: "Michael S. Tsirkin" <mst@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, bhe@redhat.com,
slp@redhat.com, somlo@cmu.edu, xiaolong.ye@intel.com
Subject: Re: [PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error
Date: Wed, 28 Feb 2018 19:32:53 +0200 [thread overview]
Message-ID: <20180228193142-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180228150615.17317-7-marcandre.lureau@redhat.com>
> @@ -557,7 +566,10 @@ static int fw_cfg_sysfs_probe(struct platform_device *pdev)
> goto err_probe;
>
> /* get revision number, add matching top-level attribute */
> - fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev));
> + err = fw_cfg_read_blob(FW_CFG_ID, &rev, 0, sizeof(rev));
> + if (err < 0)
> + goto err_probe;
> +
> fw_cfg_rev = le32_to_cpu(rev);
> err = sysfs_create_file(fw_cfg_top_ko, &fw_cfg_rev_attr.attr);
> if (err)
So on this one, maybe we should just drop this attribute.
Does anyone use it?
Removing it will speed up boot slightly.
> --
> 2.16.1.73.g5832b7e9f2
next prev parent reply other threads:[~2018-02-28 17:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 15:06 [PATCH v16 00/11] fw_cfg: add DMA operations & etc/vmcoreinfo support Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 01/11] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness() Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 02/11] fw_cfg: fix sparse warnings with fw_cfg_file Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 03/11] fw_cfg: fix sparse warning reading FW_CFG_ID Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 04/11] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 05/11] fw_cfg: remove inline from fw_cfg_read_blob() Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error Marc-André Lureau
2018-02-28 17:32 ` Michael S. Tsirkin [this message]
2018-03-01 11:36 ` Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 07/11] fw_cfg: add a public uapi header Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 08/11] fw_cfg: add DMA register Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note() Marc-André Lureau
2018-03-02 2:32 ` Dave Young
2018-03-02 18:03 ` Michael S. Tsirkin
2018-03-02 18:09 ` Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 10/11] fw_cfg: write vmcoreinfo details Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 11/11] RFC: fw_cfg: do DMA read operation Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228193142-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=slp@redhat.com \
--cc=somlo@cmu.edu \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.