From: Max Filippov <jcmvbkbc@gmail.com>
To: qemu-devel@nongnu.org
Cc: Max Filippov <jcmvbkbc@gmail.com>,
qemu-stable@nongnu.org, Riku Voipio <riku.voipio@iki.fi>,
Laurent Vivier <laurent@vivier.eu>
Subject: [Qemu-devel] [PATCH 07/11] linux-user: fix target_mprotect/target_munmap error return values
Date: Wed, 28 Feb 2018 13:06:12 -0800 [thread overview]
Message-ID: <20180228210616.2756-8-jcmvbkbc@gmail.com> (raw)
In-Reply-To: <20180228210616.2756-1-jcmvbkbc@gmail.com>
target_mprotect/target_munmap return value goes through get_errno at the
call site, thus the functions must either set errno to host error code
and return -1 or return negative guest error code. Do the latter.
Cc: qemu-stable@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>
Cc: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
linux-user/mmap.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index df81f9b803b6..84b15c9a1699 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -77,11 +77,11 @@ int target_mprotect(abi_ulong start, abi_ulong len, int prot)
#endif
if ((start & ~TARGET_PAGE_MASK) != 0)
- return -EINVAL;
+ return -TARGET_EINVAL;
len = TARGET_PAGE_ALIGN(len);
end = start + len;
if (!guest_range_valid(start, len)) {
- return -ENOMEM;
+ return -TARGET_ENOMEM;
}
prot &= PROT_READ | PROT_WRITE | PROT_EXEC;
if (len == 0)
@@ -621,10 +621,10 @@ int target_munmap(abi_ulong start, abi_ulong len)
start, len);
#endif
if (start & ~TARGET_PAGE_MASK)
- return -EINVAL;
+ return -TARGET_EINVAL;
len = TARGET_PAGE_ALIGN(len);
if (len == 0 || !guest_range_valid(start, len)) {
- return -EINVAL;
+ return -TARGET_EINVAL;
}
mmap_lock();
--
2.11.0
next prev parent reply other threads:[~2018-02-28 21:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 21:06 [Qemu-devel] [PATCH 00/11] linux-user support for target/xtensa Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 01/11] target/xtensa: dump correct physical registers Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 02/11] target/xtensa: mark register windows in the dump Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 03/11] target/xtensa: use correct number of registers in gdbstub Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 04/11] target/xtensa: support MTTCG Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 05/11] linux-user: fix mmap/munmap/mprotect/mremap/shmat Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 06/11] linux-user: fix assertion in shmdt Max Filippov
2018-02-28 21:06 ` Max Filippov [this message]
2018-02-28 21:06 ` [Qemu-devel] [PATCH 08/11] linux-user: drop unused target_msync function Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 09/11] target/xtensa: add linux-user support Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 10/11] qemu-binfmt-conf.sh: add qemu-xtensa Max Filippov
2018-02-28 21:06 ` [Qemu-devel] [PATCH 11/11] MAINTAINERS: fix W: address for xtensa Max Filippov
2018-02-28 21:27 ` [Qemu-devel] [PATCH 00/11] linux-user support for target/xtensa no-reply
2018-02-28 21:51 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228210616.2756-8-jcmvbkbc@gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.