From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Date: Wed, 28 Feb 2018 19:46:10 -0800 Message-ID: <20180301034610.GC62820@atomide.com> References: <20180217210723.7013-1-tony@atomide.com> <20180219204029.xrftbbxvdfxlf7jh@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20180219204029.xrftbbxvdfxlf7jh@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Sebastian Reichel List-Id: linux-omap@vger.kernel.org * Rob Herring [180219 20:41]: > On Sat, Feb 17, 2018 at 01:07:23PM -0800, Tony Lindgren wrote: > > The GPIOs controlling MDM6600 are used to power MDM660 on and off, to > > MDM660 a typo? Thanks fixing. > > +Required properties: > > +- compatible Must be "motorola,mapphone-mdm6600" > > +- enable-gpios GPIO to enable the USB PHY > > +- power-gpios GPIO to power on the device > > +- reset-gpios GPIO to reset the device > > The are pretty standard, but... > > > +- mode-gpios Two GPIOs to configure MDM6600 USB start-up mode for > > + normal mode versus USB flashing mode > > +- status-gpios Three GPIOs to read the power state of the MDM6600 > > +- cmd-gpios Three GPIOs to control the power state of the MDM6600 > > These 3 should have vendor a prefix. OK > > + > > +Example: > > + > > +fsusb1_phy: fsusb1_phy { > > usb-phy { Thanks will send out an updated version shortly. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 From: Tony Lindgren Message-Id: <20180301034610.GC62820@atomide.com> Date: Wed, 28 Feb 2018 19:46:10 -0800 To: Rob Herring Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Sebastian Reichel List-ID: KiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPiBbMTgwMjE5IDIwOjQxXToKPiBPbiBTYXQs IEZlYiAxNywgMjAxOCBhdCAwMTowNzoyM1BNIC0wODAwLCBUb255IExpbmRncmVuIHdyb3RlOgo+ ID4gVGhlIEdQSU9zIGNvbnRyb2xsaW5nIE1ETTY2MDAgYXJlIHVzZWQgdG8gcG93ZXIgTURNNjYw IG9uIGFuZCBvZmYsIHRvCj4gCj4gTURNNjYwIGEgdHlwbz8KClRoYW5rcyBmaXhpbmcuCgo+ID4g K1JlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPiArLSBjb21wYXRpYmxlCU11c3QgYmUgIm1vdG9yb2xh LG1hcHBob25lLW1kbTY2MDAiCj4gPiArLSBlbmFibGUtZ3Bpb3MJR1BJTyB0byBlbmFibGUgdGhl IFVTQiBQSFkKPiA+ICstIHBvd2VyLWdwaW9zCUdQSU8gdG8gcG93ZXIgb24gdGhlIGRldmljZQo+ ID4gKy0gcmVzZXQtZ3Bpb3MJR1BJTyB0byByZXNldCB0aGUgZGV2aWNlCj4gCj4gVGhlIGFyZSBw cmV0dHkgc3RhbmRhcmQsIGJ1dC4uLgo+IAo+ID4gKy0gbW9kZS1ncGlvcwlUd28gR1BJT3MgdG8g Y29uZmlndXJlIE1ETTY2MDAgVVNCIHN0YXJ0LXVwIG1vZGUgZm9yCj4gPiArCQlub3JtYWwgbW9k ZSB2ZXJzdXMgVVNCIGZsYXNoaW5nIG1vZGUKPiA+ICstIHN0YXR1cy1ncGlvcwlUaHJlZSBHUElP cyB0byByZWFkIHRoZSBwb3dlciBzdGF0ZSBvZiB0aGUgTURNNjYwMAo+ID4gKy0gY21kLWdwaW9z CVRocmVlIEdQSU9zIHRvIGNvbnRyb2wgdGhlIHBvd2VyIHN0YXRlIG9mIHRoZSBNRE02NjAwCj4g Cj4gVGhlc2UgMyBzaG91bGQgaGF2ZSB2ZW5kb3IgYSBwcmVmaXguCgpPSwoKPiA+ICsKPiA+ICtF eGFtcGxlOgo+ID4gKwo+ID4gK2ZzdXNiMV9waHk6IGZzdXNiMV9waHkgewo+IAo+IHVzYi1waHkg ewoKVGhhbmtzIHdpbGwgc2VuZCBvdXQgYW4gdXBkYXRlZCB2ZXJzaW9uIHNob3J0bHkuCgpSZWdh cmRzLAoKVG9ueQotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxp bmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1h am9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3Zn ZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==