From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 2/9] dumb-init: new package
Date: Thu, 1 Mar 2018 10:02:27 +0100 [thread overview]
Message-ID: <20180301100227.3fb09c06@windsurf.lan> (raw)
In-Reply-To: <20180301072012.25884-3-christian@paral.in>
Hello Christian,
On Thu, 1 Mar 2018 02:20:05 -0500, Christian Stewart wrote:
> diff --git a/package/dumb-init/Config.in b/package/dumb-init/Config.in
> new file mode 100644
> index 0000000000..e817493605
> --- /dev/null
> +++ b/package/dumb-init/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_DUMB_INIT
> + bool "dumb-init"
> + help
> + dumb-init is a simple but valid init binary to
> + act as PID 1 for containers.
> +
> + https://github.com/Yelp/dumb-init
> diff --git a/package/dumb-init/dumb-init.hash b/package/dumb-init/dumb-init.hash
> new file mode 100644
> index 0000000000..4705ce4368
> --- /dev/null
> +++ b/package/dumb-init/dumb-init.hash
> @@ -0,0 +1,2 @@
> +# Locally computed
> +sha256 74486997321bd939cad2ee6af030f481d39751bc9aa0ece84ed55f864e309a3f v1.2.0.tar.gz
Argh, what an annoying name for the tarball :-/
Could you add an entry with the hash of the license file ?
> diff --git a/package/dumb-init/dumb-init.mk b/package/dumb-init/dumb-init.mk
> new file mode 100644
> index 0000000000..3133384f5a
> --- /dev/null
> +++ b/package/dumb-init/dumb-init.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# dumb-init
> +#
> +################################################################################
> +
> +DUMB_INIT_VERSION = v1.2.0
> +DUMB_INIT_SITE = $(call github,Yelp,dumb-init,$(DUMB_INIT_VERSION))
> +
> +DUMB_INIT_LICENSE = MIT
> +DUMB_INIT_LICENSE_FILES = LICENSE
> +DUMB_INIT_CFLAGS += -static
This should be:
DUMB_INIT_CFLAGS = $(TARGET_CFLAGS) -static
with a comment above it that explains why we are forcing -static.
However, using -static has a problem: what happens when you're doing a
BR2_SHARED_LIBS=y configuration, i.e when there is only support for
shared libraries, and not static libraries ? And BR2_SHARED_LIBS=y is
our default.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-03-01 9:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 7:20 [Buildroot] [PATCH v2 0/9] upgrade docker-engine and associated components Christian Stewart
2018-03-01 7:20 ` [Buildroot] [PATCH v2 1/9] tini: new package Christian Stewart
2018-03-01 7:20 ` [Buildroot] [PATCH v2 2/9] dumb-init: " Christian Stewart
2018-03-01 9:02 ` Thomas Petazzoni [this message]
2018-03-01 15:51 ` Peter Korsgaard
2018-03-01 16:08 ` Thomas Petazzoni
2018-03-01 17:21 ` Peter Korsgaard
2018-03-01 22:04 ` Thomas Petazzoni
2018-03-01 22:23 ` Yann E. MORIN
2018-03-01 23:02 ` Baruch Siach
2018-03-03 22:10 ` Yann E. MORIN
2018-03-01 22:32 ` Peter Korsgaard
2018-03-01 17:58 ` Christian Stewart
2018-03-01 7:20 ` [Buildroot] [PATCH v2 3/9] docker-engine: add support for init processes Christian Stewart
2018-03-01 7:20 ` [Buildroot] [PATCH v2 4/9] docker-engine: select static for tini and dumb-init Christian Stewart
2018-03-01 8:59 ` Thomas Petazzoni
2018-03-01 15:52 ` Peter Korsgaard
2018-03-01 17:59 ` Christian Stewart
2018-03-01 7:20 ` [Buildroot] [PATCH v2 5/9] docker-proxy: new package Christian Stewart
2018-03-30 21:30 ` Peter Korsgaard
2018-03-01 7:20 ` [Buildroot] [PATCH v2 6/9] docker-engine: add dependency on docker-proxy Christian Stewart
2018-03-30 21:30 ` Peter Korsgaard
2018-03-01 7:20 ` [Buildroot] [PATCH v2 7/9] runc: bump to 9f9c96235cc Christian Stewart
2018-03-01 7:20 ` [Buildroot] [PATCH v2 8/9] docker-containerd: bump to v1.0.2 Christian Stewart
2018-03-01 7:20 ` [Buildroot] [PATCH v2 9/9] docker-engine: bump to v18.03.0-ce-rc1 Christian Stewart
2018-03-01 10:15 ` [Buildroot] [PATCH v2 0/9] upgrade docker-engine and associated components Peter Korsgaard
2018-03-01 17:54 ` Christian Stewart
2018-03-01 18:15 ` Peter Korsgaard
2018-03-01 19:06 ` Christian Stewart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301100227.3fb09c06@windsurf.lan \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.