From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sn1nam02on0104.outbound.protection.outlook.com ([104.47.36.104]:45334 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1032418AbeCAPhH (ORCPT ); Thu, 1 Mar 2018 10:37:07 -0500 From: Sasha Levin To: "stable@vger.kernel.org" , "stable-commits@vger.kernel.org" CC: Nogah Frankel , "David S . Miller" , Sasha Levin Subject: [added to the 4.1 stable tree] net_sched: red: Avoid devision by zero Date: Thu, 1 Mar 2018 15:26:57 +0000 Message-ID: <20180301152116.1486-415-alexander.levin@microsoft.com> References: <20180301152116.1486-1-alexander.levin@microsoft.com> In-Reply-To: <20180301152116.1486-1-alexander.levin@microsoft.com> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: From: Nogah Frankel This patch has been added to the 4.1 stable tree. If you have any objections, please let us know. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D [ Upstream commit 5c472203421ab4f928aa1ae9e1dbcfdd80324148 ] Do not allow delta value to be zero since it is used as a divisor. Fixes: 8af2a218de38 ("sch_red: Adaptative RED AQM") Signed-off-by: Nogah Frankel Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- include/net/red.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/red.h b/include/net/red.h index 76e0b5f922c6..ba5039418a93 100644 --- a/include/net/red.h +++ b/include/net/red.h @@ -178,7 +178,7 @@ static inline void red_set_parms(struct red_parms *p, p->qth_max =3D qth_max << Wlog; p->Wlog =3D Wlog; p->Plog =3D Plog; - if (delta < 0) + if (delta <=3D 0) delta =3D 1; p->qth_delta =3D delta; if (!max_P) { --=20 2.14.1