From: Denys Dmytriyenko <denys@ti.com>
To: Jacob Stiffler <j-stiffler@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [tisdk-setup-scripts][PATCH] setup-package-install: select u-boot-tools for Ubuntu 16.04
Date: Thu, 1 Mar 2018 14:00:20 -0500 [thread overview]
Message-ID: <20180301190020.GN22424@edge> (raw)
In-Reply-To: <1519916131-7750-1-git-send-email-j-stiffler@ti.com>
ACK
On Thu, Mar 01, 2018 at 09:55:31AM -0500, Jacob Stiffler wrote:
> And fix potential issue in detection of required package status as
> "dpkg-query -l" will list matching packages available on the system,
> but not the intallation status as "dpkg-query -s" does.
>
> Signed-off-by: Jacob Stiffler <j-stiffler@ti.com>
> ---
> setup-package-install.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/setup-package-install.sh b/setup-package-install.sh
> index 1ef94f9..c5c134f 100644
> --- a/setup-package-install.sh
> +++ b/setup-package-install.sh
> @@ -63,7 +63,7 @@ get_host_type host
> # Starting with Ubuntu 14.04 the package name for uboot-mkimage has changed
> # to u-boot-tools
>
> -if [ "$host" = "trusty" ]; then
> +if [ "$host" = "trusty" -o "$host" = "xenial" ]; then
> packages_to_install="$packages_to_install u-boot-tools"
> else
> packages_to_install="$packages_to_install uboot-mkimage"
> @@ -74,7 +74,7 @@ cmd="sudo apt-get install "
>
> # Check and only install the missing packages
> for i in $packages_to_install; do
> - is_it_installed=`dpkg-query -l $i 2>/dev/null`
> + is_it_installed=`dpkg-query -s $i 2>/dev/null`
> if [ "$?" -ne "0" ]; then
> needs_installation=`echo $needs_installation`" "$i
> new_cmd=`echo $cmd`" "$i
> --
> 1.9.1
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
prev parent reply other threads:[~2018-03-01 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 14:55 [tisdk-setup-scripts][PATCH] setup-package-install: select u-boot-tools for Ubuntu 16.04 Jacob Stiffler
2018-03-01 19:00 ` Denys Dmytriyenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301190020.GN22424@edge \
--to=denys@ti.com \
--cc=j-stiffler@ti.com \
--cc=meta-arago@arago-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.