From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: don't start out with the exclusive ilock for direct I/O
Date: Fri, 2 Mar 2018 09:02:31 +1100 [thread overview]
Message-ID: <20180301220231.GM30854@dastard> (raw)
In-Reply-To: <20180228174552.31919-3-hch@lst.de>
On Wed, Feb 28, 2018 at 09:45:51AM -0800, Christoph Hellwig wrote:
> There is no reason to take the ilock exclusively at the start of
> xfs_file_iomap_begin for direct I/O, given that it will be demoted
> just before calling xfs_iomap_write_direct anyway.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Seems to work fine, and reverts us back to the per-iomap behaviour.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2018-03-01 22:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 17:45 iomap fixes Christoph Hellwig
2018-02-28 17:45 ` [PATCH 1/3] xfs: don't allocate COW blocks for zeroing holes or unwritten extents Christoph Hellwig
2018-03-01 22:01 ` Dave Chinner
2018-03-01 22:28 ` Darrick J. Wong
2018-02-28 17:45 ` [PATCH 2/3] xfs: don't start out with the exclusive ilock for direct I/O Christoph Hellwig
2018-03-01 22:02 ` Dave Chinner [this message]
2018-02-28 17:45 ` [PATCH 3/3] xfs: don't block on the ilock for RWF_NOWAIT Christoph Hellwig
2018-03-01 22:04 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301220231.GM30854@dastard \
--to=david@fromorbit.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.