From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v2 net-next 5/5] net: dsa: mv88e6xxx: Get mv88e6352 SERDES statistics
Date: Fri, 2 Mar 2018 04:10:53 +0100 [thread overview]
Message-ID: <20180302031053.GC12656@lunn.ch> (raw)
In-Reply-To: <1519866151-13419-6-git-send-email-andrew@lunn.ch>
> +void mv88e6352_serdes_get_strings(struct mv88e6xxx_chip *chip,
> + int port, uint8_t *data)
> +{
> + struct mv88e6352_serdes_hw_stat *stat;
> + int i;
> +
> + if (!mv88e6352_port_has_serdes(chip, port))
> + return;
> +
> + for (i = 0; i < ARRAY_SIZE(mv88e6352_serdes_hw_stats); i++) {
> + stat = &mv88e6352_serdes_hw_stats[i];
> + memcpy(data + i * ETH_GSTRING_LEN, stat->string,
> + ETH_GSTRING_LEN);
This has the same problem as Florain just fixed, using memcpy instead
of strcnpy. I will spin a new version with this fixed.
Andrew
next prev parent reply other threads:[~2018-03-02 3:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 1:02 [PATCH v2 net-next 0/5] Export SERDES stats via ethtool -S Andrew Lunn
2018-03-01 1:02 ` [PATCH v2 net-next 1/5] dsa: Pass the port to get_sset_count() Andrew Lunn
2018-03-01 1:02 ` [PATCH v2 net-next 2/5] net: dsa: mv88e6xxx: Hold mutex while doing stats operations Andrew Lunn
2018-03-01 1:02 ` [PATCH v2 net-next 3/5] net: dsa: mv88e6xxx: Allow the SERDES interfaces to have statistics Andrew Lunn
2018-03-01 1:02 ` [PATCH v2 net-next 4/5] net: dsa: mv88e6xxx: Add helper to determining if port has SERDES Andrew Lunn
2018-03-01 1:02 ` [PATCH v2 net-next 5/5] net: dsa: mv88e6xxx: Get mv88e6352 SERDES statistics Andrew Lunn
2018-03-02 3:10 ` Andrew Lunn [this message]
2018-03-04 18:48 ` Florian Fainelli
2018-03-04 18:35 ` [PATCH v2 net-next 0/5] Export SERDES stats via ethtool -S David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302031053.GC12656@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.