From mboxrd@z Thu Jan 1 00:00:00 1970 From: ville.syrjala@linux.intel.com (Ville =?iso-8859-1?Q?Syrj=E4l=E4?=) Date: Fri, 2 Mar 2018 10:07:08 +0200 Subject: [PATCH] drm/bridge: sii902x: Fall back to standard modes In-Reply-To: References: <20180214130059.19052-1-linus.walleij@linaro.org> <20180301211840.GD5453@intel.com> Message-ID: <20180302080708.GF5453@intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 01, 2018 at 11:12:15PM +0100, Linus Walleij wrote: > On Thu, Mar 1, 2018 at 10:18 PM, Ville Syrj?l? > wrote: > > On Thu, Mar 01, 2018 at 10:02:55PM +0100, Linus Walleij wrote: > >> Hm, hard to get review feedback on this one. > >> > >> It gives me proper video on an ARM Versatile Express utilizing the > >> bridge driver with a plugged in DVI-to-VGA dongle with the new > >> PL111 DRI driver. > >> > >> Liviu? Pawel? > >> > >> Some ACK is fine to know I am doing the right thing :) > > > > Why isn't the probe helper's noedid fallback working? > > Where is that in the call chain? > > The problem I have is that the bridge is there, it gets properly > initialized and used as connector and all. The only problem is > that the DDI I2C portion of it is not working, so no modes are > really added from the struct drm_connector_helper_funcs > .get_modes() callback. The helper is what calls .get_modes(), and it has a noedid fallback for mode count==0. -- Ville Syrj?l? Intel OTC From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/bridge: sii902x: Fall back to standard modes Date: Fri, 2 Mar 2018 10:07:08 +0200 Message-ID: <20180302080708.GF5453@intel.com> References: <20180214130059.19052-1-linus.walleij@linaro.org> <20180301211840.GD5453@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 819126ED99 for ; Fri, 2 Mar 2018 08:07:13 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij Cc: Pawel Moll , Liviu Dudau , "open list:DRM PANEL DRIVERS" , Laurent Pinchart , Linux ARM List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBNYXIgMDEsIDIwMTggYXQgMTE6MTI6MTVQTSArMDEwMCwgTGludXMgV2FsbGVpaiB3 cm90ZToKPiBPbiBUaHUsIE1hciAxLCAyMDE4IGF0IDEwOjE4IFBNLCBWaWxsZSBTeXJqw6Rsw6QK PiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gT24gVGh1LCBNYXIg MDEsIDIwMTggYXQgMTA6MDI6NTVQTSArMDEwMCwgTGludXMgV2FsbGVpaiB3cm90ZToKPiA+PiBI bSwgaGFyZCB0byBnZXQgcmV2aWV3IGZlZWRiYWNrIG9uIHRoaXMgb25lLgo+ID4+Cj4gPj4gSXQg Z2l2ZXMgbWUgcHJvcGVyIHZpZGVvIG9uIGFuIEFSTSBWZXJzYXRpbGUgRXhwcmVzcyB1dGlsaXpp bmcgdGhlCj4gPj4gYnJpZGdlIGRyaXZlciB3aXRoIGEgcGx1Z2dlZCBpbiBEVkktdG8tVkdBIGRv bmdsZSB3aXRoIHRoZSBuZXcKPiA+PiBQTDExMSBEUkkgZHJpdmVyLgo+ID4+Cj4gPj4gTGl2aXU/ IFBhd2VsPwo+ID4+Cj4gPj4gU29tZSBBQ0sgaXMgZmluZSB0byBrbm93IEkgYW0gZG9pbmcgdGhl IHJpZ2h0IHRoaW5nIDopCj4gPgo+ID4gV2h5IGlzbid0IHRoZSBwcm9iZSBoZWxwZXIncyBub2Vk aWQgZmFsbGJhY2sgd29ya2luZz8KPiAKPiBXaGVyZSBpcyB0aGF0IGluIHRoZSBjYWxsIGNoYWlu Pwo+IAo+IFRoZSBwcm9ibGVtIEkgaGF2ZSBpcyB0aGF0IHRoZSBicmlkZ2UgaXMgdGhlcmUsIGl0 IGdldHMgcHJvcGVybHkKPiBpbml0aWFsaXplZCBhbmQgdXNlZCBhcyBjb25uZWN0b3IgYW5kIGFs bC4gVGhlIG9ubHkgcHJvYmxlbSBpcwo+IHRoYXQgdGhlIERESSBJMkMgcG9ydGlvbiBvZiBpdCBp cyBub3Qgd29ya2luZywgc28gbm8gbW9kZXMgYXJlCj4gcmVhbGx5IGFkZGVkIGZyb20gdGhlIHN0 cnVjdCBkcm1fY29ubmVjdG9yX2hlbHBlcl9mdW5jcwo+IC5nZXRfbW9kZXMoKSBjYWxsYmFjay4K ClRoZSBoZWxwZXIgaXMgd2hhdCBjYWxscyAuZ2V0X21vZGVzKCksIGFuZCBpdCBoYXMgYSBub2Vk aWQKZmFsbGJhY2sgZm9yIG1vZGUgY291bnQ9PTAuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK