From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: devel@driverdev.osuosl.org, wsa@the-dreams.de,
gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org,
Quytelda Kahja <quytelda@tamalin.org>
Subject: Re: [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()'.
Date: Fri, 2 Mar 2018 12:05:03 +0300 [thread overview]
Message-ID: <20180302090503.2zgnzhy5dtolmk3n@mwanda> (raw)
In-Reply-To: <20180301205436.GE4059@eros>
There are so many rules for kernel developers to deal with. Is it worse
to go over the 80 character limit or align the parameters properly? Is
it OK to start the subject with a lower case letter? I get in trouble
for using the wrong prefix but I'm the first person to patch a driver so
how on earth am I supposed to read into your @#$R@#$@#$@#$@ mind to see
what prefix you are going to want?
The imperitive thing is a good suggestion for people to think about but
it's not something that you should suggest to other people out of the
blue for no reason. I've seen people do it for OPW and I'm like, "Eh...
I guess in that case maybe the intern will have to deal with some super
anal maintainer so they should know all the rules". But generally,
unless the person asked you to tutor them about every single unpleasant
thing/maintainer they might have to deal then just let it be. Otherwise
you risk becoming that unpleasant thing they have to deal with.
Don't lose track of the bigger picture which is "Can you understand the
changelog?" There is no such thing as a perfect patch. This patch has
a style violation which I overlooked because it just doesn't matter.
It's discouraging to be nagged at.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-03-02 9:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 5:19 [PATCH 1/5] staging: ks7010: Use constants from ieee80211_eid instead of literal ints Quytelda Kahja
2018-03-01 5:19 ` [PATCH 2/5] staging: ks7010: Replace SSID_MAX_SIZE with IEEE80211_MAX_SSID_LEN Quytelda Kahja
2018-03-01 5:19 ` [PATCH 3/5] staging: ks7010: Factor out repeated code into function 'ks_wlan_cap()' Quytelda Kahja
2018-03-01 6:37 ` Tobin C. Harding
2018-03-01 11:15 ` Dan Carpenter
2018-03-01 20:54 ` Tobin C. Harding
2018-03-02 1:28 ` Quytelda Kahja
2018-03-02 2:21 ` Tobin C. Harding
2018-03-02 9:07 ` Dan Carpenter
2018-03-02 9:05 ` Dan Carpenter [this message]
2018-03-04 22:57 ` Tobin C. Harding
2018-03-01 5:19 ` [PATCH 4/5] staging: ks7010: Replace local capability constants with kernel constants Quytelda Kahja
2018-03-01 5:19 ` [PATCH 5/5] staging: ks7010: Replace local frame type " Quytelda Kahja
2018-03-01 6:33 ` [PATCH 1/5] staging: ks7010: Use constants from ieee80211_eid instead of literal ints Tobin C. Harding
2018-03-01 6:34 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302090503.2zgnzhy5dtolmk3n@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=quytelda@tamalin.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.