From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCHv2] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 Date: Fri, 2 Mar 2018 06:03:31 -0800 Message-ID: <20180302140331.GK62820@atomide.com> References: <20180301035057.37584-1-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Rob Herring , Sebastian Reichel List-Id: linux-omap@vger.kernel.org * Kishon Vijay Abraham I [180302 08:04]: > Hi Tony, > > On Thursday 01 March 2018 09:20 AM, Tony Lindgren wrote: > > Let's add support for the GPIO controlled USB PHY on the MDM6600 modem. > > It is used on some Motorola Mapphone series of phones and tablets such > > as Droid 4. > > Generally PHY configuration is done for the PHYs that is connected to the USB > controllers in the SoC. In that sense it differs from the usual case by > programming the PHY in the device. Yup in this case it's the MDM6600 that provides the PHY for the SoC :) > > The MDM6600 is hardwired to the first OHCI port in the Droid 4 case, and > > is controlled by several GPIOs. The USB PHY is integrated into the MDM6600 > > device it seems. We know this as we get L3 errors from omap-usb-host if > > trying to use the PHY before MDM6600 is configured. > > Do you know what phy is connected to the OHCI port. Previously we've seen for > having USB devices on the board itself, phy less configurations was used. We have MDM6600 on *HCI port 1 providing "ohci-phy-4pin-dpdm" PHY for the SoC, so not TLL. Then there's another modem W3GLTE on port 2 that is using "ehci-tll". > > --- /dev/null > > +++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c > . > . > > . > . > > + > > +static int phy_mdm6600_probe(struct platform_device *pdev) > > +{ > > + struct phy_mdm6600 *ddata; > > + struct usb_otg *otg; > > Since it is connected to a OHCI, not sure if we really need to add usb_otg here. OK yeah that's copy paste leftover from my earlier PHY driver I used to start with. Will drop thanks. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [PATCHv2] phy: mapphone-mdm6600: Add USB PHY driver for MDM6600 on Droid 4 From: Tony Lindgren Message-Id: <20180302140331.GK62820@atomide.com> Date: Fri, 2 Mar 2018 06:03:31 -0800 To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, Mark Rutland , Marcel Partap , Michael Scott , Rob Herring , Sebastian Reichel List-ID: KiBLaXNob24gVmlqYXkgQWJyYWhhbSBJIDxraXNob25AdGkuY29tPiBbMTgwMzAyIDA4OjA0XToK PiBIaSBUb255LAo+IAo+IE9uIFRodXJzZGF5IDAxIE1hcmNoIDIwMTggMDk6MjAgQU0sIFRvbnkg TGluZGdyZW4gd3JvdGU6Cj4gPiBMZXQncyBhZGQgc3VwcG9ydCBmb3IgdGhlIEdQSU8gY29udHJv bGxlZCBVU0IgUEhZIG9uIHRoZSBNRE02NjAwIG1vZGVtLgo+ID4gSXQgaXMgdXNlZCBvbiBzb21l IE1vdG9yb2xhIE1hcHBob25lIHNlcmllcyBvZiBwaG9uZXMgYW5kIHRhYmxldHMgc3VjaAo+ID4g YXMgRHJvaWQgNC4KPiAKPiBHZW5lcmFsbHkgUEhZIGNvbmZpZ3VyYXRpb24gaXMgZG9uZSBmb3Ig dGhlIFBIWXMgdGhhdCBpcyBjb25uZWN0ZWQgdG8gdGhlIFVTQgo+IGNvbnRyb2xsZXJzIGluIHRo ZSBTb0MuIEluIHRoYXQgc2Vuc2UgaXQgZGlmZmVycyBmcm9tIHRoZSB1c3VhbCBjYXNlIGJ5Cj4g cHJvZ3JhbW1pbmcgdGhlIFBIWSBpbiB0aGUgZGV2aWNlLgoKWXVwIGluIHRoaXMgY2FzZSBpdCdz IHRoZSBNRE02NjAwIHRoYXQgcHJvdmlkZXMgdGhlIFBIWSBmb3IgdGhlIFNvQyA6KQoKPiA+IFRo ZSBNRE02NjAwIGlzIGhhcmR3aXJlZCB0byB0aGUgZmlyc3QgT0hDSSBwb3J0IGluIHRoZSBEcm9p ZCA0IGNhc2UsIGFuZAo+ID4gaXMgY29udHJvbGxlZCBieSBzZXZlcmFsIEdQSU9zLiBUaGUgVVNC IFBIWSBpcyBpbnRlZ3JhdGVkIGludG8gdGhlIE1ETTY2MDAKPiA+IGRldmljZSBpdCBzZWVtcy4g V2Uga25vdyB0aGlzIGFzIHdlIGdldCBMMyBlcnJvcnMgZnJvbSBvbWFwLXVzYi1ob3N0IGlmCj4g PiB0cnlpbmcgdG8gdXNlIHRoZSBQSFkgYmVmb3JlIE1ETTY2MDAgaXMgY29uZmlndXJlZC4KPiAK PiBEbyB5b3Uga25vdyB3aGF0IHBoeSBpcyBjb25uZWN0ZWQgdG8gdGhlIE9IQ0kgcG9ydC4gUHJl dmlvdXNseSB3ZSd2ZSBzZWVuIGZvcgo+IGhhdmluZyBVU0IgZGV2aWNlcyBvbiB0aGUgYm9hcmQg aXRzZWxmLCBwaHkgbGVzcyBjb25maWd1cmF0aW9ucyB3YXMgdXNlZC4KCldlIGhhdmUgTURNNjYw MCBvbiAqSENJIHBvcnQgMSBwcm92aWRpbmcgIm9oY2ktcGh5LTRwaW4tZHBkbSIKUEhZIGZvciB0 aGUgU29DLCBzbyBub3QgVExMLiBUaGVuIHRoZXJlJ3MgYW5vdGhlciBtb2RlbSBXM0dMVEUgb24K cG9ydCAyIHRoYXQgaXMgdXNpbmcgImVoY2ktdGxsIi4KCj4gPiAtLS0gL2Rldi9udWxsCj4gPiAr KysgYi9kcml2ZXJzL3BoeS9tb3Rvcm9sYS9waHktbWFwcGhvbmUtbWRtNjYwMC5jCj4gLgo+IC4K PiA8c25pcD4KPiAuCj4gLgo+ID4gKwo+ID4gK3N0YXRpYyBpbnQgcGh5X21kbTY2MDBfcHJvYmUo c3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiA+ICt7Cj4gPiArCXN0cnVjdCBwaHlfbWRt NjYwMCAqZGRhdGE7Cj4gPiArCXN0cnVjdCB1c2Jfb3RnICpvdGc7Cj4gCj4gU2luY2UgaXQgaXMg Y29ubmVjdGVkIHRvIGEgT0hDSSwgbm90IHN1cmUgaWYgd2UgcmVhbGx5IG5lZWQgdG8gYWRkIHVz Yl9vdGcgaGVyZS4KCk9LIHllYWggdGhhdCdzIGNvcHkgcGFzdGUgbGVmdG92ZXIgZnJvbSBteSBl YXJsaWVyIFBIWSBkcml2ZXIgSSB1c2VkCnRvIHN0YXJ0IHdpdGguIFdpbGwgZHJvcCB0aGFua3Mu CgpSZWdhcmRzLAoKVG9ueQotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQg dGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdl IHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0 cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==