From: Andrew Lunn <andrew@lunn.ch>
To: Bryan.Whitehead@microchip.com
Cc: davem@davemloft.net, UNGLinuxDriver@microchip.com,
netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next 1/2] lan743x: Add main source files for new lan743x driver
Date: Fri, 2 Mar 2018 21:14:23 +0100 [thread overview]
Message-ID: <20180302201423.GA25189@lunn.ch> (raw)
In-Reply-To: <90A7E81AE28BAE4CBDDB3B35F187D2644071F1E3@CHN-SV-EXMX02.mchp-main.com>
> Hi Andrew,
>
> The phy is built in for LAN7430, and external for LAN7431. But the
> same reset should work in both cases because it asserts the normal
> phy reset line.
Assuming the PHY reset is connect to the external line, not a GPIO.
So this is O.K.
> > Assuming it is built in, does the MAC get the interrupt?
> > phy_mac_interrupt() can be called if so.
>
> I believe the MAC does support a phy interrupt. But right now it's
> working well using phy polling. Is it ok if I post pone supporting phy
> interrupts until a future patch? I am planning a series of patches, and I
> can add support for phy interrupts to the list.
Yes, adding this later is fine.
Andrew
next prev parent reply other threads:[~2018-03-02 20:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 21:00 [PATCH v3 net-next 0/2] lan743x: Add new lan743x driver Bryan Whitehead
2018-03-01 21:00 ` [PATCH v3 net-next 1/2] lan743x: Add main source files for " Bryan Whitehead
2018-03-01 22:12 ` Andrew Lunn
2018-03-02 5:57 ` Bryan.Whitehead
2018-03-02 13:40 ` Andrew Lunn
2018-03-02 18:26 ` Bryan.Whitehead
2018-03-02 20:14 ` Andrew Lunn [this message]
2018-03-01 21:00 ` [PATCH v3 net-next 2/2] lan743x: Update MAINTAINERS to include " Bryan Whitehead
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302201423.GA25189@lunn.ch \
--to=andrew@lunn.ch \
--cc=Bryan.Whitehead@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.