From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: virtio-dev-return-3379-cohuck=redhat.com@lists.oasis-open.org Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [66.179.20.138]) by lists.oasis-open.org (Postfix) with ESMTP id D28185818F63 for ; Fri, 2 Mar 2018 11:41:04 -0800 (PST) Date: Fri, 2 Mar 2018 21:41:02 +0200 From: "Michael S. Tsirkin" Message-ID: <20180302213920-mutt-send-email-mst@kernel.org> References: <1519934923-39372-1-git-send-email-sridhar.samudrala@intel.com> <1519934923-39372-3-git-send-email-sridhar.samudrala@intel.com> <20180302083605.GD2099@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [virtio-dev] Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available To: Alexander Duyck Cc: Jiri Pirko , Sridhar Samudrala , Stephen Hemminger , David Miller , Netdev , virtio-dev@lists.oasis-open.org, "Brandeburg, Jesse" , "Duyck, Alexander H" , Jakub Kicinski List-ID: On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote: > The design limits things to a 1:1 relationship since we just have the > child and backup pointers, but I don't think I am seeing exception > handling to prevent us from overwriting the child pointers so there > may be a leak there. > > Thanks. > > - Alex In fact maintaining a list in that case would be nicer, and just use an arbitrary one. E.g. one can see how a user wanting to swap device 1 for device 2 might first add device 2 with same MAC then drop device 1. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v4 2/2] virtio_net: Extend virtio to use VF datapath when available Date: Fri, 2 Mar 2018 21:41:02 +0200 Message-ID: <20180302213920-mutt-send-email-mst@kernel.org> References: <1519934923-39372-1-git-send-email-sridhar.samudrala@intel.com> <1519934923-39372-3-git-send-email-sridhar.samudrala@intel.com> <20180302083605.GD2099@nanopsycho> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jiri Pirko , Sridhar Samudrala , Stephen Hemminger , David Miller , Netdev , virtio-dev@lists.oasis-open.org, "Brandeburg, Jesse" , "Duyck, Alexander H" , Jakub Kicinski To: Alexander Duyck Return-path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Content-Disposition: inline In-Reply-To: List-Id: netdev.vger.kernel.org On Fri, Mar 02, 2018 at 07:26:25AM -0800, Alexander Duyck wrote: > The design limits things to a 1:1 relationship since we just have the > child and backup pointers, but I don't think I am seeing exception > handling to prevent us from overwriting the child pointers so there > may be a leak there. > > Thanks. > > - Alex In fact maintaining a list in that case would be nicer, and just use an arbitrary one. E.g. one can see how a user wanting to swap device 1 for device 2 might first add device 2 with same MAC then drop device 1. -- MST