From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from newverein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 525B021E08291 for ; Fri, 2 Mar 2018 14:51:26 -0800 (PST) Date: Fri, 2 Mar 2018 23:57:34 +0100 From: Christoph Hellwig Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes Message-ID: <20180302225734.GE31240@lst.de> References: <151996281307.28483.12343847096989509127.stgit@dwillia2-desk3.amr.corp.intel.com> <20180302221020.GA30722@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Jane Chu , Michal Hocko , Jan Kara , Matthew Wilcox , KVM list , "Darrick J. Wong" , linux-nvdimm , Linux Kernel Mailing List , stable , linux-xfs , Linux MM , Alex Williamson , Gerd Rausch , Andreas Dilger , Alexander Viro , linux-fsdevel , Theodore Ts'o , Christoph Hellwig List-ID: On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote: > They are indeed a hodge-podge. The problem is that the current > IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with > IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks > you propose for the next merge window. The only thing broken about IS_DAX are the code elimination games based on the CONFIG_* flags. Remove those and just add proper stubs for the dax routines and everything will be fine for now until we can kill that inode flag. IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't helping anyone. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:38367 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932836AbeCBW5h (ORCPT ); Fri, 2 Mar 2018 17:57:37 -0500 Date: Fri, 2 Mar 2018 23:57:34 +0100 From: Christoph Hellwig Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes Message-ID: <20180302225734.GE31240@lst.de> References: <151996281307.28483.12343847096989509127.stgit@dwillia2-desk3.amr.corp.intel.com> <20180302221020.GA30722@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Dan Williams Cc: Christoph Hellwig , linux-nvdimm , linux-xfs , "Darrick J. Wong" , KVM list , Haozhong Zhang , Jane Chu , Alexander Viro , Gerd Rausch , stable , Jan Kara , Michal Hocko , Andreas Dilger , Ross Zwisler , Matthew Wilcox , linux-fsdevel , Alex Williamson , Theodore Ts'o , Linux MM , Linux Kernel Mailing List On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote: > They are indeed a hodge-podge. The problem is that the current > IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with > IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks > you propose for the next merge window. The only thing broken about IS_DAX are the code elimination games based on the CONFIG_* flags. Remove those and just add proper stubs for the dax routines and everything will be fine for now until we can kill that inode flag. IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't helping anyone. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes Date: Fri, 2 Mar 2018 23:57:34 +0100 Message-ID: <20180302225734.GE31240@lst.de> References: <151996281307.28483.12343847096989509127.stgit@dwillia2-desk3.amr.corp.intel.com> <20180302221020.GA30722@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jane Chu , Michal Hocko , Jan Kara , Matthew Wilcox , KVM list , "Darrick J. Wong" , linux-nvdimm , Linux Kernel Mailing List , stable , linux-xfs , Linux MM , Alex Williamson , Gerd Rausch , Andreas Dilger , Alexander Viro , linux-fsdevel , Theodore Ts'o , Christoph Hellwig To: Dan Williams Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" List-Id: kvm.vger.kernel.org On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote: > They are indeed a hodge-podge. The problem is that the current > IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with > IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks > you propose for the next merge window. The only thing broken about IS_DAX are the code elimination games based on the CONFIG_* flags. Remove those and just add proper stubs for the dax routines and everything will be fine for now until we can kill that inode flag. IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't helping anyone. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Fri, 2 Mar 2018 23:57:34 +0100 From: Christoph Hellwig To: Dan Williams Cc: Christoph Hellwig , linux-nvdimm , linux-xfs , "Darrick J. Wong" , KVM list , Haozhong Zhang , Jane Chu , Alexander Viro , Gerd Rausch , stable , Jan Kara , Michal Hocko , Andreas Dilger , Ross Zwisler , Matthew Wilcox , linux-fsdevel , Alex Williamson , Theodore Ts'o , Linux MM , Linux Kernel Mailing List Subject: Re: [PATCH v5 00/12] vfio, dax: prevent long term filesystem-dax pins and other fixes Message-ID: <20180302225734.GE31240@lst.de> References: <151996281307.28483.12343847096989509127.stgit@dwillia2-desk3.amr.corp.intel.com> <20180302221020.GA30722@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: On Fri, Mar 02, 2018 at 02:21:40PM -0800, Dan Williams wrote: > They are indeed a hodge-podge. The problem is that the current > IS_DAX() is broken. So I'd like to propose fixing IS_DAX() with > IS_FSDAX() + IS_DEVDAX() for 4.16-rc4 and queue up these wider reworks > you propose for the next merge window. The only thing broken about IS_DAX are the code elimination games based on the CONFIG_* flags. Remove those and just add proper stubs for the dax routines and everything will be fine for now until we can kill that inode flag. IS_FSDAX and IS_DEVDAX on the other hand are a giant mess that isn't helping anyone. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org