From: Stefano Brivio <sbrivio@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
"Wei Wang" <weiwan@google.com>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
"Maciej Żenczykowski" <maze@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] ipv6: Reflect MTU changes on PMTU of exceptions for MTU-less routes
Date: Mon, 5 Mar 2018 00:12:45 +0100 [thread overview]
Message-ID: <20180305001245.23b56b3f@epycfail> (raw)
In-Reply-To: <20180303122236.6dde3a9b@epycfail>
On Sat, 3 Mar 2018 12:22:36 +0100
Stefano Brivio <sbrivio@redhat.com> wrote:
> > And please codify the above expectation as a test under
> > tools/testing/selftests/net
>
> And this, along with v2.
On a second thought: I start thinking it doesn't make much sense,
especially given the current context of self-tests, to explicitly test
this, because it's a rather particular corner case.
I think it would make more sense to introduce generic tests first.
About, say, PMTU, or route exceptions, but not "tunnel causes route
exception and administrative change doesn't affect PMTU".
--
Stefano
next prev parent reply other threads:[~2018-03-04 23:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 22:47 [PATCH net v2] ipv6: Reflect MTU changes on PMTU of exceptions for MTU-less routes Stefano Brivio
2018-03-02 18:54 ` [PATCH net] " Maciej Żenczykowski
2018-03-03 11:21 ` Stefano Brivio
2018-03-02 22:39 ` David Ahern
2018-03-03 11:22 ` Stefano Brivio
2018-03-04 23:12 ` Stefano Brivio [this message]
2018-03-05 1:11 ` David Ahern
2018-03-05 12:29 ` Stefano Brivio
2018-03-05 14:14 ` David Miller
2018-03-05 15:27 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305001245.23b56b3f@epycfail \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=weiwan@google.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.