From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings From: Vinod Koul Message-Id: <20180305053256.GN15443@localhost> Date: Mon, 5 Mar 2018 11:02:56 +0530 To: Alexey Brodkin Cc: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "Eugeniy.Paltsev@synopsys.com" , "linux-snps-arc@lists.infradead.org" , "andy.shevchenko@gmail.com" , "dan.j.williams@intel.com" , "dmaengine@vger.kernel.org" , "wan.ahmad.zainie.wan.mohamad@intel.com" List-ID: T24gRnJpLCBNYXIgMDIsIDIwMTggYXQgMDg6MzI6MjBBTSArMDAwMCwgQWxleGV5IEJyb2RraW4g d3JvdGU6Cj4gSGkgVmlub2QsCj4gCj4gT24gRnJpLCAyMDE4LTAzLTAyIGF0IDEzOjQ0ICswNTMw LCBWaW5vZCBLb3VsIHdyb3RlOgo+ID4gT24gTW9uLCBGZWIgMjYsIDIwMTggYXQgMDU6NTY6MjhQ TSArMDMwMCwgRXVnZW5peSBQYWx0c2V2IHdyb3RlOgo+ID4gPiBUaGlzIHBhdGNoIGFkZHMgZG9j dW1lbnRhdGlvbiBvZiBkZXZpY2UgdHJlZSBiaW5kaW5ncyBmb3IgdGhlIFN5bm9wc3lzCj4gPiA+ IERlc2lnbldhcmUgQVhJIERNQSBjb250cm9sbGVyLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1i eTogRXVnZW5peSBQYWx0c2V2IDxFdWdlbml5LlBhbHRzZXZAc3lub3BzeXMuY29tPgo+ID4gPiAt LS0KPiA+ID4gIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS9zbnBzLGR3LWF4aS1kbWFjLnR4 dCAgIHwgNDEgKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDQx IGluc2VydGlvbnMoKykKPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZG1hL3NucHMsZHctYXhpLWRtYWMudHh0Cj4gPiA+IAo+ID4gPiBk aWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2RtYS9zbnBzLGR3 LWF4aS1kbWFjLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvc25w cyxkdy1heGktZG1hYy50eHQKPiA+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+ID4gaW5kZXgg MDAwMDAwMC4uZjIzN2I3OQo+ID4gPiAtLS0gL2Rldi9udWxsCj4gPiA+ICsrKyBiL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kbWEvc25wcyxkdy1heGktZG1hYy50eHQKPiA+ID4g QEAgLTAsMCArMSw0MSBAQAo+ID4gPiArU3lub3BzeXMgRGVzaWduV2FyZSBBWEkgRE1BIENvbnRy b2xsZXIKPiA+ID4gKwo+ID4gPiArUmVxdWlyZWQgcHJvcGVydGllczoKPiA+ID4gKy0gY29tcGF0 aWJsZTogInNucHMsYXhpLWRtYS0xLjAxYSIKPiA+ID4gKy0gcmVnOiBBZGRyZXNzIHJhbmdlIG9m IHRoZSBETUFDIHJlZ2lzdGVycy4gVGhpcyBzaG91bGQgaW5jbHVkZQo+ID4gPiArICBhbGwgb2Yg dGhlIHBlci1jaGFubmVsIHJlZ2lzdGVycy4KPiA+ID4gKy0gaW50ZXJydXB0OiBTaG91bGQgY29u dGFpbiB0aGUgRE1BQyBpbnRlcnJ1cHQgbnVtYmVyLgo+ID4gPiArLSBpbnRlcnJ1cHQtcGFyZW50 OiBTaG91bGQgYmUgdGhlIHBoYW5kbGUgZm9yIHRoZSBpbnRlcnJ1cHQgY29udHJvbGxlcgo+ID4g PiArICB0aGF0IHNlcnZpY2VzIGludGVycnVwdHMgZm9yIHRoaXMgZGV2aWNlLgo+ID4gPiArLSBk bWEtY2hhbm5lbHM6IE51bWJlciBvZiBjaGFubmVscyBzdXBwb3J0ZWQgYnkgaGFyZHdhcmUuCj4g PiA+ICstIHNucHMsZG1hLW1hc3RlcnM6IE51bWJlciBvZiBBWEkgbWFzdGVycyBzdXBwb3J0ZWQg YnkgdGhlIGhhcmR3YXJlLgo+ID4gPiArLSBzbnBzLGRhdGEtd2lkdGg6IE1heGltdW0gQVhJIGRh dGEgd2lkdGggc3VwcG9ydGVkIGJ5IGhhcmR3YXJlLgo+ID4gPiArICAoMCAtIDhiaXRzLCAxIC0g MTZiaXRzLCAyIC0gMzJiaXRzLCAuLi4sIDYgLSA1MTJiaXRzKQo+ID4gPiArLSBzbnBzLHByaW9y aXR5OiBQcmlvcml0eSBvZiBjaGFubmVsLiBBcnJheSBzaXplIGlzIGVxdWFsIHRvIHRoZSBudW1i ZXIgb2YKPiA+ID4gKyAgZG1hLWNoYW5uZWxzLiBQcmlvcml0eSB2YWx1ZSBtdXN0IGJlIHByb2dy YW1tZWQgd2l0aGluIFswOmRtYS1jaGFubmVscy0xXQo+ID4gPiArICByYW5nZS4gKDAgLSBtaW5p bXVtIHByaW9yaXR5KQo+ID4gPiArLSBzbnBzLGJsb2NrLXNpemU6IE1heGltdW0gYmxvY2sgc2l6 ZSBzdXBwb3J0ZWQgYnkgdGhlIGNvbnRyb2xsZXIgY2hhbm5lbC4KPiA+ID4gKyAgQXJyYXkgc2l6 ZSBpcyBlcXVhbCB0byB0aGUgbnVtYmVyIG9mIGRtYS1jaGFubmVscy4KPiA+ID4gKwo+ID4gPiAr T3B0aW9uYWwgcHJvcGVydGllczoKPiA+ID4gKy0gc25wcyxheGktbWF4LWJ1cnN0LWxlbjogUmVz dHJpY3QgbWFzdGVyIEFYSSBidXJzdCBsZW5ndGggYnkgdmFsdWUgc3BlY2lmaWVkCj4gPiA+ICsg IGluIHRoaXMgcHJvcGVydHkuIElmIHRoaXMgcHJvcGVydHkgaXMgbWlzc2luZyB0aGUgbWF4aW11 bSBBWEkgYnVyc3QgbGVuZ3RoCj4gPiA+ICsgIHN1cHBvcnRlZCBieSBETUFDIGlzIHVzZWQuIFsx OjI1Nl0KPiA+ID4gKwo+ID4gPiArRXhhbXBsZToKPiA+ID4gKwo+ID4gPiArZG1hYzogZG1hLWNv bnRyb2xsZXJAODAwMDAgewo+ID4gPiArCWNvbXBhdGlibGUgPSAic25wcyxheGktZG1hLTEuMDFh IjsKPiA+IAo+ID4gZG8gd2UgbmVlZCAic25wcyBoZXJlLi4/Cj4gCj4gU3lub3BzeXMgaXMgdGhp cyBJUC1ibG9jayB2ZW5kb3Igc28gc2hvdWxkbid0IHdlIHB1dCBpdCB0aGF0IHdheT8KCk5vdCBh IERUIGV4cGVydCBidXQgd2h5IHNob3VsZCB2ZW5kb3IgbmFtZSBjb21lIGhlcmUsIHlvdSBjYW4g cmVhZCB0aGUKcHJvcGVydGllcyBmcm9tIGRldmljZSBub2RlLCB2ZW5kb3IgbmFtZSBzZWVtcyBy ZWR1bmRhbnQgdG8gbWUK From mboxrd@z Thu Jan 1 00:00:00 1970 From: vinod.koul@intel.com (Vinod Koul) Date: Mon, 5 Mar 2018 11:02:56 +0530 Subject: [PATCH v2 2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings In-Reply-To: <1519979538.4430.7.camel@synopsys.com> References: <20180226145628.11892-1-Eugeniy.Paltsev@synopsys.com> <20180226145628.11892-3-Eugeniy.Paltsev@synopsys.com> <20180302081408.GK15443@localhost> <1519979538.4430.7.camel@synopsys.com> List-ID: Message-ID: <20180305053256.GN15443@localhost> To: linux-snps-arc@lists.infradead.org On Fri, Mar 02, 2018@08:32:20AM +0000, Alexey Brodkin wrote: > Hi Vinod, > > On Fri, 2018-03-02@13:44 +0530, Vinod Koul wrote: > > On Mon, Feb 26, 2018@05:56:28PM +0300, Eugeniy Paltsev wrote: > > > This patch adds documentation of device tree bindings for the Synopsys > > > DesignWare AXI DMA controller. > > > > > > Signed-off-by: Eugeniy Paltsev > > > --- > > > .../devicetree/bindings/dma/snps,dw-axi-dmac.txt | 41 ++++++++++++++++++++++ > > > 1 file changed, 41 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt > > > > > > diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt > > > new file mode 100644 > > > index 0000000..f237b79 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt > > > @@ -0,0 +1,41 @@ > > > +Synopsys DesignWare AXI DMA Controller > > > + > > > +Required properties: > > > +- compatible: "snps,axi-dma-1.01a" > > > +- reg: Address range of the DMAC registers. This should include > > > + all of the per-channel registers. > > > +- interrupt: Should contain the DMAC interrupt number. > > > +- interrupt-parent: Should be the phandle for the interrupt controller > > > + that services interrupts for this device. > > > +- dma-channels: Number of channels supported by hardware. > > > +- snps,dma-masters: Number of AXI masters supported by the hardware. > > > +- snps,data-width: Maximum AXI data width supported by hardware. > > > + (0 - 8bits, 1 - 16bits, 2 - 32bits, ..., 6 - 512bits) > > > +- snps,priority: Priority of channel. Array size is equal to the number of > > > + dma-channels. Priority value must be programmed within [0:dma-channels-1] > > > + range. (0 - minimum priority) > > > +- snps,block-size: Maximum block size supported by the controller channel. > > > + Array size is equal to the number of dma-channels. > > > + > > > +Optional properties: > > > +- snps,axi-max-burst-len: Restrict master AXI burst length by value specified > > > + in this property. If this property is missing the maximum AXI burst length > > > + supported by DMAC is used. [1:256] > > > + > > > +Example: > > > + > > > +dmac: dma-controller at 80000 { > > > + compatible = "snps,axi-dma-1.01a"; > > > > do we need "snps here..? > > Synopsys is this IP-block vendor so shouldn't we put it that way? Not a DT expert but why should vendor name come here, you can read the properties from device node, vendor name seems redundant to me -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH v2 2/2] dt-bindings: Document the Synopsys DW AXI DMA bindings Date: Mon, 5 Mar 2018 11:02:56 +0530 Message-ID: <20180305053256.GN15443@localhost> References: <20180226145628.11892-1-Eugeniy.Paltsev@synopsys.com> <20180226145628.11892-3-Eugeniy.Paltsev@synopsys.com> <20180302081408.GK15443@localhost> <1519979538.4430.7.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1519979538.4430.7.camel@synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: Alexey Brodkin Cc: "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "Eugeniy.Paltsev@synopsys.com" , "linux-snps-arc@lists.infradead.org" , "andy.shevchenko@gmail.com" , "dan.j.williams@intel.com" , "dmaengine@vger.kernel.org" , "wan.ahmad.zainie.wan.mohamad@intel.com" List-Id: devicetree@vger.kernel.org On Fri, Mar 02, 2018 at 08:32:20AM +0000, Alexey Brodkin wrote: > Hi Vinod, > > On Fri, 2018-03-02 at 13:44 +0530, Vinod Koul wrote: > > On Mon, Feb 26, 2018 at 05:56:28PM +0300, Eugeniy Paltsev wrote: > > > This patch adds documentation of device tree bindings for the Synopsys > > > DesignWare AXI DMA controller. > > > > > > Signed-off-by: Eugeniy Paltsev > > > --- > > > .../devicetree/bindings/dma/snps,dw-axi-dmac.txt | 41 ++++++++++++++++++++++ > > > 1 file changed, 41 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt > > > > > > diff --git a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt > > > new file mode 100644 > > > index 0000000..f237b79 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt > > > @@ -0,0 +1,41 @@ > > > +Synopsys DesignWare AXI DMA Controller > > > + > > > +Required properties: > > > +- compatible: "snps,axi-dma-1.01a" > > > +- reg: Address range of the DMAC registers. This should include > > > + all of the per-channel registers. > > > +- interrupt: Should contain the DMAC interrupt number. > > > +- interrupt-parent: Should be the phandle for the interrupt controller > > > + that services interrupts for this device. > > > +- dma-channels: Number of channels supported by hardware. > > > +- snps,dma-masters: Number of AXI masters supported by the hardware. > > > +- snps,data-width: Maximum AXI data width supported by hardware. > > > + (0 - 8bits, 1 - 16bits, 2 - 32bits, ..., 6 - 512bits) > > > +- snps,priority: Priority of channel. Array size is equal to the number of > > > + dma-channels. Priority value must be programmed within [0:dma-channels-1] > > > + range. (0 - minimum priority) > > > +- snps,block-size: Maximum block size supported by the controller channel. > > > + Array size is equal to the number of dma-channels. > > > + > > > +Optional properties: > > > +- snps,axi-max-burst-len: Restrict master AXI burst length by value specified > > > + in this property. If this property is missing the maximum AXI burst length > > > + supported by DMAC is used. [1:256] > > > + > > > +Example: > > > + > > > +dmac: dma-controller@80000 { > > > + compatible = "snps,axi-dma-1.01a"; > > > > do we need "snps here..? > > Synopsys is this IP-block vendor so shouldn't we put it that way? Not a DT expert but why should vendor name come here, you can read the properties from device node, vendor name seems redundant to me -- ~Vinod