From: Gary Bisson <gary.bisson@boundarydevices.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/kodi: remove imx support
Date: Mon, 5 Mar 2018 09:54:52 +0100 [thread overview]
Message-ID: <20180305085452.GA20775@t450s.lan> (raw)
In-Reply-To: <20180304150606.32748-2-bernd.kuhls@t-online.de>
Hi Bernd,
On Sun, Mar 04, 2018 at 04:06:06PM +0100, Bernd Kuhls wrote:
> https://git.buildroot.net/buildroot/commit/?id=266208972192f1e0869f89d7be941de6294a810a
> broke imx support in Kodi because previously the G2D libraries were
> part of the imx-gpu-viv package:
>
> CMake Error at /usr/share/cmake-3.7/Modules/FindPackageHandleStandardArgs.cmake:138 (message):
> Could NOT find IMX (missing: G2D_LIBRARY)
How could it build before since it never explicitely depended on G2D?
> Adjusting the Kodi package to use the imx-gpu-g2d as well still does
> not provide a working build:
>
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp: In member function 'void CIMX::Deinitialize()':
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:79:21: error: 'DCIC_IOC_STOP_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_STOP_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp: In member function 'bool CIMX::UpdateDCIC()':
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:109:19: error: 'DCIC_IOC_STOP_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_STOP_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:115:21: error: 'DCIC_IOC_START_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_START_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~~
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp: In member function 'virtual void CIMX::Process()':
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:125:19: error: 'DCIC_IOC_START_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_START_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~~
> /home/buildroot/br4/output/build/kodi-17.6-Krypton/xbmc/linux/imx/IMX.cpp:131:19: error: 'DCIC_IOC_STOP_VSYNC' was not declared in this scope
> ioctl(m_fddcic, DCIC_IOC_STOP_VSYNC, 0);
> ^~~~~~~~~~~~~~~~~~~
>
> Although it might be possible to fix these bugs with something like
>
> #define DCIC_IOC_CONFIG_DCIC _IO('D', 12)
> #define DCIC_IOC_START_VSYNC _IO('D', 15)
> #define DCIC_IOC_STOP_VSYNC _IO('D', 16)
>
> as done in
> https://raw.githubusercontent.com/LibreELEC/LibreELEC.tv/libreelec-7.0/projects/imx6/patches/kodi/imx6-jarvis.patch
Wow I never paid attention to Kodi support but I'm not surprised it's
not working since those ioctl are Kodi-specific, not available in NXP
default tree (checked 3.10, 3.14 and 4.1.15):
https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/video/mxc/mxc_dcic.c?h=imx_3.10.53_1.1.0_ga_caf#n386
https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/video/mxc/mxc_dcic.c?h=imx_3.14.52_1.1.0_ga#n386
https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/video/mxc/mxc_dcic.c?h=imx_3.14.52_1.1.0_ga#n386
Seems to need that patch:
https://github.com/osmc/vero-linux/commit/ac572b2d2b
> we would still try to ride a dead horse. The upcoming Kodi version
> 18.0-Leia will remove imx support completely, see upstream PR 12990.
Yes I believe they are switching to mainline kernel support (using
Etnaviv + standard V4L2 CODA support).
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Reviewed-by: Gary Bisson <gary.bisson@boundarydevices.com>
Regards,
Gary
next prev parent reply other threads:[~2018-03-05 8:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 15:06 [Buildroot] [PATCH 1/2] package/freescale-imx: Remove imx6s from has_vpu list Bernd Kuhls
2018-03-04 15:06 ` [Buildroot] [PATCH 2/2] package/kodi: remove imx support Bernd Kuhls
2018-03-05 8:54 ` Gary Bisson [this message]
2018-03-31 21:08 ` Thomas Petazzoni
2018-04-08 15:07 ` Peter Korsgaard
2018-03-05 8:35 ` [Buildroot] [PATCH 1/2] package/freescale-imx: Remove imx6s from has_vpu list Gary Bisson
2018-03-31 21:08 ` Thomas Petazzoni
2018-04-08 15:07 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305085452.GA20775@t450s.lan \
--to=gary.bisson@boundarydevices.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.