diff for duplicates of <20180305111107.GH25377@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index cbed632..d580a9b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -8,16 +8,16 @@ On Thu, Mar 01, 2018 at 02:10:17PM -0800, J Freyensee wrote: > > + tpm_buf_destroy(&buf); > > if (rc < 0) > Why is this if() check not directly after the tpm_transmit_cmd() call that -> sets rc? Is it correct you want to destroy buf regardless of the +> sets rc? Is it correct you want to destroy buf regardless of the > tpm_transmit_cmd() outcome? > > return rc; > > - -> > - if (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS) +> > - if (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS) > > + out = (struct tpm_output_header *)buf.data; > > So buf has been destroyed, buf.data sill has something valid to assign to > out? -> > + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> > + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > > chip->flags |= TPM_CHIP_FLAG_TPM2; > > return 0; > Thanks, diff --git a/a/content_digest b/N1/content_digest index 78d87a2..4596ec9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\05d8921fb-f7e0-5498-99e2-d4d84aa597f3@gmail.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 05 Mar 2018 11:11:07 +0000\0" + "Date\0Mon, 5 Mar 2018 13:11:07 +0200\0" "To\0J Freyensee <why2jjj.linux@gmail.com>\0" "Cc\0linux-integrity@vger.kernel.org" linux-security-module@vger.kernel.org @@ -25,16 +25,16 @@ "> > +\ttpm_buf_destroy(&buf);\n" "> > \tif (rc < 0)\n" "> Why is this if() check not directly after the tpm_transmit_cmd() call that\n" - "> sets rc?\302\240 Is it correct you want to destroy buf regardless of the\n" + "> sets rc? Is it correct you want to destroy buf regardless of the\n" "> tpm_transmit_cmd() outcome?\n" "> > \t\treturn rc;\n" "> > -\n" - "> > -\tif (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS)\n" + "> > -\tif (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS)\n" "> > +\tout = (struct tpm_output_header *)buf.data;\n" "> \n" "> So buf has been destroyed, buf.data sill has something valid to assign to\n" "> out?\n" - "> > +\tif (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> > +\tif (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> > \t\tchip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> > \treturn 0;\n" "> Thanks,\n" @@ -46,4 +46,4 @@ "\n" /Jarkko -f87d4d38cbc2963718455676ffdfb5139ece58da25e2718a77d26db88cf24875 +1ebb7dd508c98c32225c525de40d356b954d05cbd7a372c10f610a39648b5d8c
diff --git a/a/1.txt b/N2/1.txt index cbed632..2a34c24 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -8,16 +8,16 @@ On Thu, Mar 01, 2018 at 02:10:17PM -0800, J Freyensee wrote: > > + tpm_buf_destroy(&buf); > > if (rc < 0) > Why is this if() check not directly after the tpm_transmit_cmd() call that -> sets rc? Is it correct you want to destroy buf regardless of the +> sets rc?? Is it correct you want to destroy buf regardless of the > tpm_transmit_cmd() outcome? > > return rc; > > - -> > - if (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS) +> > - if (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS) > > + out = (struct tpm_output_header *)buf.data; > > So buf has been destroyed, buf.data sill has something valid to assign to > out? -> > + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> > + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > > chip->flags |= TPM_CHIP_FLAG_TPM2; > > return 0; > Thanks, @@ -28,3 +28,7 @@ can be called if the response data is not needed other than everything went OK (tpm_transmit_cmd() already digs this info). /Jarkko +-- +To unsubscribe from this list: send the line "unsubscribe linux-security-module" in +the body of a message to majordomo at vger.kernel.org +More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 78d87a2..32dc761 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,18 +1,10 @@ "ref\020180228195819.22231-1-jarkko.sakkinen@linux.intel.com\0" "ref\020180228195819.22231-4-jarkko.sakkinen@linux.intel.com\0" "ref\05d8921fb-f7e0-5498-99e2-d4d84aa597f3@gmail.com\0" - "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" - "Subject\0Re: [PATCH 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 05 Mar 2018 11:11:07 +0000\0" - "To\0J Freyensee <why2jjj.linux@gmail.com>\0" - "Cc\0linux-integrity@vger.kernel.org" - linux-security-module@vger.kernel.org - keyrings@vger.kernel.org - Peter Huewe <peterhuewe@gmx.de> - Jason Gunthorpe <jgg@ziepe.ca> - Arnd Bergmann <arnd@arndb.de> - Greg Kroah-Hartman <gregkh@linuxfoundation.org> - " open list <linux-kernel@vger.kernel.org>\0" + "From\0jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)\0" + "Subject\0[PATCH 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" + "Date\0Mon, 5 Mar 2018 13:11:07 +0200\0" + "To\0linux-security-module@vger.kernel.org\0" "\00:1\0" "b\0" "On Thu, Mar 01, 2018 at 02:10:17PM -0800, J Freyensee wrote:\n" @@ -25,16 +17,16 @@ "> > +\ttpm_buf_destroy(&buf);\n" "> > \tif (rc < 0)\n" "> Why is this if() check not directly after the tpm_transmit_cmd() call that\n" - "> sets rc?\302\240 Is it correct you want to destroy buf regardless of the\n" + "> sets rc?? Is it correct you want to destroy buf regardless of the\n" "> tpm_transmit_cmd() outcome?\n" "> > \t\treturn rc;\n" "> > -\n" - "> > -\tif (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS)\n" + "> > -\tif (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS)\n" "> > +\tout = (struct tpm_output_header *)buf.data;\n" "> \n" "> So buf has been destroyed, buf.data sill has something valid to assign to\n" "> out?\n" - "> > +\tif (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> > +\tif (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> > \t\tchip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> > \treturn 0;\n" "> Thanks,\n" @@ -44,6 +36,10 @@ "can be called if the response data is not needed other than everything\n" "went OK (tpm_transmit_cmd() already digs this info).\n" "\n" - /Jarkko + "/Jarkko\n" + "--\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-security-module\" in\n" + "the body of a message to majordomo at vger.kernel.org\n" + More majordomo info at http://vger.kernel.org/majordomo-info.html -f87d4d38cbc2963718455676ffdfb5139ece58da25e2718a77d26db88cf24875 +f35912b19d04171fed52c7281abcc00644671fa19227838bbb2209394a038438
diff --git a/a/1.txt b/N3/1.txt index cbed632..66ada79 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -12,12 +12,12 @@ On Thu, Mar 01, 2018 at 02:10:17PM -0800, J Freyensee wrote: > tpm_transmit_cmd() outcome? > > return rc; > > - -> > - if (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS) +> > - if (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS) > > + out = (struct tpm_output_header *)buf.data; > > So buf has been destroyed, buf.data sill has something valid to assign to > out? -> > + if (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS) +> > + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS) > > chip->flags |= TPM_CHIP_FLAG_TPM2; > > return 0; > Thanks, diff --git a/a/content_digest b/N3/content_digest index 78d87a2..c75f401 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,7 +3,7 @@ "ref\05d8921fb-f7e0-5498-99e2-d4d84aa597f3@gmail.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf\0" - "Date\0Mon, 05 Mar 2018 11:11:07 +0000\0" + "Date\0Mon, 5 Mar 2018 13:11:07 +0200\0" "To\0J Freyensee <why2jjj.linux@gmail.com>\0" "Cc\0linux-integrity@vger.kernel.org" linux-security-module@vger.kernel.org @@ -29,12 +29,12 @@ "> tpm_transmit_cmd() outcome?\n" "> > \t\treturn rc;\n" "> > -\n" - "> > -\tif (be16_to_cpu(cmd.header.out.tag) = TPM2_ST_NO_SESSIONS)\n" + "> > -\tif (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS)\n" "> > +\tout = (struct tpm_output_header *)buf.data;\n" "> \n" "> So buf has been destroyed, buf.data sill has something valid to assign to\n" "> out?\n" - "> > +\tif (be16_to_cpu(out->tag) = TPM2_ST_NO_SESSIONS)\n" + "> > +\tif (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)\n" "> > \t\tchip->flags |= TPM_CHIP_FLAG_TPM2;\n" "> > \treturn 0;\n" "> Thanks,\n" @@ -46,4 +46,4 @@ "\n" /Jarkko -f87d4d38cbc2963718455676ffdfb5139ece58da25e2718a77d26db88cf24875 +eaafd761f2b9005118ea5bff9525d51b571fffd73fddf4825e746733a841e8a0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.