From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mammedov Subject: Re: [Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions Date: Mon, 5 Mar 2018 14:00:36 +0100 Message-ID: <20180305140036.2f8c705a@redhat.com> References: <20180215042900.16078-1-f4bug@amsat.org> <20180215042900.16078-9-f4bug@amsat.org> <20180305132915.4dacc461@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1espjb-0006CN-31 for xen-devel@lists.xenproject.org; Mon, 05 Mar 2018 13:00:55 +0000 In-Reply-To: <20180305132915.4dacc461@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Marcel Apfelbaum , Paolo Bonzini , Anthony Perard , "open list:X86" , Richard Henderson List-Id: xen-devel@lists.xenproject.org T24gTW9uLCA1IE1hciAyMDE4IDEzOjI5OjE1ICswMTAwCklnb3IgTWFtbWVkb3YgPGltYW1tZWRv QHJlZGhhdC5jb20+IHdyb3RlOgoKPiBPbiBUaHUsIDE1IEZlYiAyMDE4IDAxOjI4OjM4IC0wMzAw Cj4gUGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPGY0YnVnQGFtc2F0Lm9yZz4gd3JvdGU6Cj4gCj4g PiBJdCBlYXNlIGNvZGUgcmV2aWV3LCB1bml0IGlzIGV4cGxpY2l0Lgo+ID4gCj4gPiBTaWduZWQt b2ZmLWJ5OiBQaGlsaXBwZSBNYXRoaWV1LURhdWTDqSA8ZjRidWdAYW1zYXQub3JnPgo+ID4gLS0t ICAKPiBbLi4uXQo+IAo+ID4gZGlmZiAtLWdpdCBhL2h3L2kzODYvYWNwaS1idWlsZC5jIGIvaHcv aTM4Ni9hY3BpLWJ1aWxkLmMKPiA+IGluZGV4IGRlYjQ0MGYyODYuLjljY2M2MTkyYjUgMTAwNjQ0 Cj4gPiAtLS0gYS9ody9pMzg2L2FjcGktYnVpbGQuYwo+ID4gKysrIGIvaHcvaTM4Ni9hY3BpLWJ1 aWxkLmMKPiA+IEBAIC0yMzIwLDggKzIzMjAsOCBAQCBidWlsZF90cG0yKEdBcnJheSAqdGFibGVf ZGF0YSwgQklPU0xpbmtlciAqbGlua2VyLCBHQXJyYXkgKnRjcGFsb2cpCj4gPiAgICAgICAgICAg ICAgICAgICAodm9pZCAqKXRwbTJfcHRyLCAiVFBNMiIsIHNpemVvZigqdHBtMl9wdHIpLCA0LCBO VUxMLCBOVUxMKTsKPiA+ICB9Cj4gPiAgCj4gPiAtI2RlZmluZSBIT0xFXzY0MEtfU1RBUlQgICg2 NDAgKiAxMDI0KQo+ID4gLSNkZWZpbmUgSE9MRV82NDBLX0VORCAgICgxMDI0ICogMTAyNCkKPiA+ ICsjZGVmaW5lIEhPTEVfNjQwS19TVEFSVCAgKDY0MCAqIEtfQllURSkKPiA+ICsjZGVmaW5lIEhP TEVfNjQwS19FTkQgICAoMTAyNCAqIEtfQllURSkgIAo+IG5pdDoKPiBjb3VsZCBiZSAxICogTV9C WVRFCj4gCj4gWy4uLl0KPiAKPiBSZXZpZXdlZC1ieTogSWdvciBNYW1tZWRvdiA8aW1hbW1lZG9A cmVkaGF0LmNvbT4KdGFraW5nIGl0IGJhY2sKCldoaWxlIGJ1aWxkaW5nIGl0LCBJIGdldDoKCklu IGZpbGUgaW5jbHVkZWQgZnJvbSBxZW11L2h3L2FjcGkvaWNoOS5jOjM4OjA6CnFlbXUvaW5jbHVk ZS9ody9pMzg2L2ljaDkuaDoyNToyODogZXJyb3I6IOKAmEtfQllUReKAmSB1bmRlY2xhcmVkIGhl cmUgKG5vdCBpbiBhIGZ1bmN0aW9uKQogI2RlZmluZSBJQ0g5X0NDX1NJWkUgKDE2ICogS19CWVRF KSAvKiBDaGlwc2V0IGNvbmZpZ3VyYXRpb24gcmVnaXN0ZXJzICovCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICBeCnFlbXUvaW5jbHVkZS9ody9pMzg2L2ljaDkuaDo1NjoyNTogbm90ZTogaW4g ZXhwYW5zaW9uIG9mIG1hY3JvIOKAmElDSDlfQ0NfU0laReKAmQogICAgIHVpbnQ4X3QgY2hpcF9j b25maWdbSUNIOV9DQ19TSVpFXTsKICAgICAgICAgICAgICAgICAgICAgICAgIF4KbWFrZTogKioq IFtody9hY3BpL2ljaDkub10gRXJyb3IgMQoKIAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9s aXN0aW5mby94ZW4tZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1espjc-000543-6f for qemu-devel@nongnu.org; Mon, 05 Mar 2018 08:01:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1espjZ-0003Nd-3P for qemu-devel@nongnu.org; Mon, 05 Mar 2018 08:00:56 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:44208 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1espjY-0003NX-Uk for qemu-devel@nongnu.org; Mon, 05 Mar 2018 08:00:53 -0500 Date: Mon, 5 Mar 2018 14:00:36 +0100 From: Igor Mammedov Message-ID: <20180305140036.2f8c705a@redhat.com> In-Reply-To: <20180305132915.4dacc461@redhat.com> References: <20180215042900.16078-1-f4bug@amsat.org> <20180215042900.16078-9-f4bug@amsat.org> <20180305132915.4dacc461@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 08/30] hw/i386: use the BYTE-based definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Cc: Stefano Stabellini , Eduardo Habkost , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Anthony Perard , "open list:X86" , Marcel Apfelbaum , Paolo Bonzini , Richard Henderson On Mon, 5 Mar 2018 13:29:15 +0100 Igor Mammedov wrote: > On Thu, 15 Feb 2018 01:28:38 -0300 > Philippe Mathieu-Daud=C3=A9 wrote: >=20 > > It ease code review, unit is explicit. > >=20 > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > --- =20 > [...] >=20 > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > index deb440f286..9ccc6192b5 100644 > > --- a/hw/i386/acpi-build.c > > +++ b/hw/i386/acpi-build.c > > @@ -2320,8 +2320,8 @@ build_tpm2(GArray *table_data, BIOSLinker *linker= , GArray *tcpalog) > > (void *)tpm2_ptr, "TPM2", sizeof(*tpm2_ptr), 4, NULL,= NULL); > > } > > =20 > > -#define HOLE_640K_START (640 * 1024) > > -#define HOLE_640K_END (1024 * 1024) > > +#define HOLE_640K_START (640 * K_BYTE) > > +#define HOLE_640K_END (1024 * K_BYTE) =20 > nit: > could be 1 * M_BYTE >=20 > [...] >=20 > Reviewed-by: Igor Mammedov taking it back While building it, I get: In file included from qemu/hw/acpi/ich9.c:38:0: qemu/include/hw/i386/ich9.h:25:28: error: =E2=80=98K_BYTE=E2=80=99 undeclar= ed here (not in a function) #define ICH9_CC_SIZE (16 * K_BYTE) /* Chipset configuration registers */ ^ qemu/include/hw/i386/ich9.h:56:25: note: in expansion of macro =E2=80=98ICH= 9_CC_SIZE=E2=80=99 uint8_t chip_config[ICH9_CC_SIZE]; ^ make: *** [hw/acpi/ich9.o] Error 1 =20