From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bin Liu Subject: Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers Date: Mon, 5 Mar 2018 11:38:02 -0600 Message-ID: <20180305173802.GB14921@uda0271908> References: <20180227222740.2150-1-merlijn@wizzup.org> <20180227222740.2150-2-merlijn@wizzup.org> <20180228215943.GI5448@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <20180228215943.GI5448@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: Merlijn Wajer , linux-omap@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: > * Merlijn Wajer [180227 22:29]: > > Without pm_runtime_{get,put}_sync calls in place, reading > > vbus status via /sys causes the following error: > > > > Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 > > pgd = b333e822 > > [fa0ab060] *pgd=48011452(bad) > > > > [] (musb_default_readb) from [] (musb_vbus_show+0x58/0xe4) > > [] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44) > > [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x80/0xdc) > > [] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448) > > [] (seq_read) from [] (__vfs_read+0x1c/0x118) > > [] (__vfs_read) from [] (vfs_read+0x90/0x144) > > [] (vfs_read) from [] (SyS_read+0x3c/0x74) > > [] (SyS_read) from [] (ret_fast_syscall+0x0/0x54) > > > > Solution was suggested by Tony Lindgren . > > > > Signed-off-by: Merlijn Wajer > > Thanks for fixing this. Assuming it passes Bin's tests: > > Acked-by: Tony Lindgren Applied and sent out. Thanks. -Bin. From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2,1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers From: Bin Liu Message-Id: <20180305173802.GB14921@uda0271908> Date: Mon, 5 Mar 2018 11:38:02 -0600 To: Tony Lindgren Cc: Merlijn Wajer , linux-omap@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: T24gV2VkLCBGZWIgMjgsIDIwMTggYXQgMDE6NTk6NDNQTSAtMDgwMCwgVG9ueSBMaW5kZ3JlbiB3 cm90ZToKPiAqIE1lcmxpam4gV2FqZXIgPG1lcmxpam5Ad2l6enVwLm9yZz4gWzE4MDIyNyAyMjoy OV06Cj4gPiBXaXRob3V0IHBtX3J1bnRpbWVfe2dldCxwdXR9X3N5bmMgY2FsbHMgaW4gcGxhY2Us IHJlYWRpbmcKPiA+IHZidXMgc3RhdHVzIHZpYSAvc3lzIGNhdXNlcyB0aGUgZm9sbG93aW5nIGVy cm9yOgo+ID4gCj4gPiBVbmhhbmRsZWQgZmF1bHQ6IGV4dGVybmFsIGFib3J0IG9uIG5vbi1saW5l ZmV0Y2ggKDB4MTAyOCkgYXQgMHhmYTBhYjA2MAo+ID4gcGdkID0gYjMzM2U4MjIKPiA+IFtmYTBh YjA2MF0gKnBnZD00ODAxMTQ1MihiYWQpCj4gPiAKPiA+IFs8YzA1MjYxYjA+XSAobXVzYl9kZWZh dWx0X3JlYWRiKSBmcm9tIFs8YzA1MjViZDA+XSAobXVzYl92YnVzX3Nob3crMHg1OC8weGU0KQo+ ID4gWzxjMDUyNWJkMD5dIChtdXNiX3ZidXNfc2hvdykgZnJvbSBbPGMwNGMwMTQ4Pl0gKGRldl9h dHRyX3Nob3crMHgyMC8weDQ0KQo+ID4gWzxjMDRjMDE0OD5dIChkZXZfYXR0cl9zaG93KSBmcm9t IFs8YzAyNTlmNzQ+XSAoc3lzZnNfa2Zfc2VxX3Nob3crMHg4MC8weGRjKQo+ID4gWzxjMDI1OWY3 ND5dIChzeXNmc19rZl9zZXFfc2hvdykgZnJvbSBbPGMwMjEwYmFjPl0gKHNlcV9yZWFkKzB4MjUw LzB4NDQ4KQo+ID4gWzxjMDIxMGJhYz5dIChzZXFfcmVhZCkgZnJvbSBbPGMwMWVkYjQwPl0gKF9f dmZzX3JlYWQrMHgxYy8weDExOCkKPiA+IFs8YzAxZWRiNDA+XSAoX192ZnNfcmVhZCkgZnJvbSBb PGMwMWVkY2NjPl0gKHZmc19yZWFkKzB4OTAvMHgxNDQpCj4gPiBbPGMwMWVkY2NjPl0gKHZmc19y ZWFkKSBmcm9tIFs8YzAxZWUxZDA+XSAoU3lTX3JlYWQrMHgzYy8weDc0KQo+ID4gWzxjMDFlZTFk MD5dIChTeVNfcmVhZCkgZnJvbSBbPGMwMTA2ZmUwPl0gKHJldF9mYXN0X3N5c2NhbGwrMHgwLzB4 NTQpCj4gPiAKPiA+IFNvbHV0aW9uIHdhcyBzdWdnZXN0ZWQgYnkgVG9ueSBMaW5kZ3JlbiA8dG9u eUBhdG9taWRlLmNvbT4uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IE1lcmxpam4gV2FqZXIgPG1l cmxpam5Ad2l6enVwLm9yZz4KPiAKPiBUaGFua3MgZm9yIGZpeGluZyB0aGlzLiBBc3N1bWluZyBp dCBwYXNzZXMgQmluJ3MgdGVzdHM6Cj4gCj4gQWNrZWQtYnk6IFRvbnkgTGluZGdyZW4gPHRvbnlA YXRvbWlkZS5jb20+CgpBcHBsaWVkIGFuZCBzZW50IG91dC4gVGhhbmtzLgoKLUJpbi4KLS0tClRv IHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBs aW51eC11c2IiIGluCnRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRvbW9Admdlci5rZXJu ZWwub3JnCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFq b3Jkb21vLWluZm8uaHRtbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AG47ELsMCQ8YpVyskdwtUQRN6vv6v9E9utKjAHftyi6liKJEVaQOOizYoohgRWH/t7Oa7/FCaclT ARC-Seal: i=1; a=rsa-sha256; t=1520271487; cv=none; d=google.com; s=arc-20160816; b=WcqVAHA++F93xCNGWsbeb7X6s6/kEPZkaduTkXCJgXV5LSYbGf74DfdEkg4f4+aOef NZkVEh0iK6moIPObGHgcDBXtIOEq2U/dXaqNIbSa2Fr/zhYKEhPTp+GGdH6WCM1hmxEO WndVqU1xAEgpBN9NfnHGife/ooiAeX5WqTWGXe5CEapcuJSJih52zvFfPOiswP6UX9KP m9iqhacQDPwG0C0PsPjmmHAmXe07wp2wIedkrUOJy4/ek0h7SNsXg8WUYh3fuxWaUp5i cAeEuE7DmCbOUV3q8+AxtR1bZ2J71Umg1hk9L7cXGYVmI03C8yyt67F1BxJ/CeJOcEdY 5maA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=uUabfIFfkH4wnwH7YyZKZfisqm8gtOK2yBLqVaQT4P4=; b=NtPTdntw/lKz8DC/1b53UrGVylq5U12G8E6HEPDDS0gJFbOSY+DxASgjAnV8SXv/rY rfqrUHuO14OXZ3P/7xaIlB9mlSwjWv5ILZtcU3Vw6QyVjUGY5fFI1Nyu+P6xNZFHXzlx tovQ7z40MWmSX0j6VuIoWRkAB5bat0197DpSH8IalbW80O2VRvrZTaPAMoSrIj5TBMS5 m5BiZzo8kEi/X0PN/4+83iqIVO7Ea3JEQu0wPsl11qi6GILoIELjNGHSv7hfXbG2JDKv 1uji52+rzOTwyNDKxhj6v2kJSyBNX4qnWyHAJ17WXy4URpOAMy2NzedLSI/uGXnqlB9X p0UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=qCNDnEzI; spf=pass (google.com: domain of b-liu@ti.com designates 198.47.27.80 as permitted sender) smtp.mailfrom=b-liu@ti.com; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=qCNDnEzI; spf=pass (google.com: domain of b-liu@ti.com designates 198.47.27.80 as permitted sender) smtp.mailfrom=b-liu@ti.com; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Date: Mon, 5 Mar 2018 11:38:02 -0600 From: Bin Liu To: Tony Lindgren CC: Merlijn Wajer , , Greg Kroah-Hartman , , Subject: Re: [PATCH v2 1/1] usb: musb: call pm_runtime_{get,put}_sync before reading vbus registers Message-ID: <20180305173802.GB14921@uda0271908> Mail-Followup-To: Bin Liu , Tony Lindgren , Merlijn Wajer , linux-omap@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180227222740.2150-1-merlijn@wizzup.org> <20180227222740.2150-2-merlijn@wizzup.org> <20180228215943.GI5448@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20180228215943.GI5448@atomide.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1593594893909061681?= X-GMAIL-MSGID: =?utf-8?q?1594120195048172768?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Feb 28, 2018 at 01:59:43PM -0800, Tony Lindgren wrote: > * Merlijn Wajer [180227 22:29]: > > Without pm_runtime_{get,put}_sync calls in place, reading > > vbus status via /sys causes the following error: > > > > Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060 > > pgd = b333e822 > > [fa0ab060] *pgd=48011452(bad) > > > > [] (musb_default_readb) from [] (musb_vbus_show+0x58/0xe4) > > [] (musb_vbus_show) from [] (dev_attr_show+0x20/0x44) > > [] (dev_attr_show) from [] (sysfs_kf_seq_show+0x80/0xdc) > > [] (sysfs_kf_seq_show) from [] (seq_read+0x250/0x448) > > [] (seq_read) from [] (__vfs_read+0x1c/0x118) > > [] (__vfs_read) from [] (vfs_read+0x90/0x144) > > [] (vfs_read) from [] (SyS_read+0x3c/0x74) > > [] (SyS_read) from [] (ret_fast_syscall+0x0/0x54) > > > > Solution was suggested by Tony Lindgren . > > > > Signed-off-by: Merlijn Wajer > > Thanks for fixing this. Assuming it passes Bin's tests: > > Acked-by: Tony Lindgren Applied and sent out. Thanks. -Bin.